From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754862AbdBPNTe (ORCPT ); Thu, 16 Feb 2017 08:19:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47842 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754612AbdBPNTd (ORCPT ); Thu, 16 Feb 2017 08:19:33 -0500 Subject: Re: [RFC PATCH 02/33] irqchip/gic-v3: Add VLPI/DirectLPI discovery To: Marc Zyngier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu References: <1484648454-21216-1-git-send-email-marc.zyngier@arm.com> <1484648454-21216-3-git-send-email-marc.zyngier@arm.com> Cc: Thomas Gleixner , Jason Cooper , Christoffer Dall From: Auger Eric Message-ID: Date: Thu, 16 Feb 2017 14:19:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1484648454-21216-3-git-send-email-marc.zyngier@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 16 Feb 2017 13:19:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 17/01/2017 11:20, Marc Zyngier wrote: > Add helper functions that probe for VLPI and DirectLPI properties. > > Signed-off-by: Marc Zyngier Besides the returned value previous questions, Reviewed-by: Eric Auger Eric > --- > drivers/irqchip/irq-gic-v3.c | 22 ++++++++++++++++++++++ > include/linux/irqchip/arm-gic-v3.h | 3 +++ > 2 files changed, 25 insertions(+) > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index 5cadec0..8a6de91 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -514,6 +514,24 @@ static int gic_populate_rdist(void) > return -ENODEV; > } > > +static int __gic_update_vlpi_properties(struct redist_region *region, > + void __iomem *ptr) > +{ > + u64 typer = gic_read_typer(ptr + GICR_TYPER); > + gic_data.rdists.has_vlpis &= !!(typer & GICR_TYPER_VLPIS); > + gic_data.rdists.has_direct_lpi &= !!(typer & GICR_TYPER_DirectLPIS); > + > + return 1; > +} > + > +static void gic_update_vlpi_properties(void) > +{ > + gic_scan_rdist_properties(__gic_update_vlpi_properties); > + pr_info("%sVLPI support, %sdirect LPI support\n", > + !gic_data.rdists.has_vlpis ? "no " : "", > + !gic_data.rdists.has_direct_lpi ? "no " : ""); > +} > + > static void gic_cpu_sys_reg_init(void) > { > /* > @@ -975,6 +993,8 @@ static int __init gic_init_bases(void __iomem *dist_base, > gic_data.domain = irq_domain_create_tree(handle, &gic_irq_domain_ops, > &gic_data); > gic_data.rdists.rdist = alloc_percpu(typeof(*gic_data.rdists.rdist)); > + gic_data.rdists.has_vlpis = true; > + gic_data.rdists.has_direct_lpi = true; > > if (WARN_ON(!gic_data.domain) || WARN_ON(!gic_data.rdists.rdist)) { > err = -ENOMEM; > @@ -983,6 +1003,8 @@ static int __init gic_init_bases(void __iomem *dist_base, > > set_handle_irq(gic_handle_irq); > > + gic_update_vlpi_properties(); > + > if (IS_ENABLED(CONFIG_ARM_GIC_V3_ITS) && gic_dist_supports_lpis()) > its_init(handle, &gic_data.rdists, gic_data.domain); > > diff --git a/include/linux/irqchip/arm-gic-v3.h b/include/linux/irqchip/arm-gic-v3.h > index e808f8a..b162bfa 100644 > --- a/include/linux/irqchip/arm-gic-v3.h > +++ b/include/linux/irqchip/arm-gic-v3.h > @@ -200,6 +200,7 @@ > > #define GICR_TYPER_PLPIS (1U << 0) > #define GICR_TYPER_VLPIS (1U << 1) > +#define GICR_TYPER_DirectLPIS (1U << 3) > #define GICR_TYPER_LAST (1U << 4) > > #define GIC_V3_REDIST_SIZE 0x20000 > @@ -427,6 +428,8 @@ struct rdists { > struct page *prop_page; > int id_bits; > u64 flags; > + bool has_vlpis; > + bool has_direct_lpi; > }; > > struct irq_domain; >