From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Ming Qian <ming.qian@nxp.com>,
mchehab@kernel.org, mirela.rabulea@oss.nxp.com,
hverkuil-cisco@xs4all.nl
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, xiahong.bao@nxp.com,
linux-imx@nxp.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 06/10] media: Add ABGR32_12 video format
Date: Fri, 10 Feb 2023 11:30:48 -0500 [thread overview]
Message-ID: <fb0cbea01cdb9dc526b458f234eec656300983fb.camel@ndufresne.ca> (raw)
In-Reply-To: <e09312997dbc544a69d687fba213c096bcdfc3e9.1675230665.git.ming.qian@nxp.com>
Le mercredi 01 février 2023 à 14:02 +0800, Ming Qian a écrit :
> ABGR32_12 is a reversed RGB format with alpha channel last,
> 12 bits per component like ABGR32,
> expanded to 16bits.
> Data in the 12 high bits, zeros in the 4 low bits,
> arranged in little endian order.
I would like to suggest ABGR64_12
Nicolas
>
> Signed-off-by: Ming Qian <ming.qian@nxp.com>
> ---
> Documentation/userspace-api/media/v4l/pixfmt-rgb.rst | 9 +++++++++
> drivers/media/v4l2-core/v4l2-common.c | 1 +
> drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
> include/uapi/linux/videodev2.h | 1 +
> 4 files changed, 12 insertions(+)
>
> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-rgb.rst b/Documentation/userspace-api/media/v4l/pixfmt-rgb.rst
> index da29ba69c2d9..cb60ffe8f860 100644
> --- a/Documentation/userspace-api/media/v4l/pixfmt-rgb.rst
> +++ b/Documentation/userspace-api/media/v4l/pixfmt-rgb.rst
> @@ -793,6 +793,15 @@ arranged in little endian order.
> - G\ :sub:`15-4`
> - R\ :sub:`15-4`
> -
> + * .. _V4L2-PIX-FMT-ABGR32-12:
> +
> + - ``V4L2_PIX_FMT_ABGR32_12``
> + - 'B412'
> +
> + - B\ :sub:`15-4`
> + - G\ :sub:`15-4`
> + - R\ :sub:`15-4`
> + - A\ :sub:`15-4`
>
> .. raw:: latex
>
> diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c
> index 024190f82cf1..4b3302a07f83 100644
> --- a/drivers/media/v4l2-core/v4l2-common.c
> +++ b/drivers/media/v4l2-core/v4l2-common.c
> @@ -253,6 +253,7 @@ const struct v4l2_format_info *v4l2_format_info(u32 format)
> { .format = V4L2_PIX_FMT_RGB555, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 2, 0, 0, 0 }, .hdiv = 1, .vdiv = 1 },
> { .format = V4L2_PIX_FMT_BGR666, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 4, 0, 0, 0 }, .hdiv = 1, .vdiv = 1 },
> { .format = V4L2_PIX_FMT_BGR24_12, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 6, 0, 0, 0 }, .hdiv = 1, .vdiv = 1 },
> + { .format = V4L2_PIX_FMT_ABGR32_12, .pixel_enc = V4L2_PIXEL_ENC_RGB, .mem_planes = 1, .comp_planes = 1, .bpp = { 8, 0, 0, 0 }, .hdiv = 1, .vdiv = 1 },
>
> /* YUV packed formats */
> { .format = V4L2_PIX_FMT_YUYV, .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 1, .comp_planes = 1, .bpp = { 2, 0, 0, 0 }, .hdiv = 2, .vdiv = 1 },
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index 329515786abb..0f772e19890b 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1299,6 +1299,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> case V4L2_PIX_FMT_RGBA32: descr = "32-bit RGBA 8-8-8-8"; break;
> case V4L2_PIX_FMT_RGBX32: descr = "32-bit RGBX 8-8-8-8"; break;
> case V4L2_PIX_FMT_BGR24_12: descr = "12-bit Depth BGR"; break;
> + case V4L2_PIX_FMT_ABGR32_12: descr = "12-bit Depth BGRA"; break;
> case V4L2_PIX_FMT_GREY: descr = "8-bit Greyscale"; break;
> case V4L2_PIX_FMT_Y4: descr = "4-bit Greyscale"; break;
> case V4L2_PIX_FMT_Y6: descr = "6-bit Greyscale"; break;
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index ab52a605e6c0..757ab14e7a6e 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -579,6 +579,7 @@ struct v4l2_pix_format {
>
> /* RGB formats (6 or 8 bytes per pixel) */
> #define V4L2_PIX_FMT_BGR24_12 v4l2_fourcc('B', '3', '1', '2') /* 48 BGR 12-bit per component */
> +#define V4L2_PIX_FMT_ABGR32_12 v4l2_fourcc('B', '4', '1', '2') /* 64 BGRA 12-bit per component */
>
> /* Grey formats */
> #define V4L2_PIX_FMT_GREY v4l2_fourcc('G', 'R', 'E', 'Y') /* 8 Greyscale */
next prev parent reply other threads:[~2023-02-10 16:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 6:02 [PATCH v2 00/10] media: imx-jpeg: Add support for 12 bit extended jpeg Ming Qian
2023-02-01 6:02 ` [PATCH v2 01/10] media: Add P012 and P012M video format Ming Qian
2023-02-01 6:02 ` [PATCH v2 02/10] media: Add Y012 " Ming Qian
2023-02-10 15:18 ` Nicolas Dufresne
2023-02-13 9:22 ` [EXT] " Ming Qian
2023-02-13 16:38 ` Nicolas Dufresne
2023-02-14 1:51 ` Ming Qian
2023-02-01 6:02 ` [PATCH v2 03/10] media: Add YUYV_12 " Ming Qian
2023-02-10 16:28 ` Nicolas Dufresne
2023-02-01 6:02 ` [PATCH v2 04/10] media: Add YUV24_12 " Ming Qian
2023-02-10 15:20 ` Nicolas Dufresne
2023-02-10 16:29 ` Nicolas Dufresne
2023-02-01 6:02 ` [PATCH v2 05/10] media: Add BGR24_12 " Ming Qian
2023-02-10 16:30 ` Nicolas Dufresne
2023-02-01 6:02 ` [PATCH v2 06/10] media: Add ABGR32_12 " Ming Qian
2023-02-10 16:30 ` Nicolas Dufresne [this message]
2023-02-01 6:02 ` [PATCH v2 07/10] media: imx-jpeg: Refine the function mxc_jpeg_find_format Ming Qian
2023-02-01 6:02 ` [PATCH v2 08/10] media: imx-jpeg: Clear slot next desc ptr if config error Ming Qian
2023-02-01 6:02 ` [PATCH v2 09/10] media: imx-jpeg: Decoder add support for 12bit jpeg Ming Qian
2023-02-01 6:02 ` [PATCH v2 10/10] media: imx-jpeg: Encoder " Ming Qian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb0cbea01cdb9dc526b458f234eec656300983fb.camel@ndufresne.ca \
--to=nicolas@ndufresne.ca \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ming.qian@nxp.com \
--cc=mirela.rabulea@oss.nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xiahong.bao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®