Re: [PATCH v2 1/2] spi: dt-bindings: add SPI IPM v59 compatible for mt7987 and mt7989

[Krzysztof Kozlowski <krzk@kernel.org>]

On 01/10/2026 10:15, Tim Kuo (郭廷笙) wrote:
> On Wed, 2026-09-30 at 12:36 +0200, Krzysztof Kozlowski wrote:
>> On Tue, Sep 29, 2026 at 02:25:15PM +0800, Tim Kuo wrote:
>>> MTK mt7987 and mt7989 SPI hardware has been updated to IPM v59 SPI
>>> IP and
>>> it differs from earlier IPM designs, most visibly in the tick delay
>>> field
>>> of SPI_CMD_REG, so it needs its own fallback compatible rather than
>>> reusing
>>> "mediatek,spi-ipm".
>>>
>>> Signed-off-by: Tim Kuo <Tim.Kuo@mediatek.com>
>>> ---
>>> v2: Add mt7987 and mt7989 real device compatible
>>>
>>>  .../devicetree/bindings/spi/mediatek,spi-mt65xx.yaml         | 5
>>> +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-
>>> mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-
>>> mt65xx.yaml
>>> index 3bf3eb1f8728..d2c740572d85 100644
>>> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-
>>> mt65xx.yaml
>>> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-
>>> mt65xx.yaml
>>> @@ -39,6 +39,11 @@ properties:
>>>                - mediatek,mt7988-spi-single
>>>                - mediatek,mt8188-spi-ipm
>>>            - const: mediatek,spi-ipm
>>> +      - items:
>>> +          - enum:
>>> +              - mediatek,mt7987-spi
>>> +              - mediatek,mt7989-spi
>>> +          - const: mediatek,spi-ipm-v59
>>
>> No, look at the binding and recent commits. This should be a specific
>> compatible. Git history easily tells you that.
>>
>> Best regards,
>> Krzysztof
>>
> 
> Thanks for the review. I went back through the binding and the history;
> let me confirm I took the right lesson from it before I send v3, and
> ask one thing about the DTS.

Did you just paste here LLM output to your prompt and followed up by
typical agent question "is this what you wanted"? If so, straight way to
get yourself PLONKed, because it is a plague.

Best regards,
Krzysztof