mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Dmitry Vyukov' <dvyukov@google.com>,
	syzbot <syzbot+0600986d88e2d4d7ebb8@syzkaller.appspotmail.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"dsahern@kernel.org" <dsahern@kernel.org>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"syzkaller-bugs@googlegroups.com"
	<syzkaller-bugs@googlegroups.com>,
	"yoshfuji@linux-ipv6.org" <yoshfuji@linux-ipv6.org>,
	linux-riscv <linux-riscv@lists.infradead.org>
Subject: RE: [syzbot] kernel panic: corrupted stack end in rtnl_newlink
Date: Mon, 14 Mar 2022 10:43:58 +0000	[thread overview]
Message-ID: <fb12b19d57c34928895e0faa8067f64c@AcuMS.aculab.com> (raw)
In-Reply-To: <CACT4Y+a1AvU4ZA3BXPpQMQ15A2T0CT_mrNTXv0NttJ0B06fH=w@mail.gmail.com>

From: Dmitry Vyukov
> Sent: 14 March 2022 09:09
> 
> On Mon, 14 Mar 2022 at 09:22, Dmitry Vyukov <dvyukov@google.com> wrote:
> >
> > On Mon, 14 Mar 2022 at 09:17, syzbot
> > <syzbot+0600986d88e2d4d7ebb8@syzkaller.appspotmail.com> wrote:
> > >
> > > Hello,
> > >
> > > syzbot found the following issue on:
> > >
> > > HEAD commit:    0966d385830d riscv: Fix auipc+jalr relocation range checks
> > > git tree:       git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git fixes
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=17fe80c5700000
> > > kernel config:  https://syzkaller.appspot.com/x/.config?x=6295d67591064921
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=0600986d88e2d4d7ebb8
> > > compiler:       riscv64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for
> Debian) 2.35.2
> > > userspace arch: riscv64
> >
> > +linux-riscv
> >
> > Riscv needs to increase stack size under KASAN.
> > I will send a patch.

With vmalloc()ed stacks is it possible to allocate an extra page
of KVA that isn't backed by memory as a 'guard page' so that
stack overflow faults immediately?

Probably worth enforcing for KASAN builds where the compilers
have a nasty habit of using lot more stack space that might
be expected.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

  reply	other threads:[~2022-03-14 10:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14  8:17 syzbot
2022-03-14  8:22 ` Dmitry Vyukov
2022-03-14  9:08   ` Dmitry Vyukov
2022-03-14 10:43     ` David Laight [this message]
2022-03-14 12:05       ` Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb12b19d57c34928895e0faa8067f64c@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=dvyukov@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=syzbot+0600986d88e2d4d7ebb8@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®