From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAE5B2BE7B6 for ; Tue, 30 Dec 2025 10:04:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767089065; cv=none; b=S5wXPC58OYmjnHItV6pUpVKvc0c0PPxMiGjyv4SKO6dYMEaNgpMkP3gKWBvl9MVw1Ux8dEE96G3UtT1LlMXlyKwjBzgcLhHafXjg0KNGV4y3Ho1EtB1cCjZ+T0vK9jvN2beePQ1g0cY+Pzw3rOPyhVSKR8z+sg8b5YatppCf9bI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767089065; c=relaxed/simple; bh=qbKKeWEq2vLhYTSjLQDA7S+unGm9/4ACooblaGiFMyA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K38qeNArLQw4rHyp6yZD5foZaqVIODF1pS5ScCxaC4oMzVKtXXGFMXGuZTVnhBKwiAM3yAX/iK5j8Ol8Rrx1x+nSNcD24vSwbXwK9bWcga+Az/YWaKawPjrjpzT/4KFELjKjm3gVutCRsiklxfdOvSaAHgmmjBPe1JADQCgy5V0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OaXrpU58; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OaXrpU58" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b7636c96b9aso1783232266b.2 for ; Tue, 30 Dec 2025 02:04:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767089062; x=1767693862; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6WNEswd8Mtkhh2MzhBhmvy7nphPTXS6cL7fDcvlIy2k=; b=OaXrpU58V7HXCIl/Dk2C17d09kSW6aG7f6rXstHTMUuaQlEgkN1bcKxo8AjsLjjazf 9g1ktDWXnZ3aPQvEOGH3DPIhdECfeyPtl2i5rfVnXqKVV7CO8QPhmu7Adicxp7MeoQbZ vyYjoOvUzBRYPDwge3TjAn3j3UFRbxrQAQXAav2/eShl5L/TMcQwtR2cWpj8PdygBshH 40HwfMZrCmVjHp/g6qBksRStDzsl7Zo8Q+Tfkoci4sOQkdN/aqIFJoP6STN1/Cu5QGkL f/23PkmOlDRcpUthr2oOObAmfxqBvACJg+brbttN+aSdopiMSL5RCP9QPGAaUsvrAvBb X7zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767089062; x=1767693862; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6WNEswd8Mtkhh2MzhBhmvy7nphPTXS6cL7fDcvlIy2k=; b=hZ0N9P0WKoZQwu57ep9X9RuMjgC8G+wfEmPgDcaUrH6iLwDAdty8C2m7GdHaSbX2uZ yiGGWPvixo7sF2NmtkkUz5wCE4t98nASviWaiRDuiCV87gO4E8/BqCr0u2tZevxf340i lgkOlo8rex3AzrcyLWie2e/8H5/kyxRpKjoV3CmT0wbibWCW5cVmDIn8O3HQUL1sqIGz 5Ugpi6aTgP9b3L5iH3wrGc41cWbvs1R+5ZIC3i2ctW6AxOLkVd0uqQL7dqtuG+C9GQEP NmCw+1m6hCcecpBzjWwJtMjGYEtijwZ/FLs+v4NgRW2lnCKM2IKfZGVreSp9ABBbQhF0 Teqg== X-Forwarded-Encrypted: i=1; AJvYcCWHm3NL+rgQ4z2UNcka0w2LDw0ZXL1LC26KZN64sn6MS0dhnumLTBFvyiA9AeVPJlS+RlSwD8fDe8IdjK4=@vger.kernel.org X-Gm-Message-State: AOJu0YzA68hGE/jscd7ApbUqON+MImLYqXAY7lO2C9dYraBxmNo3vzce a1zNZGDokz/dDWnPVmieNkqKMk5e8pZcaVIOl+NfLeXcKyt90no0La5VLTbxDUmWz0o= X-Gm-Gg: AY/fxX5XN0kmz78I/f2xgGbT+caxSUktuswsSk7W0OggkOkzVWIy8dOc8lqyDGbO61F oiEHcGd9AY0jfDRwuhUJ7IA5WFDDrZrZHbU5naR8DgOmvVVf5CmCjTLGcNQOWT3ArPQMyF5jg/L e3ptctmmjhiHJtVeA1asEAwsWe7VwNO7NRBoe7Nicpd62XOPA6cc7Hrrdk7dKRFNZalUD6mLjRK l65PIKlyA2zyOQ2whNlwiSF4uXZ/a4KPj+NSkpbSLj+P/ITgGuDKqfOWU/ImN648l/Q4Z5jL1SQ nSbckyJ4nJsOH097q7s3DYAGLXdPLPzyTflDOR/wUKb0IN2SmZ1zB0J93RnWYjh60+fy6v+YXrw SuBxAXnL8yO2b/ta0DpZWvgB1eAOEtFAi8Vn0Gi3jLSTGR0d914HDq3HGCm+ifGe2Bvg5XeHhLP fyxw8rYxJPJ4KTUiihKKAZ/C1F4vcxGUTGqg2tFF0J7SDV3M3IICQHFZv8eISxdqecoqGrmw2Gn /2RhUit1GLQezmyyhf/OW7Oo3io6BbaFLoN0F0Qpr61UgDwheo/i+7g8E32UTB9bBc55w0zQyta Ng== X-Google-Smtp-Source: AGHT+IHdtwQVLXyaFzsVuA4txA2fjcLIAy3ihr4xpyI7VbWbj8PKWM46C39EwrEHTvV50cTVPP7KTQ== X-Received: by 2002:a17:907:7fa8:b0:b73:572d:3b07 with SMTP id a640c23a62f3a-b8036fac50amr3658273666b.28.1767089062179; Tue, 30 Dec 2025 02:04:22 -0800 (PST) Received: from ?IPV6:2001:1c06:2302:5600:7555:cca3:bbc4:648b? (2001-1c06-2302-5600-7555-cca3-bbc4-648b.cable.dynamic.v6.ziggo.nl. [2001:1c06:2302:5600:7555:cca3:bbc4:648b]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037a5bdf3sm3616464466b.12.2025.12.30.02.04.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 02:04:21 -0800 (PST) Message-ID: Date: Tue, 30 Dec 2025 10:04:15 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] media: qcom: camss: vfe: Fix out-of-bounds access in vfe_isr_reg_update() To: Alper Ak Cc: hverkuil@kernel.org, jonathan@marek.ca, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, mchehab@kernel.org, rfoss@kernel.org, todor.too@gmail.com, vladimir.zapolskiy@linaro.org References: <8d260d93-38cc-459d-b8f5-40bec5497277@linaro.org> <20251229075217.24679-1-alperyasinak1@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20251229075217.24679-1-alperyasinak1@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/12/2025 07:52, Alper Ak wrote: > vfe_isr() iterates using MSM_VFE_IMAGE_MASTERS_NUM(7) as the loop > bound and passes the index to vfe_isr_reg_update(). However, > vfe->line[] array is defined with VFE_LINE_NUM_MAX(4): > > struct vfe_line line[VFE_LINE_NUM_MAX]; > > When index is 4, 5, 6, the access to vfe->line[line_id] exceeds > the array bounds and resulting in out-of-bounds memory access. > > Fix this by using separate loops for output lines and write masters. > > Fixes: 4edc8eae715c ("media: camss: Add initial support for VFE hardware version Titan 480") > Signed-off-by: Alper Ak > --- > drivers/media/platform/qcom/camss/camss-vfe-480.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe-480.c b/drivers/media/platform/qcom/camss/camss-vfe-480.c > index 4feea590a47b..d73f733fde04 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe-480.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe-480.c > @@ -202,11 +202,13 @@ static irqreturn_t vfe_isr(int irq, void *dev) > writel_relaxed(status, vfe->base + VFE_BUS_IRQ_CLEAR(0)); > writel_relaxed(1, vfe->base + VFE_BUS_IRQ_CLEAR_GLOBAL); > > - /* Loop through all WMs IRQs */ > - for (i = 0; i < MSM_VFE_IMAGE_MASTERS_NUM; i++) { > + for (i = 0; i < MAX_VFE_OUTPUT_LINES; i++) { > if (status & BUS_IRQ_MASK_0_RDI_RUP(vfe, i)) > vfe_isr_reg_update(vfe, i); > + } > > + /* Loop through all WMs IRQs */ > + for (i = 0; i < MSM_VFE_IMAGE_MASTERS_NUM; i++) { > if (status & BUS_IRQ_MASK_0_COMP_DONE(vfe, RDI_COMP_GROUP(i))) > vfe_buf_done(vfe, i); > } LGTM - assuming hardware tests pass. Reviewed-by: Bryan O'Donoghue --- bod