mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yisheng Xie <xieyisheng1@huawei.com>
To: Laura Abbott <labbott@redhat.com>, <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, sumit.semwal@linaro.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android: ion: minor cleanup for ion_page_pool
Date: Wed, 7 Feb 2018 08:47:20 +0800	[thread overview]
Message-ID: <fb1536ee-5223-4cd9-4698-f37ea8a6741c@huawei.com> (raw)
In-Reply-To: <19448c54-7214-ce7c-1ae0-9e8605e34f2c@redhat.com>

Hi Laura,

On 2018/2/7 6:51, Laura Abbott wrote:
> On 01/31/2018 01:50 AM, Yisheng Xie wrote:
>> ion_page_pool.c now is used to apply pool APIs for system heap, which do
>> not need do any initial at device_initcall.
>>
>> Meanwhile, this patch also remove some useless include files.
>>
> 
> Acked-by: Laura Abbott <labbott@redhat.com>

Thanks, and I split this into two small patchs as Greg's suggestion in a resent patch.

Yisheng

> 
>> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
>> ---
>>   drivers/staging/android/ion/ion_page_pool.c | 11 -----------
>>   1 file changed, 11 deletions(-)
>>
>> diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
>> index 817849d..3c1eba5 100644
>> --- a/drivers/staging/android/ion/ion_page_pool.c
>> +++ b/drivers/staging/android/ion/ion_page_pool.c
>> @@ -14,12 +14,7 @@
>>    *
>>    */
>>   -#include <linux/debugfs.h>
>> -#include <linux/dma-mapping.h>
>> -#include <linux/err.h>
>> -#include <linux/fs.h>
>>   #include <linux/list.h>
>> -#include <linux/init.h>
>>   #include <linux/slab.h>
>>   #include <linux/swap.h>
>>   @@ -171,9 +166,3 @@ void ion_page_pool_destroy(struct ion_page_pool *pool)
>>   {
>>       kfree(pool);
>>   }
>> -
>> -static int __init ion_page_pool_init(void)
>> -{
>> -    return 0;
>> -}
>> -device_initcall(ion_page_pool_init);
>>
> 
> 
> .
> 

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

      reply	other threads:[~2018-02-07  0:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31  9:50 Yisheng Xie
2018-01-31 11:32 ` Greg KH
2018-02-01  0:57   ` Yisheng Xie
2018-02-06 22:51 ` Laura Abbott
2018-02-07  0:47   ` Yisheng Xie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb1536ee-5223-4cd9-4698-f37ea8a6741c@huawei.com \
    --to=xieyisheng1@huawei.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®