From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1C65C433DB for ; Tue, 26 Jan 2021 05:23:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 998F42053B for ; Tue, 26 Jan 2021 05:23:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730337AbhAZFWo (ORCPT ); Tue, 26 Jan 2021 00:22:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:56319 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727290AbhAYJzp (ORCPT ); Mon, 25 Jan 2021 04:55:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611568418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hrcm87Lm5vA7qkXiODp26/0zBnb9xwFRvemPxGgdCUw=; b=BiO+ZG1Sv2A5PVubItERHHC6jGQ73huskNBGcB3x5pclq9s4+gXgmKn0I0XI/87WEcJSdX s9NC5xGNb5OZ2n/4Okkz03RmEgqMgtXARnC1SkWLY2/F0lMcOgSfWRmi8PCy/oibUpy09n 3jCg8GzQvDo5NJWPQ8BKsEcjMcUGc9c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-366-w9-sc5eSOOSknhbbMcDNeg-1; Mon, 25 Jan 2021 04:53:33 -0500 X-MC-Unique: w9-sc5eSOOSknhbbMcDNeg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 61E651005504; Mon, 25 Jan 2021 09:53:31 +0000 (UTC) Received: from [10.36.115.13] (ovpn-115-13.ams2.redhat.com [10.36.115.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id AADDC5D9D7; Mon, 25 Jan 2021 09:53:28 +0000 (UTC) Subject: Re: [PATCH V4 0/4] mm/memory_hotplug: Pre-validate the address range with platform To: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org, hca@linux.ibm.com, catalin.marinas@arm.com Cc: Oscar Salvador , Vasily Gorbik , Will Deacon , Ard Biesheuvel , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <1611543532-18698-1-git-send-email-anshuman.khandual@arm.com> <8260d6fe-7df5-c667-2514-0d94cf87d31c@arm.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Mon, 25 Jan 2021 10:53:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <8260d6fe-7df5-c667-2514-0d94cf87d31c@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.01.21 10:52, Anshuman Khandual wrote: > > > On 1/25/21 2:55 PM, David Hildenbrand wrote: >> On 25.01.21 03:58, Anshuman Khandual wrote: >>> This series adds a mechanism allowing platforms to weigh in and prevalidate >>> incoming address range before proceeding further with the memory hotplug. >>> This helps prevent potential platform errors for the given address range, >>> down the hotplug call chain, which inevitably fails the hotplug itself. >>> >>> This mechanism was suggested by David Hildenbrand during another discussion >>> with respect to a memory hotplug fix on arm64 platform. >>> >>> https://lore.kernel.org/linux-arm-kernel/1600332402-30123-1-git-send-email-anshuman.khandual@arm.com/ >>> >>> This mechanism focuses on the addressibility aspect and not [sub] section >>> alignment aspect. Hence check_hotplug_memory_range() and check_pfn_span() >>> have been left unchanged. Wondering if all these can still be unified in >>> an expanded memhp_range_allowed() check, that can be called from multiple >>> memory hot add and remove paths. >>> >>> This series applies on v5.11-rc5 and has been tested on arm64. But only >>> build tested on s390. >>> >> >> Note that this fails to apply right now to both, -next and Linus' tree. >> Do you have a branch with he patches on top I can use for a quick test? >> Thanks >> > > Applied all four patches on v5.11-rc5. > > https://gitlab.arm.com/linux-arm/linux-anshuman/-/tree/mm/hotplug_callback/v4/ > Ah, my fault, they do apply directly on v5.11-rc5 (not sure what I messed up jumping between branches - thanks!). Will give it a test. -- Thanks, David / dhildenb