From: Paolo Bonzini <pbonzini@redhat.com>
To: Nick Desaulniers <ndesaulniers@google.com>,
Sean Christopherson <seanjc@google.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Jim Mattson <jmattson@google.com>,
torvic9@mailbox.org, "vkuznets@redhat.com" <vkuznets@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"bp@alien8.de" <bp@alien8.de>
Subject: Re: [BUG] [5.15] Compilation error in arch/x86/kvm/mmu/spte.h with clang-14
Date: Thu, 14 Oct 2021 22:50:45 +0200 [thread overview]
Message-ID: <fb1da4d3-9e3e-4604-2f30-30292f9d13aa@redhat.com> (raw)
In-Reply-To: <CAKwvOdkC7ydAWs+nB3cxEOrbb7uEjiyBWg1nOOBtKqaCh3zhBg@mail.gmail.com>
On 14/10/21 21:06, Nick Desaulniers wrote:
>> If we want to fix this, my vote is for casting to an int and updating the comment
>
> At the least, I think bitwise operations should only be performed on
> unsigned types.
This is not a bitwise operation, it's a non-short-circuiting boolean
operation. I'll apply Jim's suggestion.
Paolo
next prev parent reply other threads:[~2021-10-14 20:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 9:08 torvic9
2021-10-04 9:26 ` Paolo Bonzini
2021-10-04 9:30 ` torvic9
2021-10-04 9:49 ` Paolo Bonzini
2021-10-04 10:10 ` torvic9
2021-10-04 14:33 ` torvic9
2021-10-04 16:13 ` Nick Desaulniers
2021-10-04 17:12 ` Jim Mattson
2021-10-14 17:50 ` Nathan Chancellor
2021-10-14 18:31 ` Sean Christopherson
2021-10-14 19:06 ` Nick Desaulniers
2021-10-14 20:50 ` Paolo Bonzini [this message]
2021-10-15 9:17 ` Christophe de Dinechin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb1da4d3-9e3e-4604-2f30-30292f9d13aa@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=torvic9@mailbox.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®