Re: [PATCH v3 4/4] arm64: dts: qcom: Add support for X1-based Asus Zenbook A14

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 4/17/25 1:20 AM, Aleksandrs Vinarskis wrote:
> Initial support for Asus Zenbook A14. Particular moddel exists
> in X1-26-100, X1P-42-100 (UX3407QA) and X1E-78-100 (UX3407RA).
> 
> Mostly similar to other X1-based laptops. Notable differences are:
> * Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA
>   and Qualcomm FastConnect 7800 on UX3407RA
> * USB Type-C retimers are Parade PS8833, appear to behave identical
>   to Parade PS8830
> * gpio90 is TZ protected
> 
> Working:
> * Keyboard
> * Touchpad
> * NVME
> * Lid switch
> * Camera LED
> * eDP (FHD OLED, SDC420D) with brightness control
> * Bluetooth, WiFi (WCN6855)
> * USB Type-A port
> * USB Type-C ports in USB2/USB3/DP (both orientations)
> * aDSP/cDPS firmware loading, battery info
> * Sleep/suspend, nothing visibly broken on resume
> 
> Out of scope of this series:
> * Audio (Speakers/microphones/headphone jack)
> * Camera (OmniVision OV02C10)
> * HDMI (Parade PS185HDM)
> * EC
> 
> Add dtsi and create two configurations for UX3407QA, UX3407RA.
> Tested on UX3407QA with X1-26-100.
> 
> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> ---

[...]

> +	/* Left-side display-adjacent port, PS8833 */

nit: The mention of PS8833 in the comment is rather uneventful given it
says so right below it as well

> +	typec-mux@8 {
> +		compatible = "parade,ps8833", "parade,ps8830";

[...]

> +&uart14 {
> +	status = "okay";
> +
> +	bluetooth {
> +		/* TODO: add pwrseq once validated */
> +		compatible = "qcom,wcn7850-bt";
> +
> +		max-speed = <3000000>;
> +	};
> +};

Drop it for now, the dt checker is angry about partial definitions

I think it looks ok otherwise

Konrad