From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31ABDC6FA8F for ; Thu, 24 Aug 2023 16:56:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242749AbjHXQzx (ORCPT ); Thu, 24 Aug 2023 12:55:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242750AbjHXQzk (ORCPT ); Thu, 24 Aug 2023 12:55:40 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 819DF1989 for ; Thu, 24 Aug 2023 09:55:38 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7FB391007; Thu, 24 Aug 2023 09:56:18 -0700 (PDT) Received: from [10.1.197.60] (eglon.cambridge.arm.com [10.1.197.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 84EFD3F740; Thu, 24 Aug 2023 09:55:35 -0700 (PDT) Message-ID: Date: Thu, 24 Aug 2023 17:55:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v5 10/24] tick/nohz: Move tick_nohz_full_mask declaration outside the #ifdef Content-Language: en-GB To: Reinette Chatre , x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, xingxin.hx@openanolis.org, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com References: <20230728164254.27562-1-james.morse@arm.com> <20230728164254.27562-11-james.morse@arm.com> <989616c3-ea4c-1c9b-b857-6d8bcb4843bd@intel.com> From: James Morse In-Reply-To: <989616c3-ea4c-1c9b-b857-6d8bcb4843bd@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Reinette, On 09/08/2023 23:34, Reinette Chatre wrote: > On 7/28/2023 9:42 AM, James Morse wrote: >> tick_nohz_full_mask lists the CPUs that are nohz_full. This is only >> needed when CONFIG_NO_HZ_FULL is defined. tick_nohz_full_cpu() allows >> a specific CPU to be tested against the mask, and evaluates to false >> when CONFIG_NO_HZ_FULL is not defined. >> >> The resctrl code needs to pick a CPU to run some work on, a new helper >> prefers housekeeping CPUs by examining the tick_nohz_full_mask. Hiding >> the declaration behind #ifdef CONFIG_NO_HZ_FULL forces all the users to >> be behind an ifdef too. >> >> Move the tick_nohz_full_mask declaration, this lets callers drop the >> ifdef, and guard access to tick_nohz_full_mask with IS_ENABLED() or >> something like tick_nohz_full_cpu(). >> >> The definition does not need to be moved as any callers should be >> removed at compile time unless CONFIG_NO_HZ_FULL is defined. >> >> Signed-off-by: James Morse >> --- >> include/linux/tick.h | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) > > This is outside of the resctrl area. What is the upstreaming > plan for this patch? Once you're happy with the rest of it - we can give the other folk on CC a poke. I'd assume changes to this file also go via tip. It would just need an ack from the relevant person. Thanks, James