From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7799A392814 for ; Mon, 30 Mar 2026 20:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774904030; cv=none; b=WlthyxBO8iXHoBc02v50NtBT/W3NBXBcsQTGOIipFm5o6eYTyOtqNzErn5qlaC/34uqsl8uKEAimp5cjj5iqEu6djGWJlsMASvU/3aDlUtcERw6Ng1DQBwW8VoSLihItoRyhfTdE2F5nshku+l7+6e2d9J18Ds5dZBpV3a9yK4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774904030; c=relaxed/simple; bh=r2bDbbwinBhT0kImelkuosKYz2ehp+3o7+Sa+58qmuE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OE8wpfweN4e+PtHhms1P8V+wuaUMolHJ5Td0eO7mI0R2nzw1ddjPvlK/hEnhS8hAab4QZW31mzSazTB3O/cjJVkJviaz7dj5CGnFlAr6FL0pAXh+dbPXsQLhoJRF+FTz47Pq+XesNjF+is/ee7ipqdoRl9IGqtJWIb08YfrI9UQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hi8SXscp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dKPTu4CY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hi8SXscp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dKPTu4CY" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UEgi1c3539560 for ; Mon, 30 Mar 2026 20:53:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4NMG2Us6RdtOdQH6URthKWnEZugYWrLpT5hHK0H9okE=; b=hi8SXscplMRd7i0j opOa0miUqPFOpcsU01HRL+wCujH+UmEMpqkXrclnduJJj6GxupX2D/zwibURTHu9 TDNrgQ8YpdpmU0JH0bAMbn7W2TBwg1wlyc3+ygjHaEIw4TDqtLsnusut32caIxTf 5bO+hmhu/9e60sgR/T1kcaNv8POnxUMnmVnltjbtZgz/4BPvMHD07R40tjQumFzo IRZfIK2HatfFSgFrFW+2K7GVgz7PkS+ICaT74zl6kZMxkOhipc3tV9ywsz97+wv/ qKBpr1s/6+jfwmjj4KEWxLM5hx9mRCeQ+eUmL0Dbz7WsDPKhMRn9T7sNnddplSd2 mIcuZA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7q59tfpy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 20:53:48 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b242062308so78657845ad.2 for ; Mon, 30 Mar 2026 13:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774904028; x=1775508828; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4NMG2Us6RdtOdQH6URthKWnEZugYWrLpT5hHK0H9okE=; b=dKPTu4CY4ntyilNaAza5QTpb+JnA2ez60tFfgUNdwc55bipxJtGos6I8IQefSudBNl VGLSVorpCm8rHDRO3KgUKP2hAHG0H4LqJ+nDzbY9MS5aOO6GmVLz7w7zs7nYzDA8zH0s zR27L/yzV25gbIeG7Y7buQph9tBsSi3cDZLztGZmRS+BTkpYkd4WphgvEp0kZT01SKBR L1JVSVFohGNxKgKI1G2R95meAOGj5J6HnpBfIsICB2UnzQOu3ltLLGZyYT9czK/SjmGO 9Zz71ATaiDiwuzFQl/KJdAryTH2YRILUp2P6oPJwt1O7anLOTc+euxMnB3KA/3NP+uTX p7RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774904028; x=1775508828; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4NMG2Us6RdtOdQH6URthKWnEZugYWrLpT5hHK0H9okE=; b=I6w+GRZh0KBBjwuQxZrXZe11kI9R5MnwmPYpXV9KuS7Nb0Wj2kdHdsPAXPxzibAwQ1 OnPl0RFTJm7e4p9CXGW5+pb59o7zM4/1+ayX9RZ4yxRh0f4uNeVlpZ2ugVN9Rfy934tx fG5jeEAM9My2/bl0iaHjeTK4n56lMV2P3KAOw+gaEdrvC0p2yBLYA9gUgeT5oFtzzL9K /eXjc8BEfWSIU2KSKFJzy+vIFlt2j0uXjylsIOz6KcZtEVaiY9R4iQTM3ae3csao5ZXE 5E++twZOt4vRj3JtBppKBhsVfDioDBuaC0u1WKAisVv06acToGm1XeMTIpaxg4d+mWJM ADgw== X-Forwarded-Encrypted: i=1; AJvYcCXn5XSrpbzTPs5CSwojvAnruefaILO5V8cFXLtgeko5mCAWf+3qir1fXtCD68r2wLdInL5AJN8s010rf1o=@vger.kernel.org X-Gm-Message-State: AOJu0YxtriaQpvrqbW7tONJiKF7ikJpNV7boyQcHoZAyeJnG8GDGajv/ 3Da3eKfnGfmuzUO81bCUoQBYEDUo54Lec/v7i5wI5UToXQfooRDNbppQDW6g5cueGIV8tSEzARV uwoRH1TSAphwSUXq+RUuJPjgf6Pmw/idJVk5vwCrIkpmo/UFEtoEANU0Fhv9nmn2cAkLvCiy0Oe U= X-Gm-Gg: ATEYQzxjEV/SJcHtwxv0kDbzePQXl2n7Rgyrv5wlJeoNnlCRcpN34R7T/yXn/sA4n8h gswYwqL4EI/Mq33HGFu8BQSdMxIICtTbIx+o12YMdIySK3GvGoptzQxUIuhD5SjmGWl6BDMBsvi 5nyW73LMcM5a3rzIiurJaplG+3LeiRO/RZ3Pe/9lCCK+KAcelb4Y8t0fFGLmHPhXjwdgUPxXz/q PPAF9BDhuhDkFdsfGX0BuyDDjvUjsT7tbOEeYRUQKDqbF19H19yzM+dWUpSQrsunC523TFHb85f 9BVhViqHrFj9nzTeXMjRu9JD/sS5mheippVr9xnj+zc0uTMvX2Z2OHvg+HnNU7SM7Q/DQvWs6vO ds5imqlHa4BlpmI9oLyyoyXdFjZj4lsuG4rTF+ScMUwaV X-Received: by 2002:a17:903:228e:b0:2b0:62dd:3a80 with SMTP id d9443c01a7336-2b0cdc28171mr154611725ad.17.1774904027887; Mon, 30 Mar 2026 13:53:47 -0700 (PDT) X-Received: by 2002:a17:903:228e:b0:2b0:62dd:3a80 with SMTP id d9443c01a7336-2b0cdc28171mr154611455ad.17.1774904027321; Mon, 30 Mar 2026 13:53:47 -0700 (PDT) Received: from [10.91.121.222] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24265aa9fsm87281055ad.20.2026.03.30.13.53.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 13:53:46 -0700 (PDT) Message-ID: Date: Tue, 31 Mar 2026 02:23:38 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/17] drm/msm/adreno: Coredump on GPU/GMU init failures To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann References: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> <20260327-a8xx-gpu-batch2-v2-8-2b53c38d2101@oss.qualcomm.com> <8114a15d-510d-498d-af79-a75493a8fc71@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <8114a15d-510d-498d-af79-a75493a8fc71@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: JmdySFTDHSUcGjNP4bc7JhoOZeMhUKmR X-Proofpoint-GUID: JmdySFTDHSUcGjNP4bc7JhoOZeMhUKmR X-Authority-Analysis: v=2.4 cv=EcXFgfmC c=1 sm=1 tr=0 ts=69cae2dc cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=O8mXyku17EuJp1xFqKwA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDE3NiBTYWx0ZWRfX/2yQVv3zQ800 cygJy0VGPgI3Z/e3Rl51J3pyMNNkjM0YqNrN6zw5xqmHvYAD/MZ/zRezGS+/o863FwU1azU53q5 D7mMSdNSNd1Nh5Zc6pIL+qZz4Pq/ETZO7t5cp81ew7R6UeYTpjU2uIIpDYp1ATbOol3mgR4YQNR 3G60DanykTTV8W9muyQzHA/F46jjJOIPyO/MLEkJvS1V+zydlYNdq5x16Vm+HWF2e9ZqDtOckyf fZ7xNNzqKBmw/uZZm5WwKVNH23RXKoDU5YEipMBigOkGZnjiwQxIvxDG21wkVriMK9Av2rkiwGW JvJbjQYg/lOChx1biaY2uy/vl2YJjAnrULhySXVY+AaPtGyFRhfWbUPNnBbKbZaFqWxf+6AMI8j x63HVsqOU/XANg31bO7zQ+qJlqAAPuuoN7IREfTJVlpnxgiW0Fn6ycUxdrWKrdsxX6DhfSuzsoc OJiyAMNTXe3tM3ixRVw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-30_01,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300176 On 3/27/2026 5:05 PM, Konrad Dybcio wrote: > On 3/27/26 1:13 AM, Akhil P Oommen wrote: >> Capture coredump on GPU or GMU errors during initialization to help in >> debugging the issues. To be consistent with the locks while calling >> msm_gpu_crashstate_capture(), call pm_runtime_get(gpu) always with >> msm_gpu->lock. >> >> Signed-off-by: Akhil P Oommen >> --- > > [...] > > >> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c >> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c >> @@ -391,10 +391,13 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx, >> return 0; >> case MSM_PARAM_TIMESTAMP: >> if (adreno_gpu->funcs->get_timestamp) { >> + mutex_lock(&gpu->lock); >> pm_runtime_get_sync(&gpu->pdev->dev); >> + >> *value = adreno_gpu->funcs->get_timestamp(gpu); >> - pm_runtime_put_autosuspend(&gpu->pdev->dev); >> >> + pm_runtime_put_autosuspend(&gpu->pdev->dev); >> + mutex_unlock(&gpu->lock); > > This is something to take care of in a separate patch, but get_sync may > fail and then the read could crash the device (GMU may be off too) > > put_autosuspend could theroetically fail too, but perhaps -edontcarethatmuch Right. That is something we should fix everywhere separately. -Akhil. > > Konrad