From: Christian Loehle <christian.loehle@arm.com>
To: Shubhang Kaushik OS <Shubhang@os.amperecomputing.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Shubhang Kaushik <sh@gentwo.org>,
Shijie Huang <Shijie.Huang@amperecomputing.com>,
Frank Wang <zwang@amperecomputing.com>
Cc: Christopher Lameter <cl@gentwo.org>,
Adam Li <adam.li@amperecomputing.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] sched/fair: Prefer cache locality for EAS wakeup
Date: Fri, 31 Oct 2025 18:11:33 +0000 [thread overview]
Message-ID: <fb34c6d2-291e-4b03-bfd8-372a6cd464ba@arm.com> (raw)
In-Reply-To: <MW6PR01MB8368CC4C901DBAF9BE19579EF5F8A@MW6PR01MB8368.prod.exchangelabs.com>
On 10/31/25 16:59, Shubhang Kaushik OS wrote:
> Yes, I agree that EAS approach is not suitable in this case as they require a heterogenous CPU topology.
> The issue is that the existing checks are for a completely idle CPU, whereas `cpu_overutilized` implies
> the CPU is busy but not yet overloaded. I ventured into EAS as this `cpu_overutilized` relies on
> `sched_energy_enabled()` being active. The point I wanted to convey is that - we still need a `cpu_busy?`
> check to make use of the cache locality - for SMP systems. Would appreciate some pointers on the same lines..
So the main issue is that with existing code if a CPU is "overloaded" isn't all that well defined.
For EAS we know if !rd->overloaded => all CPUs are !cpu_overutilized(). We could just pick any where
the task still fits (and we do).
For SMP what 'overloaded' will actually mean depends on the rest of the system (or at least domain).
> Regards,
> Shubhang
> [sip]
next prev parent reply other threads:[~2025-10-31 18:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 19:19 Shubhang Kaushik via B4 Relay
2025-10-31 10:17 ` Christian Loehle
2025-10-31 16:59 ` Shubhang Kaushik OS
2025-10-31 18:11 ` Christian Loehle [this message]
2025-11-02 10:06 ` Christian Loehle
2025-11-02 7:12 ` Madadi Vineeth Reddy
2025-11-03 9:04 ` Vincent Guittot
2025-11-13 0:26 ` Shubhang Kaushik OS
2025-11-13 14:54 ` Dietmar Eggemann
2025-11-14 18:27 ` Shubhang Kaushik OS
2025-11-14 13:36 ` Vincent Guittot
2025-11-18 1:27 ` Shubhang Kaushik OS
2025-11-20 14:37 ` Vincent Guittot
2025-11-13 0:03 Shubhang Kaushik Prasanna Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb34c6d2-291e-4b03-bfd8-372a6cd464ba@arm.com \
--to=christian.loehle@arm.com \
--cc=Shijie.Huang@amperecomputing.com \
--cc=Shubhang@os.amperecomputing.com \
--cc=adam.li@amperecomputing.com \
--cc=bsegall@google.com \
--cc=cl@gentwo.org \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sh@gentwo.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zwang@amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®