From: Greg Ungerer <gerg@linux-m68k.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] fix missing handling of __user in nommu's uaccess()
Date: Sat, 30 May 2020 10:59:55 +1000 [thread overview]
Message-ID: <fb352763-1ed1-2072-9cfa-bc12974892cd@linux-m68k.org> (raw)
In-Reply-To: <20200529190218.36560-1-luc.vanoostenryck@gmail.com>
Hi Luc,
On 30/5/20 5:02 am, Luc Van Oostenryck wrote:
> I received a bug report for an unrelated patch when used with m68k-nommu.
> It appears that the origin of the problem is that __get_user() and
> __put_user() doesn't handle correctly __user. These 2 patches fix this.
>
> Note: this is only minimaly tested but is quite straightforward and
> since this only change __user annotation it will not change the
> generated code.
>
>
> Changes since v1:
> * fix typo: s/plan/plain/
> * appease checkpatch with better style: s/__force*/__force */
> * avoid excessive line length caused by the added cast.
>
> Luc Van Oostenryck (2):
> m68k,nommu: add missing __user in uaccess' __ptr() macro
> m68k,nommu: fix implicit cast from __user in __{get,put}_user_asm()
>
> arch/m68k/include/asm/uaccess_no.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Looks good, thanks for the fixup.
Applied to the m68knommu git tree, for-next branch.
Regards
Greg
prev parent reply other threads:[~2020-05-30 1:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 19:02 Luc Van Oostenryck
2020-05-29 19:02 ` [PATCH v2 1/2] m68k,nommu: add missing __user in uaccess' __ptr() macro Luc Van Oostenryck
2020-05-29 19:02 ` [PATCH v2 2/2] m68k,nommu: fix implicit cast from __user in __{get,put}_user_asm() Luc Van Oostenryck
2020-05-30 0:59 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb352763-1ed1-2072-9cfa-bc12974892cd@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®