From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3484527AC59 for ; Fri, 26 Sep 2025 13:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758891905; cv=none; b=ZQVYPquYbD+sL/jcNr+UyXO6MyY/da6HDHtpSj7Q8Ew21vMVISPlJLeGz0VMQqW24/jga9hjSUMB4/Cai6+J+phx99xwwcYUjA/ikTmY24/dGkeaU20cyA8kt4PTPAwUUVw2IlcLrdShMb/NJnXwWmkmzbSiT+K/ShFQjs76KoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758891905; c=relaxed/simple; bh=VxHs8m4PREdPitoF17pWmYpBT9auMCjgZ8M+ihTHRgs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DdGQl1TmMgAEJj4KBwttso3bcJhuMQlmjQyK5KjY9YJXF7IDn+ArjyT2SoXbpEoPouNWVCF6lMm/GTjHyOwkVSPWe1O5PJG9JLUsSrCVRaBaMx3bia7V4s8RxR4YPywkFTwgafh6+8F6CQEGAhAOZCfDoG3MngNJPcVVyThLpRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GGxYuAsu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GGxYuAsu" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58Q8vZlE018159 for ; Fri, 26 Sep 2025 13:05:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AznJVNy7DDz5C/A3q06szbLnoJ6bboXOtsVavRtwoBI=; b=GGxYuAsulqkY1+qH jbItnFLtNE8uYsIsVZgJZ199/MwtQZIgtJsI6muuLw2GGm+/O5LpK7ZrtZVKpdXw 0yTwl/YPUVAE282trvG4yrESyGFLD9vopvbgXmMCtV4P8aH1au9PBR0W0U7lfiJ6 2k7zcExyyb6BC351nZ3zaOhOa7PkgObmQrBj7IdTV4vTQKIU3rUWmAsBGeVqDfn3 YVPdP5gDw9Cgm17vGiVizRjz9hPKCE4W7GDlhWRZ6gHh7QsHUewjBQeEu+AFaEC7 6bOK0faWmrMfx2gYSQiWNIQhnTRnELSNYru0UDMqOoRK8Qr4GpFSvl+KUP/kQyfO fblRfQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49db0tawuu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 26 Sep 2025 13:05:01 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-861e9103fffso19752685a.2 for ; Fri, 26 Sep 2025 06:05:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758891901; x=1759496701; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AznJVNy7DDz5C/A3q06szbLnoJ6bboXOtsVavRtwoBI=; b=QBkd4sFyv2I0Bv5/du1PecS4I8YLYSsfoUCnO56GKSVuKyd5Pw59Ho7bWrGG2URbEi 44U+RiTTVvTpmxv3j25U741Y3amX4+NYX0zOrqtRqPpPxnw7cfCInmB9CTc9j2EEqsuT rBo7ohH/0NAwAXnqdVBiP7IK3aSn15NwqzeDrGEWTDCt4A6jT8U8anPKeABqLW7x1fG9 hF5u/Sk+4VC2WOW4oISXHQuB0Ug3mCHC840KDCvVS23Iml82QcbTbT6HeGDvJCXZFENT HxTmyawr6vtTbBq1DF4QWKgRhOgyihUC+CjMZHKwfjJTUJTgYClhFTPF4hC0j8TK42Mb jfEA== X-Forwarded-Encrypted: i=1; AJvYcCXHDEvjsWwVxCeRa/HJ+e+R+mDDJ0fHhzfPRgXWo7gy7e5KuwFQtr6YT/4OAmdZpQ8tWttJeP4BDPQK+xU=@vger.kernel.org X-Gm-Message-State: AOJu0YzmJbOBTVOInO/0/vLn0Hc/4BFKd6ieRJP0TX8QL0s/M3fqxo7T 7bosT9LBoCB/t8r8/ZahGfY4miKjt8ax91m10dOO7ztuGdurwQeTjqmV5YsvefOsgLMbVGaKfXn jHBpLF5ByAYft0fEQJNAGy/uuRWHaLbvU6gwy/nv1L8jBXj718E7DPEqWBcbir3/r02M= X-Gm-Gg: ASbGnctaRpZdVlXKXJz/ADitZZLaybVpI2vjSrrATUqHz3zO9vCJcHmFeYSxGO0j3Xy 7P5XyIXBVV0UYFAo9+rD6k2FN9MJ35Jr851OEgDP9J4n8kDVYqL7OUMNkigolcwzbEWF7TxVJjo 5kD5oGPTD2mXb20W0cHAsZo4kwcwVKPM0MYDs0y/nBR+KCJcFC7plOyCHY9Ut2gAwRVmyz4azbX 9C3h0FUxMtpywQ/Xi4UIK0GAD3olvFxrEteDpQDdBYnQIz+PwHSuy0ZH5nC8fpcDfeeTsU0TSQC hstFO+8bYeTzaTbws1g/7nm6Q9eLvrnTU5XWZX9DYOGnXU5nT+xz4P0eYhjGQBhDFKVkvafGM7A JcUf7JOA08b90AlQ1a1itCw== X-Received: by 2002:ac8:7a97:0:b0:4dc:cb40:706e with SMTP id d75a77b69052e-4dccb4072b1mr27350821cf.13.1758891900478; Fri, 26 Sep 2025 06:05:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH+TdQEyTb0vZ74pl5udy9ShS/6RYEvgsWyZHIj2DIx77Od7JJwYvFeJeEqxdLHSH3+1mLk9w== X-Received: by 2002:ac8:7a97:0:b0:4dc:cb40:706e with SMTP id d75a77b69052e-4dccb4072b1mr27350301cf.13.1758891899741; Fri, 26 Sep 2025 06:04:59 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b3545a9c327sm358355066b.104.2025.09.26.06.04.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Sep 2025 06:04:59 -0700 (PDT) Message-ID: Date: Fri, 26 Sep 2025 15:04:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/20] arm64: dts: qcom: kaanapali: Add USB support for Kaanapali SoC To: Trilok Soni , "Aiqun(Maria) Yu" , =?UTF-8?Q?Krzysztof_Koz=C5=82owski?= , Jingyi Wang Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, tingwei.zhang@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Ronak Raheja References: <20250924-knp-dts-v1-0-3fdbc4b9e1b1@oss.qualcomm.com> <20250924-knp-dts-v1-6-3fdbc4b9e1b1@oss.qualcomm.com> <53d63dd6-a022-4e80-a317-3218976a7474@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: WE2dUQMMhknEfFw8ySTUUBETR4fHX8vV X-Proofpoint-GUID: WE2dUQMMhknEfFw8ySTUUBETR4fHX8vV X-Authority-Analysis: v=2.4 cv=Jvz8bc4C c=1 sm=1 tr=0 ts=68d68f7d cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=Q9aL7w64nW17sFkSeesA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI1MDE3MSBTYWx0ZWRfXzncJQx774Rlv ubp1n8pi5/mv5LIUt3CctpIAO+8EBiHLb3+vQJWlCFtLXoEtKP0xB+K+h8G2dtVz+NCNupP9dtQ IEMjX9WLQ1zI030arkQO/7dT5DxEqpEJs/P7KyQ5etOc5us+tATGfJdfdmzjezXsapYQBmTFjec 0Jdp5eagnHc4UwdivCZgZabrMJsVxF1FU5KucK2+DUcsrKref8cwJOYG6ttHD1QoWSy20TJ2YTX jS6xL2ZDOcPIx1oTHCAl/Wgr76OEIVqhHhcj/QpqH29Qb7RzPBGpzzBp3FFUi4epx7IHv8b+SBB UmvgSVZvY824v1k++KY4YBcIOd8lUyR28OwZ4tqaSQ+PdydgFBh4xtrt3hkYNUBGi/PBDZrYRbc RK/9UpJ6qv+Zg03vqlIXSELwSvWtuQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-26_04,2025-09-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 priorityscore=1501 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509250171 On 9/25/25 8:26 PM, Trilok Soni wrote: > On 9/25/2025 12:39 AM, Aiqun(Maria) Yu wrote: >> On 9/25/2025 9:50 AM, Krzysztof Kozłowski wrote: >>> On Thu, 25 Sept 2025 at 09:17, Jingyi Wang wrote: >>>> >>>> From: Ronak Raheja >>>> >>>> Add the base USB devicetree definitions for Kaanapali platform. The overall >>>> chipset contains a single DWC3 USB3 controller (rev. 200a), SS QMP PHY >>>> (rev. v8) and M31 eUSB2 PHY. >>>> >>>> Signed-off-by: Ronak Raheja >>>> Signed-off-by: Jingyi Wang >>>> --- >>>> arch/arm64/boot/dts/qcom/kaanapali.dtsi | 155 ++++++++++++++++++++++++++++++++ >>>> 1 file changed, 155 insertions(+) >>>> >>> >>> >>> Second try, without HTML: >>> >>> I really don't understand why you created such huge patchset. Year >>> ago, two years ago, we were discussing it already and explained that's >>> just inflating the patchset without reason. >>> >>> New Soc is one logical change. Maybe two. Not 18! >> >> It was previously squashed into the base soc dtsi patch and mark like: >> Written with help from Jyothi Kumar Seerapu(added bus), Ronak Raheja >> (added USB), Manish Pandey(added SDHCI), Gaurav Kashyap(added crypto), >> Manaf Meethalavalappu Pallikunhi(added tsens), Qiang Yu(added PCIE) and >> Jinlong Mao(added coresight). >> >> While it is over 4000+ lines when we squash it together. >> Also as offline reviewed with Bjorn, he suggested us to split out the >> USB and other parts. >> >>> >>> Not one patch per node or feature. >>> >>> This hides big picture, makes difficult to review everything, >>> difficult to test. Your patch count for LWN stats doesn't matter to >>> us. > > Maria - the point here is to not design the series / code for stats, but > per maintainer expectations. Though it is difficult to know one preferred guideline. I believe Krzysztof's explicit mention of LWN might have misguided Maria into saying getting good stats there is the goal which of course wouldn't be a good thing for us to solely strive for.. To the best of my knowledge the actual secondary reason (beyond of course trying to make the series more manageable which I think turned out mostly successful and I largely agree with Bjorn's other response to this msg) is to let authors of larger chunks be credited for their work individually through commit authorship - which I don't think is "gaming" the stats if the chunks are reasonably sized and the work is nontrivial (just like any other post-introduction patches would be treated). If I wrote let's say 35% of the DT and it would be squashed into a single "add Kaanapali" patch under someone else's name, I would have had rather mixed feelings as well.. Konrad