From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBouciXnH8DI7Ne6WvbEoLMUUF7y6dL/klQff1Q9aSIfBtGN7aYrcO4EYo6EMqnfuoNFq+sKY ARC-Seal: i=1; a=rsa-sha256; t=1516321730; cv=none; d=google.com; s=arc-20160816; b=W+KfqxyJTo6XzXFpyzrsCQZ/FSssW54kVw6joKgFz7MpaHF4D4nLBZr1RGEVyVp6PV /dR1o3NdG/t57ty2sKg9kkUYQHfW+VPQhZu846ZYyhNh2TgZdygLCQpw9JRGD54vdPNi D6LLiYDulMkg9lb+MkgfW+XLQoaAi4p0SdlozKTqTJdMN+uD617nXgs9w0GVypksfVPZ uttXbyWKVHxGjKEsm6QDFqvXQLE6vIRjafWrscobnF67vqgPJ8ECd/71xffwjMBXdDTA b9CUBd85UU4w4hALljmUGyfZ3ILojbzRpGLBknNL89yaMBLnTbnDoi2oN5ETUbSU10w2 5Rkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:reply-to :arc-authentication-results; bh=o/iJAd0VKRlQhSGrFxOXRMxzYVGCFZk/XkPmbWN9ulQ=; b=eI+ZPgGA8dPNpZb7IZnddnzFU6jNs8RWGk0qnvzvqqA/xovWffuqUe5l+w3/kgRaej +KcjzXJTmFyOnh0lQnDRIfMkOOSMgeWmGlqFift2auS3wK80cyO2Celhd4fxzXSnSslj mDNzFW7SxvNd+HFZaEQoEMbVvgRKdFyF5knqsuTfkMSxsCJ+TOcTW8WEldKqjneGscsn xdiuNbI9GtAJSNDEo8U9bWkUkR5TjrX5BfIgyuCdYn5AS8HgpBCA92KjFXVFm8w3T3NP Q03HuQW45jXAyVXInNCchp3I8AAOYkpnqziH3ZINl4NfAs92jdt039YKT6DjyTmXNKf/ bIyg== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 64.68.200.34 is neither permitted nor denied by best guess record for domain of shuah@kernel.org) smtp.mailfrom=shuah@kernel.org Authentication-Results: mx.google.com; spf=neutral (google.com: 64.68.200.34 is neither permitted nor denied by best guess record for domain of shuah@kernel.org) smtp.mailfrom=shuah@kernel.org Reply-To: shuah@kernel.org Subject: Re: [PATCH] selftests/x86: Add {,_32,_64} targets To: Andy Lutomirski , Dmitry Safonov Cc: LKML , Ingo Molnar , Greg Kroah-Hartman , Thomas Gleixner , "open list:KERNEL SELFTEST FRAMEWORK" , X86 ML , Shuah Khan , Shuah Khan References: <20180118221943.23558-1-dima@arista.com> From: Shuah Khan Message-ID: Date: Thu, 18 Jan 2018 17:28:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589970455221827423?= X-GMAIL-MSGID: =?utf-8?q?1589978575204028916?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 01/18/2018 04:10 PM, Andy Lutomirski wrote: > On Thu, Jan 18, 2018 at 2:19 PM, Dmitry Safonov wrote: >> One can only use `make all` or `make _` >> as make targets. >> `make ` doesn't work as Ingo noticed: >> x86> make test_vsyscall >> gcc -O2 -g -std=gnu99 -pthread -Wall -no-pie test_vsyscall.c -o test_vsyscall >> /tmp/aBaoo3nb.o: In function `init_vdso': >> test_vsyscall.c:68: undefined reference to `dlopen' >> test_vsyscall.c:76: undefined reference to `dlsym' >> test_vsyscall.c:80: undefined reference to `dlsym' >> test_vsyscall.c:84: undefined reference to `dlsym' >> test_vsyscall.c:88: undefined reference to `dlsym' >> test_vsyscall.c:70: undefined reference to `dlopen' >> collect2: error: ld returned 1 exit status >> : recipe for target 'test_vsyscall' failed >> make: *** [test_vsyscall] Error 1 >> >> Makefile target substitution neither works :-/ >> >> Generate .PHONY targets per-test and fix target substitution. > > Reviewed-by: Andy Lutomirski > > Thanks for taking care of this. I plan to get this into 4.16-rc1 unless there is a dependency on x86 tree. thanks, -- Shuah