From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F44C433F5 for ; Wed, 9 Feb 2022 23:34:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230328AbiBIXeX (ORCPT ); Wed, 9 Feb 2022 18:34:23 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:41306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230102AbiBIXeV (ORCPT ); Wed, 9 Feb 2022 18:34:21 -0500 Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 648A9E0513A3 for ; Wed, 9 Feb 2022 15:34:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1644449657; x=1675985657; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wZrslbFYkv3CyGGamhytlpz6Yr8LDwi9Rm0AXijDQb4=; b=ICkRgmbDE8eie9qaE9JMbLwluzvvRtmqK7fNc3kYeYFh8WlQjIaMs3rZ sqfe9o6xjxxRPVuQDiSb1prC7q/fpfYe0v0s1YZBZlwje2K0aXGQSmaaN eAfhGV/L9BWrXANBmU18NqvUCYacInQEOucAepp6pnCwHQlQzDGwsFIrv 45oXresT2dwfX08Hyex7uNyouEC8xj8NoA4ARS5AUVztOw3McF4OQfgFR 2c2qAfe1Dr7pW2PXshqXTRJFANWloe//SorvKg4NNljiCak82HvfKUKCk TyhKm6/WsJgZlY+gBZ0Vn2j9O46Oc7G3f+dDrP7EsInqAMuJ7JN1kim3f A==; X-IronPort-AV: E=Sophos;i="5.88,357,1635177600"; d="scan'208";a="193527946" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 10 Feb 2022 07:34:16 +0800 IronPort-SDR: kbYSCy04nexhCG0+HcuXJsfEXSiXISohhrPsGwFQIepwReuhrRdhByjsCEScv19VY14BMS2ozS nskMWmnDguJaIApIfPYmsjM8sOXoVXPFHbWylfcSgpukBwCLzsZfNzInngtMD9qJoS4bbZ4F0R S7LfIpWKQm+wrBCIUUA7coSIsSQJAug+xoLKJOxmNto019O6Ryp4VkNfF3dfmBXsTLY0f0KA1F Gz7kGwZZoPD/Tec9Q4zvdeG6N8rTAcKmXKMvbtV8xE8E+wWIOXyi/OWBlyEzFZUCarEhQ2jnV1 e9V4oBOIJQ4tU4USTPcbvnf/ Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 15:06:03 -0800 IronPort-SDR: GUFMuxE4YxqZStea8Gd7cRTZe1v/F41997KIXs9DBGtuFT3yVR88HEiJwsffoY/A0IWCdYT3Rb PBYE7+yKKiMdsOWbDcpBS8gpApm/voKoRZI/8O7WflN0IKBlMrg3h8rT8oMyE0tA7BVd153xyv lTIZyzQalyzUNP2zJGjB5ckWN+lAKCSYLFBFnYsDVIEQf3F8No3IBonodLmOMqu8OZsieRvTPj 9601gsse+ISLsNMGWys6f+373TxFbuiUbtW2hajO5ARBAMi/m50F66rGn+j0ECwvBqn9YsOjkI ZmE= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 15:34:16 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4JvGRq0jK7z1SVp0 for ; Wed, 9 Feb 2022 15:34:15 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1644449654; x=1647041655; bh=wZrslbFYkv3CyGGamhytlpz6Yr8LDwi9Rm0 AXijDQb4=; b=rY4QPwrmYLoClTrUYzD8WuYDziIlCcL6Qzh5ga47J96D7bW4E/E uHo++jFo6pqRH0sTzoWjUfUUk/ow5pJHZOyWwMVXULqMuxcfICk8Yo89YSe7D+iB +ontFRWvUlgQq4THEU13EmoaCgwdmu1YHTMk1HyPnx/gKekkiBX9effBrmJ5YUCi c5uvREH2oErUrFBawLLvCuKimGJC4FbWfO/ZR4PPw97caXSoPU7UpKLGv+HYcd3a NJ1/hDNXM8+c5QlbbK/Es1DOzdVJi+hl5FLjwBxNZcpCEMynr/L/aecvCVN1+ICy PIBYtp9ikIPo/w8nmKt1QNXdRAwxBRI2ZPg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WJA2CkFVA3DL for ; Wed, 9 Feb 2022 15:34:14 -0800 (PST) Received: from [10.225.163.67] (unknown [10.225.163.67]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4JvGRn5J7Bz1Rwrw; Wed, 9 Feb 2022 15:34:13 -0800 (PST) Message-ID: Date: Thu, 10 Feb 2022 08:34:12 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] pinctrl: k210: Fix bias-pull-up Content-Language: en-US To: Sean Anderson , Linus Walleij , linux-gpio@vger.kernel.org Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Dan Carpenter References: <20220209182822.640905-1-seanga2@gmail.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220209182822.640905-1-seanga2@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/10/22 03:28, Sean Anderson wrote: > Using bias-pull-up would actually cause the pin to have its pull-down > enabled. Fix this. > > Signed-off-by: Sean Anderson > --- > > drivers/pinctrl/pinctrl-k210.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c > index 49e32684dbb2..1ad61b32ec88 100644 > --- a/drivers/pinctrl/pinctrl-k210.c > +++ b/drivers/pinctrl/pinctrl-k210.c > @@ -527,7 +527,7 @@ static int k210_pinconf_set_param(struct pinctrl_dev *pctldev, > case PIN_CONFIG_BIAS_PULL_UP: > if (!arg) > return -EINVAL; > - val |= K210_PC_PD; > + val |= K210_PC_PU; > break; > case PIN_CONFIG_DRIVE_STRENGTH: > arg *= 1000; Ooops... My bad :) Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research