From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Bill Wendling <morbo@google.com>,
Simon Trimmer <simont@opensource.cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org,
codemender-patching+linux@google.com
Subject: Re: [PATCH] firmware: cs_dsp: Annotate struct cs_dsp_coeff_ctl with __counted_by_ptr
Date: Mon, 28 Sep 2026 09:50:54 +0100 [thread overview]
Message-ID: <fb409745-856d-44c6-b9a9-387bb7499811@opensource.cirrus.com> (raw)
In-Reply-To: <20260928044513.1330392-1-morbo@google.com>
On 28/09/2026 5:45 am, Bill Wendling wrote:
> Annotate the 'cache' pointer member of 'struct cs_dsp_coeff_ctl' with
> the '__counted_by_ptr' attribute. This allows the compiler and KASAN
> to perform run-time bounds checking on accesses to the 'cache' buffer,
> preventing potential out-of-bounds reads or writes.
>
> The 'cache' pointer points to a buffer of size 'len' bytes, allocated
> to hold the cached value of a DSP coefficient control. The 'cache' and
> 'len' are initialized in 'cs_dsp_create_control()'.
>
> Every subsequent access to 'ctl->cache' is strictly validated to
Is that true?
When I last looked at these __counted_by they were only checked by
a subset of library functions (which was documented) so I was still
able to write code that overran the buffer.
However, recent compilers might do more checking now.
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
next prev parent reply other threads:[~2026-09-28 8:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 4:45 Bill Wendling
2026-09-28 8:50 ` Richard Fitzgerald [this message]
2026-09-28 18:57 ` Bill Wendling
2026-09-28 12:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb409745-856d-44c6-b9a9-387bb7499811@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=codemender-patching+linux@google.com \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morbo@google.com \
--cc=patches@opensource.cirrus.com \
--cc=simont@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®