From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E612A3C198D for ; Wed, 9 Sep 2026 23:02:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788994979; cv=none; b=SK6BAGucoLII1oObvGCrPoq3v81B9/B7OlSloj5uQHTKExe/+HhLs9J6Y6WY12dKX7C4p5geG3Zk3c+N6ix61HQbObme5vSHvTTsnHDbnE2B/o+irF4LkN5R+3tXVmRV1zizOsfgNmetKTc2NYCczIu8GSyTAkweYK+yx05y1y8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788994979; c=relaxed/simple; bh=1j7l0Y1ODaK0ozctul3/9zDe7XSdhaAbWCE6M5p2n44=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=aq37hvq1gaxl5FR4h9r+smxTcUbmG/4R0HgWU5khOlLLe3hIiwTUoRfq/1OOwYG8EDzjTc4P+mgprXMlPovmKFbizByTEOgf/LDr3ivLfs8Pud+z73wq4Z3zQt1aJBOJLsrJtX4DEK7qtLZZjfvfzmus3BmLgxsc5EiZqSFsS3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QIH6HTvF; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QIH6HTvF" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2dcff8f44f2so16700515ad.1 for ; Wed, 09 Sep 2026 16:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788994974; x=1789599774; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:sender:from:to:cc:subject:date :message-id:reply-to:content-type; bh=784UGVAwRi/KDZ/caVwu4a+8R3qNa4Fis8BmntQvL/8=; b=QIH6HTvFYiMoljAFJM37PXU2qG6lLXHOQLEcKObGsdiiI5sDa1nT7pdO2Kidu7MHl5 Tqm5JRir8S5Dgnnyi3byyJPB6/4eW6PZQqDcduktWDZ6zMLkmcEYjDIIKHEN963P1eEk JcOaoLQHuHmvoG4nkuMv6UH6xqdaNe5jjNgdAV7RDd9ilatmDs2ZRSj8V4bpQTA7mUii x4Luo3gf84GhXFQvEBfTGnyQla++KL8Wc66ki7I0gsG4HdILsv6rBFl/QusRUzJiuPOG a+nctBKtFOIb0BCRiBETf6BP7P6vIPgVkHC1fIkWroTuCEqA2d1jp5uYQloOH5U2pBub KhdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788994974; x=1789599774; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:sender:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=784UGVAwRi/KDZ/caVwu4a+8R3qNa4Fis8BmntQvL/8=; b=CoSsrwr9J6Y25zUIhlI7RmqjGf5W/N5aTQH77/nkCf6Jgg50lrmf4PX3ZO8qk0dbnX zD0/lxmDhwCIaPAONs1D++2YcQvLochmFXGS1bTeKqhFbblrOLR9orfJsI+L0iNtRnST tSYiGGIG7z5nysFnsmzLJUbNwYCMjAZVqfl8kIQ88L2l6EnWB+qgRTRYSS3XzvgX3x08 jZCRKLl/gOOg0Cm1+axDqE5fotC2pzqg9YEHXlK9lnqgTCbbtFBXW0aoncJO9+s++War tGEY46CFXgQ+vmvMFbVkhvlCzDP7TJmbLIM/FaSUrgMy0j3mErAgbUWbmIhxImsrXPEK X8sQ== X-Forwarded-Encrypted: i=1; AKwUvBzEosD1JWpIGAFkK6+PNqLorrmM1YG3ggpexbOTi1UV20tgonkSobEJGH68fTGn093gWqQNzhllp6vZiAY=@vger.kernel.org X-Gm-Message-State: AFuF++ngS7Hd0Ym17x/CgR0XMn69Mfs33QWgS6gxKTYTMOSsuCCt4Aij 8FfKDvOK6dxi2uMb9ZZP0bf36lKXdAbd01lyeXwWzumNxhjsH+kCKYQJ X-Gm-Gg: AYBFou240ZXC1UU/HEv9vHg7xlSOTbQQFB6oq9UjattStmUEBnwmtVgmm+RFVwN+geM tVDYjepzxNe/6fL/YY5LX56p01iKuHe+ztHgMHXGdvhk8Ne/f2lw4nAkzfXO8p0JAXMnoOLSGDe YNQ4736iSwPcO9fdfb7aXEpmYhTFUKUwVtycS/XFFIS2RCLCodW7hlFc+LIalKJ5Oy7l44kTAxe BpFTBz1LMbAN/+65vRUfWwLK1Zz1vXiqTjF+32Sb+JwONIWck/9dvyDQCXUkbZYi5XlmsnBioK6 HMqV1O3Iuan1RMgTI/ZuWZDbaQH50ma5nUAStu4VN7DnVKP63KjDHrJ4jSevewM5DWgHjrLwZSf 0W4I3lIQ8LFNMn+lBAcvqGZ18ZvGBlgdhGqj8tkWiC4r4Lwpeb3Ecn1esoq/6QwXeFS/BH1IKKY HMW4U76hTSYTFLJtGfcLh2PIRVHt8faZAVP2A5e5Hxa5Mz9rfq3qGvugG8J5qjcUVEVZ0jmEB7Y FJEkXzNQ1EjpU/55Cs8ogkcXl6GWK0t/TJPmk9OfLE3gm7c+iEoi3Vbtuw= X-Received: by 2002:a17:90a:dfcd:b0:396:4cbf:45a2 with SMTP id 98e67ed59e1d1-39b84cce5a8mr26071124a91.14.1788994973628; Wed, 09 Sep 2026 16:02:53 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e3f603dsm393786a91.2.2026.09.09.16.02.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2026 16:02:53 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Wed, 9 Sep 2026 16:02:51 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/9] watchdog: msc313e: Fix spurious reset on suspend From: Guenter Roeck To: Tzung-Bi Shih Cc: Wim Van Sebroeck , Daniel Palmer , Romain Perier , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260828161348.13212-1-tzungbi@kernel.org> <20260828161348.13212-6-tzungbi@kernel.org> Content-Language: en-US Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/9/26 14:16, Guenter Roeck wrote: > On Sat, Aug 29, 2026 at 12:13:44AM +0800, Tzung-Bi Shih wrote: >> If the hardware watchdog was started by the bootloader and the device is >> suspended before userspace opens it, the ping worker (from watchdog >> core) is frozen and the active hardware timer continues running. This >> leads to a spurious system reset. >> >> Check both watchdog_active() and watchdog_hw_running() when deciding >> whether to start or stop the watchdog during suspend and resume. >> >> Additionally, call watchdog_stop_ping_on_suspend() to ensure the ping >> worker be correctly paused and restarted during suspend and resume. >> >> Fixes: ffd264bd152c ("watchdog: msc313e: Check if the WDT was running at boot") >> Signed-off-by: Tzung-Bi Shih > > Applied. > > Sashiko has a point about the bug in the watchdog core, though. We'll have > to fix that at some point. > Never mind, that fix is already queued. Thanks, Guenter