From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32038C10F04 for ; Tue, 5 Dec 2023 12:12:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442398AbjLEL4E (ORCPT ); Tue, 5 Dec 2023 06:56:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442195AbjLELzm (ORCPT ); Tue, 5 Dec 2023 06:55:42 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91D0198; Tue, 5 Dec 2023 03:55:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701777349; x=1733313349; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=e3cGY29NO2TW5wcDKR/uxU5ISJOcURe7TpDGtZtP95Q=; b=MDAr5BS1LPykCRcsIlmHFRzoII+yWmkZXlJBlSM6cY2+hnTpZ/gTsKL/ HXZlsNaUnrreZOW3BIGqJlm9CN0zo4xDbkmauIidS9+NWiOfKp25UVYxw lcs/SVl/pGKONKUWqmL2KuMSsZ2GLbzgp1n/ueWONHaw0H/WiPjKQU3He 3sB/2lGX08vaZlwW/EgcpBNmRFPzhl30sUVo5BsGi3ko111uBL3F7eOEn OkppWhKUp3cM8Y/3NNUJdIsvWZXaZjcyynIx0uSSRJEqkM7WJ5FPcxT69 4k1qmI4JPPFjedWAmuJrdMsqpreoG5Ovs4304Jx7E98BuxLybAXjNq7B7 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="7180384" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="7180384" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 03:55:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="861717965" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="861717965" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.255.31.68]) ([10.255.31.68]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 03:55:42 -0800 Message-ID: Date: Tue, 5 Dec 2023 19:55:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: baolu.lu@linux.intel.com, Jacob Pan , Yan Zhao , iommu@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v7 03/12] iommu: Remove unrecoverable fault data Content-Language: en-US To: Yi Liu , Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Kevin Tian , Jean-Philippe Brucker , Nicolin Chen References: <20231115030226.16700-1-baolu.lu@linux.intel.com> <20231115030226.16700-4-baolu.lu@linux.intel.com> <50b9684c-e018-4e1c-9aac-67e0ffd9bc27@intel.com> From: Baolu Lu In-Reply-To: <50b9684c-e018-4e1c-9aac-67e0ffd9bc27@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/12/4 18:58, Yi Liu wrote: > On 2023/11/15 11:02, Lu Baolu wrote: >> The unrecoverable fault data is not used anywhere. Remove it to avoid >> dead code. >> >> Suggested-by: Kevin Tian >> Signed-off-by: Lu Baolu >> Reviewed-by: Jason Gunthorpe >> Reviewed-by: Kevin Tian >> --- >>   include/linux/iommu.h | 70 +------------------------------------------ >>   1 file changed, 1 insertion(+), 69 deletions(-) >> >> diff --git a/include/linux/iommu.h b/include/linux/iommu.h >> index c2e2225184cf..81eee1afec72 100644 >> --- a/include/linux/iommu.h >> +++ b/include/linux/iommu.h >> @@ -50,69 +50,9 @@ struct iommu_dma_cookie; >>   /* Generic fault types, can be expanded IRQ remapping fault */ >>   enum iommu_fault_type { >> -    IOMMU_FAULT_DMA_UNRECOV = 1,    /* unrecoverable fault */ >>       IOMMU_FAULT_PAGE_REQ,        /* page request fault */ > > a nit, do you kno why this enum was starting from 1? Should it still > start from 1 after deleting UNRECOV? As Jason suggested in another thread, we will address this issue in another thread. I am not sure for now whether we will remove the fault type field or re-use the previous scheme. Best regards, baolu