mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Rosen Penev <rosenp@gmail.com>, devicetree@vger.kernel.org
Cc: "Hauke Mehrtens" <hauke@hauke-m.de>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"moderated list:BROADCOM BCM5301X ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] ARM: dts: BCM5301X: EA9200: add wifi definitions
Date: Fri, 20 Mar 2026 14:34:44 -0700	[thread overview]
Message-ID: <fb4c139a-1abb-410c-950d-97b1ed44c9ff@broadcom.com> (raw)
In-Reply-To: <b3212a44-2783-4c37-95d4-56e0b486c73c@broadcom.com>

On 3/20/26 10:29, Florian Fainelli wrote:
> On 3/19/26 17:29, Rosen Penev wrote:
>> On Wed, Mar 18, 2026 at 8:53 PM Rosen Penev <rosenp@gmail.com> wrote:
>>>
>>> brcm,ccode-map and ieee80211-freq-limit are needed to be specified on
>>> some of them for proper operation.
>>>
>>> Signed-off-by: Rosen Penev <rosenp@gmail.com>
>>> ---
>>>   .../dts/broadcom/bcm4709-linksys-ea9200.dts   | 50 +++++++++++++++++++
>>>   1 file changed, 50 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dts b/ 
>>> arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dts
>>> index 617fb55bc52f..7b1363aa1144 100644
>>> --- a/arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dts
>>> +++ b/arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dts
>>> @@ -93,6 +93,56 @@ led-3 {
>>>          };
>>>   };
>>>
>>> +&pcie_bridge0 {
>>> +       pcie@0,0 {
>>> +               device_type = "pci';
>>> +               reg = <0x0000 0 0 0 0>;
>>> +               bus-range = <0x01 0xff>;
>>> +
>>> +               #address-cells = <3>;
>>> +               #size-cells = <2>;
>>> +               ranges;
>>> +
>>> +               pcie@1,0 {
>>> +                       device_type = "pci';
>> There are typos here. "pci' vs "pci". Should I resend?
> 
> Not necessary, fixed it up while applying, thanks!

Meh, this was not even build tested, even fixing that gives me:

  ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- make CHECK_DTBS=y 
broadcom/bcm4709-linksys-ea9200.dtb
   DTC [C] arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dtb
Lexical error: 
arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dts:107.19-22 
Unexpected 'pci'
Error: arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dts:107.19-22 
syntax error
FATAL ERROR: Unable to parse input tree

Please resubmit patches 4 and 6 since I dropped them as a result.
-- 
Florian

  reply	other threads:[~2026-03-20 21:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19  3:53 [PATCH 0/6] ARM: dts: BCM5301X: EA9200: various fixes Rosen Penev
2026-03-19  3:53 ` [PATCH 1/6] ARM: dts: BCM5301X: EA9200: add WiFi button Rosen Penev
2026-03-20 17:25   ` Florian Fainelli
2026-03-19  3:53 ` [PATCH 2/6] ARM: dts: BCM5301X: EA9200: add USB GPIOs Rosen Penev
2026-03-20 17:26   ` Florian Fainelli
2026-03-19  3:53 ` [PATCH 3/6] ARM: dts: BCM5301X: EA9200: add LEDs Rosen Penev
2026-03-20 17:26   ` Florian Fainelli
2026-03-19  3:53 ` [PATCH 4/6] ARM: dts: BCM5301X: EA9200: add wifi definitions Rosen Penev
2026-03-20  0:29   ` Rosen Penev
2026-03-20 17:29     ` Florian Fainelli
2026-03-20 21:34       ` Florian Fainelli [this message]
2026-03-20 23:06         ` Rosen Penev
2026-03-20 17:26   ` Florian Fainelli
2026-03-19  3:53 ` [PATCH 5/6] ARM: dts: BCM5301X: EA9200: specify partitions Rosen Penev
2026-03-20 17:26   ` Florian Fainelli
2026-03-19  3:53 ` [PATCH 6/6] ARM: dts: BCM5301X: EA9200: set MAC from nvram Rosen Penev
2026-03-20 17:26   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb4c139a-1abb-410c-950d-97b1ed44c9ff@broadcom.com \
    --to=florian.fainelli@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hauke@hauke-m.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rosenp@gmail.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®