From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5A051E4AB for ; Sun, 17 Aug 2025 08:07:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755418029; cv=none; b=EGh9gzML2owZdto8ZaEl6Z9Z8oez1EvR2CXnxBucySBb9XDeAnB7zbbNPFC122y7SD57X5LrQGQE3/bk3ajTucAUEczwy57N2OQbz/TMEz6bJqx54Z1nfhQOekAVZ+btxXoOD4fYYKZQQejsI8Zl9zLDIVd1TrhaG5YAvgs8MEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755418029; c=relaxed/simple; bh=b34IIFoIzX6q6W9maIi9XbuBc6ZoYqWIty3/Gl6Aa1o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GftlyFsvTGiqB6WY49W4fApfdagGZtPKfCX6KhSVAiZLbxfoulg//KKd/+GGu3Pv9GqpVxb7qe7K8M+kppCIbxY1JmBGkRXU4DVneDMi7VCW430rqinPstjOsK/Jmq+RDlWm6lrANVBhC1T6L48VQarX5E+fF4W2UJs1/IaNsqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hWLb/CQG; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hWLb/CQG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755418026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oXCR6jx4ey42aR655U9PtXbjqfLl2uQopYEZjH9HCRE=; b=hWLb/CQGIkrwEU5tk5zHjoDHW4IRAQ7DiFbof+cDPlHzAs8vu27XI5rzL6fSAo1S88jVSM bgDxx0do+depZf0n6bPERMkMTUkcSSjcZThTXnTO3tbsiNZ68tjSaoVFamouQXYsM7jsw3 wSYpqY1e78w0RncFALEkamyePmgTEO4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-281-nmp8ioG3OX-ItphGTJkG5w-1; Sun, 17 Aug 2025 04:07:05 -0400 X-MC-Unique: nmp8ioG3OX-ItphGTJkG5w-1 X-Mimecast-MFC-AGG-ID: nmp8ioG3OX-ItphGTJkG5w_1755418024 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45a1b0cb0aaso18187815e9.3 for ; Sun, 17 Aug 2025 01:07:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755418024; x=1756022824; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oXCR6jx4ey42aR655U9PtXbjqfLl2uQopYEZjH9HCRE=; b=Aby5GhVcCF8LVzbFJCHbTBRdXUgRXcI6PasE65ISVror+NF7OnzPIT1wK+bkpnldK/ oSOjGSxWBpyHZfqaX7QLAh2wWZ+Q+tmDbpUHC4ZJiLrPCR/LlN9iTbHFNeb/i89XWq1b V6/4GyYizzM1xjNSs/mTOQhMFGTi82rEMElFKGiKicb72ASMksXN1ud338CoaCREBuUo iiPqfnkTjzOePiXdaYoNMBV2485woflPzYjARY6uTLtnjIMZwcVI+SSgkaF6yD27wVCW V0458iTZbNgNFNy6BQLVbROYRG9w2vuJ+cTJTqroeWCg+qpI3ecVsWnoMZJW8c8o+tpA x+yA== X-Forwarded-Encrypted: i=1; AJvYcCVBgC+y2Iw2b9iyeTkjeo3dzFC3YFBR04pis6AqbMbU6Qm1ZDZ7HdD5xM7dK92RYpe8myFpFWLrtplWpL8=@vger.kernel.org X-Gm-Message-State: AOJu0YzwCbo6RWvWh6x/oeGkWL4wpt0Vl0uKP12fsSJ4EMNKUwPAZkzj lx42+eMPATuppDxIiwLilObYr6ux6Pva/HHy6c5f9kQdG4Q4wsvHFMqXENfuBmqgVgoobpUKnCW mYxHmBqyaRZipy6s/U6khQvkvPabKm9W7irXeY4Id1ZH3/kc2TmuFqI25Mtgabek1Hg== X-Gm-Gg: ASbGncsiyYtDcz5wKuaM0LPOCb/Xin2serYuwkMRkb69xk7DBfDT1g00WI8FV1qBPz3 JlqJxRu66VjZJINfAMJ4UqPE6uQcAecBA8Mt6OLaB9NFZxBN+TyQrjZHw+GwKrmAAK9d/MgnPTP T2SrJpO2JMV3kahHl1dVVWCXV7ZV1LHbDg9Ttg7b3Hbrz9+GkgVBCX36OtjqNBovVeqi5o42/bU mHZFHJZtyc4cFFmrpzXlCj6feMELoctjtxUfylx2GvmWynCuajaYMAgC0VzHZp+UY8FZMU3RInN JR4i69WWEke9GMcYpPVdfUGSCwgd7wIZeYJfuwZS34xRH+FclsZ9lCKNM6mBM6hkNVo73oD3DDF 6oB3fy1/D3CroCC5eX9rSDBuC3DaCklNCAQxhs8Wxh7otQIxgcLUEu6thjJ9/8RmfXlY= X-Received: by 2002:a05:600c:4f89:b0:455:fc16:9eb3 with SMTP id 5b1f17b1804b1-45a2679b098mr31050505e9.33.1755418023900; Sun, 17 Aug 2025 01:07:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELs9JlOUQoCDAv7GOq3qlfRmrWqshCbe5IY8nTGKMjFukcAnSW5YEjUHnLDr5jRqTIMYyWXA== X-Received: by 2002:a05:600c:4f89:b0:455:fc16:9eb3 with SMTP id 5b1f17b1804b1-45a2679b098mr31050285e9.33.1755418023465; Sun, 17 Aug 2025 01:07:03 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0b:a400:87b2:80d2:3e99:1b85? (p200300d82f0ba40087b280d23e991b85.dip0.t-ipconnect.de. [2003:d8:2f0b:a400:87b2:80d2:3e99:1b85]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1c78b410sm127199905e9.24.2025.08.17.01.07.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Aug 2025 01:07:02 -0700 (PDT) Message-ID: Date: Sun, 17 Aug 2025 10:07:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/7] mm/selftests: Fix split_huge_page_test failure on systems with 64KB page size To: Giant Sand Fans , Wei Yang Cc: Aboorva Devarajan , "akpm@linux-foundation.org" , "Liam.Howlett@oracle.com" , "lorenzo.stoakes@oracle.com" , "shuah@kernel.org" , "pfalcato@suse.de" , "ziy@nvidia.com" , "baolin.wang@linux.alibaba.com" , "npache@redhat.com" , "ryan.roberts@arm.com" , "dev.jain@arm.com" , "baohua@kernel.org" , "linux-mm@kvack.org" , "linux-kselftest@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "donettom@linux.ibm.com" , "ritesh.list@gmail.com" References: <20250816040113.760010-1-aboorvad@linux.ibm.com> <20250816040113.760010-5-aboorvad@linux.ibm.com> <20250816143129.u2rdwpwvfhsdptvx@master> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit > >>diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/ > tools/testing/selftests/mm/split_huge_page_test.c > >>index eadbeb820d71..7cbeaebc9d71 100644 > >>--- a/tools/testing/selftests/mm/split_huge_page_test.c > >>+++ b/tools/testing/selftests/mm/split_huge_page_test.c > >>@@ -523,6 +523,9 @@ int main(int argc, char **argv) > >>       const char *fs_loc; > >>       bool created_tmp; > >>       int offset; > >>+      unsigned int max_order; > >>+      unsigned int nr_pages; > >>+      unsigned int tests; > >> > >>       ksft_print_header(); > >> > >>@@ -534,35 +537,38 @@ int main(int argc, char **argv) > >>       if (argc > 1) > >>               optional_xfs_path = argv[1]; > >> > >>-      ksft_set_plan(1+8+1+9+9+8*4+2); > >>- > >>       pagesize = getpagesize(); > >>       pageshift = ffs(pagesize) - 1; > >>       pmd_pagesize = read_pmd_pagesize(); > >>       if (!pmd_pagesize) > >>               ksft_exit_fail_msg("Reading PMD pagesize failed\n"); > >> > >>+      nr_pages = pmd_pagesize / pagesize; > >>+      max_order =  sz2ord(pmd_pagesize); > >                     ^ > >                     extra space here > > > >>+      tests = 2 + (max_order - 1) + (2 * max_order) + (max_order - > 1) * 4 + 2; > > Is it possible to have some defines here instead plain numbers? > Thanks I assume we should look into using kselftest_harness as a separate effort, so we can avoid this manual test calculation completely. I'm afraid even using defines will not make this significntly more readable. -- Cheers David / dhildenb