From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965769AbcHBRJW (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Aug 2016 13:09:22 -0400
Received: from mail-pa0-f46.google.com ([209.85.220.46]:33502 "EHLO
	mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932825AbcHBRJH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Aug 2016 13:09:07 -0400
Subject: Re: [Regression?] fib_rules: Added NLM_F_EXCL support to
 fib_nl_newrule breaks Android userspace
To: John Stultz <john.stultz@linaro.org>, Lorenzo Colitti <lorenzo@google.com>
References: <CALAqxLUrJ86pJ20ppTycG3e2wv=zegC6UfQdXtnjeQYxQw2iMg@mail.gmail.com>
 <20160728.212031.549387302791502368.davem@davemloft.net>
 <5ff19cc3-e607-282d-853a-410b985f8756@cumulusnetworks.com>
 <CALAqxLWBFyS8VF02tBmAR-Zu1j6Nh7ETZFoWx1fzVgx81rUk1Q@mail.gmail.com>
 <CAKD1Yr06yV+P7_WwaF+CXuzD9xHEHQYereL-1Ax0_8hLDTSMOQ@mail.gmail.com>
 <CALAqxLVpnJef7_-pqj8EJhk2aM3YTCmEFc693kG7tNq5OjS79g@mail.gmail.com>
 <CALAqxLW1Ge5ZeCEBnP=+0cT1wjQUrXozQc0fEwtmmGs6UQ6eEg@mail.gmail.com>
Cc: David Miller <davem@davemloft.net>,
        Mateusz Bajorski <mateusz.bajorski@nokia.com>,
        lkml <linux-kernel@vger.kernel.org>,
        Guodong Xu <guodong.xu@linaro.org>,
        Dmitry Shmidt <dimitrysh@google.com>, Chih-Hung Hsieh <chh@google.com>,
        Eric Caruso <ejcaruso@google.com>
From: David Ahern <dsa@cumulusnetworks.com>
Message-ID: <fb4e3c33-b2d3-00f3-3f2d-dcc4a641d53f@cumulusnetworks.com>
Date: Tue, 2 Aug 2016 11:09:04 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CALAqxLW1Ge5ZeCEBnP=+0cT1wjQUrXozQc0fEwtmmGs6UQ6eEg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/2/16 11:03 AM, John Stultz wrote:
> So bisecting between v4.7 and linus/HEAD with the test above, it seems like:
> 96c63fa7393d ("net: Add l3mdev rule")  is what breaks the tests.
>
> The l3mdev rule patch is a bit tangled with the fib_rules one, but if
> I revert both of those, the only thing that fails is the
> ./neighbour_test.py (which I need to dig further into). But those two
> changes seem to be connected to the regression I'm seeing with
> Android.
That is surprising since the l3mdev rule should not exist on Android 
unless it has created a VRF.

Does Android have custom FRA types in <linux/fib_rules.h>? Perhaps there 
is a collision on attribute number?