From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761832AbcIXKYZ (ORCPT ); Sat, 24 Sep 2016 06:24:25 -0400 Received: from lucky1.263xmail.com ([211.157.147.131]:58211 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbcIXKYV (ORCPT ); Sat, 24 Sep 2016 06:24:21 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED4: 1 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-gpio@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <237c75b367bb34a78b6f7acbe5a48c8e> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] pinctrl: rockchip: don't disable clk when irq mask is already set To: Jacob Chen , linux-kernel@vger.kernel.org References: <1474655197-26919-1-git-send-email-jacob-chen@iotwrt.com> Cc: shawn.lin@rock-chips.com, linux-rockchip@lists.infradead.org, linus.walleij@linaro.org, Jacob Chen , heiko@sntech.de, linux-gpio@vger.kernel.org From: Shawn Lin Message-ID: Date: Sat, 24 Sep 2016 18:24:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1474655197-26919-1-git-send-email-jacob-chen@iotwrt.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/9/24 2:26, Jacob Chen wrote: > From: Jacob Chen > > In some drivers, disable_irq() call don't be symmetric with enable_irq() > , disable_irq() will be called before call free_irq(). Which upstream drivers you refer to? Shouldn't it be the unbalanced call for these drivers? > > But both disable_irq() and free_irq() will call rockchip_irq_gc_mask_set_bit, > and clk_disable() will be called more times than clk_enable(), which will > cause bugs. > > I think we can correct that by checking of mask.If mask is already set, do nothing. > Looks like a little hacky to me. > Change-Id: If19912c7658253e15531c04db6c70fdbffd5960a remove this. > Signed-off-by: Jacob Chen > --- > drivers/pinctrl/pinctrl-rockchip.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c > index c6c04ac..9a8804a 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c > @@ -2334,8 +2334,12 @@ static void rockchip_irq_gc_mask_clr_bit(struct irq_data *d) > void rockchip_irq_gc_mask_set_bit(struct irq_data *d) > { > struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); > + struct irq_chip_type *ct = irq_data_get_chip_type(d); > struct rockchip_pin_bank *bank = gc->private; > > + if (*ct->mask_cache & d->mask) > + return; > + > irq_gc_mask_set_bit(d); > clk_disable(bank->clk); > } > -- > 2.7.4 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > -- Best Regards Shawn Lin