From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: linux-kernel@vger.kernel.org, mingo@kernel.org,
peterz@infradead.org, tj@kernel.org, christian.loehle@arm.com,
arighi@nvidia.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org
Cc: tglx@kernel.org, gregkh@linuxfoundation.org, pbonzini@redhat.com,
seanjc@google.com, vschneid@redhat.com, yury.norov@gmail.com,
huschle@linux.ibm.com, rostedt@goodmis.org,
dietmar.eggemann@arm.com, mgorman@suse.de, bsegall@google.com,
maddy@linux.ibm.com, srikar@linux.ibm.com, hdanton@sina.com,
chleroy@kernel.org, vineeth@bitbyteword.org, frederic@kernel.org,
pauld@redhat.com, tommaso.cucinotta@gmail.com, maz@kernel.org,
rafael@kernel.org, kprateek.nayak@amd.com, iii@linux.ibm.com
Subject: Re: [PATCH v3 00/20] sched: Introduce cpu_preferred_mask and steal-driven vCPU backoff
Date: Wed, 10 Jun 2026 01:21:50 +0530 [thread overview]
Message-ID: <fb564506-1881-4c08-ab63-d823875b818b@linux.ibm.com> (raw)
In-Reply-To: <20260514152204.481115-1-sshegde@linux.ibm.com>
On 5/14/26 8:51 PM, Shrikanth Hegde wrote:
> TODO/OPEN Questions:
>
> - SCHED_EXT is still pending. I tried adding few checks in
> scx_idle_test_and_clear_cpu, pick_idle_cpu_in_node and push the
> sched_ext task in tick. But it hasn't still worked with scx_simple.
> I will try to figure it out. But i may need help since
> I am yet wade deeper waters in sched_ext.
>
In addition to pushing the task out at sched_tick,
Did some hacking around wake up path scx_select_cpu_dfl to make
it aware of cpu_preferred state. That didn't make it work.
then tried to Push the task out in enqueue_task_scx.
That makes it somewhat work, but still has warning with scx_simple.
Given there are many different scx_ flavours, it might make sense add a new one
which is aware of preferred state and can manage it without any change to the
default implementations using custom select_cpu/enqueue/dequeue etc.
So I am thinking sched_ext bit will have to be pursued later as i don't have
much knowledge there still.
Hacked Code that was tried for scx_simple.
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 9a92a479720d..4009ca1ec027 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -11361,7 +11361,8 @@ void sched_push_current_non_preferred_cpu(struct rq *rq)
/* Push only if it is FAIR/RT class */
if (push_task->sched_class != &fair_sched_class &&
- push_task->sched_class != &rt_sched_class)
+ push_task->sched_class != &rt_sched_class &&
+ push_task->sched_class != &ext_sched_class)
return;
if (kthread_is_per_cpu(push_task) ||
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index f5a3233ead1a..a7a87f849e03 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -2043,6 +2043,11 @@ static void enqueue_task_scx(struct rq *rq, struct task_struct *p, int core_enq_
goto out;
}
+ if (!cpu_preferred(rq->cpu)) {
+ sched_push_current_non_preferred_cpu(rq);
+ return;
+ }
+
set_task_runnable(rq, p);
p->scx.flags |= SCX_TASK_QUEUED;
rq->scx.nr_running++;
prev parent reply other threads:[~2026-06-09 19:52 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 15:21 Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 01/20] sched/debug: Remove unused schedstats Shrikanth Hegde
2026-06-04 4:01 ` K Prateek Nayak
2026-05-14 15:21 ` [PATCH v3 02/20] sched/docs: Document cpu_preferred_mask and Preferred CPU concept Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 03/20] kconfig: Provide PREFERRED_CPU option Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 04/20] cpumask: Introduce cpu_preferred_mask Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 05/20] sysfs: Add preferred CPU file Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 06/20] sched/core: allow only preferred CPUs in is_cpu_allowed Shrikanth Hegde
2026-06-04 5:06 ` K Prateek Nayak
2026-06-04 5:54 ` Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 07/20] sched/fair: Select preferred CPU at wakeup when possible Shrikanth Hegde
2026-06-04 5:14 ` K Prateek Nayak
2026-06-04 5:48 ` Shrikanth Hegde
2026-06-08 16:39 ` Ilya Leoshkevich
2026-06-09 4:42 ` Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 08/20] sched/fair: load balance only among preferred CPUs Shrikanth Hegde
2026-06-04 5:20 ` K Prateek Nayak
2026-06-04 5:45 ` Shrikanth Hegde
2026-06-04 6:09 ` K Prateek Nayak
2026-06-04 13:07 ` Shrikanth Hegde
2026-06-09 11:22 ` Peter Zijlstra
2026-06-09 11:33 ` Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 09/20] sched/rt: Select a preferred CPU for wakeup and pulling rt task Shrikanth Hegde
2026-06-09 11:25 ` Peter Zijlstra
2026-06-09 11:30 ` Shrikanth Hegde
2026-06-10 17:13 ` Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 10/20] sched/core: Keep tick on non-preferred CPUs until tasks are out Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 11/20] sched/core: Push current task from non preferred CPU Shrikanth Hegde
2026-06-04 6:58 ` K Prateek Nayak
2026-06-04 9:43 ` Shrikanth Hegde
2026-06-04 9:56 ` K Prateek Nayak
2026-06-04 12:16 ` Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 12/20] sched/debug: Add migration stats due to non preferred CPUs Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 13/20] sched/debug: Create debugfs folder steal_monitor Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 14/20] sched/debug: Provide debugfs to enable/disable steal monitor Shrikanth Hegde
2026-06-08 17:37 ` Ilya Leoshkevich
2026-06-09 4:48 ` Shrikanth Hegde
2026-06-08 18:28 ` Ilya Leoshkevich
2026-06-09 5:04 ` Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 15/20] sched/core: Introduce a simple " Shrikanth Hegde
2026-06-08 16:25 ` Ilya Leoshkevich
2026-06-09 5:54 ` Shrikanth Hegde
2026-05-14 15:22 ` [PATCH v3 16/20] sched/core: Compute steal values at regular intervals Shrikanth Hegde
2026-05-14 15:22 ` [PATCH v3 17/20] sched/core: Introduce default arch handling code for inc/dec preferred CPUs Shrikanth Hegde
2026-06-08 16:22 ` Ilya Leoshkevich
2026-06-09 5:14 ` Shrikanth Hegde
2026-06-08 18:40 ` Ilya Leoshkevich
2026-06-09 6:42 ` Shrikanth Hegde
2026-05-14 15:22 ` [PATCH v3 18/20] sched/core: Handle steal values and mark CPUs as preferred Shrikanth Hegde
2026-05-14 15:22 ` [PATCH v3 19/20] sched/core: Mark the direction of steal values to avoid oscillations Shrikanth Hegde
2026-05-14 15:22 ` [PATCH v3 20/20] sched/debug: Add debug knobs for steal monitor Shrikanth Hegde
2026-06-04 3:17 ` [PATCH v3 00/20] sched: Introduce cpu_preferred_mask and steal-driven vCPU backoff Shrikanth Hegde
2026-06-09 19:51 ` Shrikanth Hegde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb564506-1881-4c08-ab63-d823875b818b@linux.ibm.com \
--to=sshegde@linux.ibm.com \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=chleroy@kernel.org \
--cc=christian.loehle@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=huschle@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=maz@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=pauld@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=seanjc@google.com \
--cc=srikar@linux.ibm.com \
--cc=tglx@kernel.org \
--cc=tj@kernel.org \
--cc=tommaso.cucinotta@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vineeth@bitbyteword.org \
--cc=vschneid@redhat.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®