From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E4EC6FD1C for ; Fri, 24 Mar 2023 09:16:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231346AbjCXJQW (ORCPT ); Fri, 24 Mar 2023 05:16:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbjCXJQS (ORCPT ); Fri, 24 Mar 2023 05:16:18 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EFDE1F4B9; Fri, 24 Mar 2023 02:16:17 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32O8de39016699; Fri, 24 Mar 2023 09:16:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=lUbjeb5tzd264tpcIsMS8Q0ujsT7b9ac9BoeEHI1JuA=; b=EoW+aFK1gCDWzFmC2S0eKFzhbjyUO6Xv2hMM63OmE0b8CJgDps5r+QndrSSaI7Y4Fi4/ WFoYx5w0IyIYbQ4AxL2dHMS1SCjdqu/H3fbEGSyYEmSzaE5WFUKxePg8KkuAWcBxSpSk TFTY51/9rIQM1let6zQ+AY7CUuiDikohrhwJ8LNCaTTMWyjP097tbAmyDdv5TxaUWPR0 eXnjl5vsp5Uarfmrv7kryLtQUzBZcJBwnqbu5afpo/eNHZ/jxM9M/roWJg9DKh6Zsx91 lnyRfVW5v0N6yBv3qJvl6CrXzLxMRqoYfgNOTkc1kWiRPH5IP2IrQU3CkKbv7/dTj1eH JA== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pgy609bf5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Mar 2023 09:16:02 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32O9G16j003993 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Mar 2023 09:16:01 GMT Received: from [10.239.133.211] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 24 Mar 2023 02:15:56 -0700 Message-ID: Date: Fri, 24 Mar 2023 17:15:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 01/11] dt-bindings: arm: Add support for DSB element size Content-Language: en-US From: Tao Zhang To: Suzuki K Poulose , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski CC: Jinlong Mao , Greg Kroah-Hartman , , , , , Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Hao Zhang , , Bjorn Andersson References: <1679551448-19160-1-git-send-email-quic_taozha@quicinc.com> <1679551448-19160-2-git-send-email-quic_taozha@quicinc.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Orai57WJvA2e38pUIZNBoUPJTmjdRpMH X-Proofpoint-GUID: Orai57WJvA2e38pUIZNBoUPJTmjdRpMH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_04,2023-03-23_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 malwarescore=0 spamscore=0 impostorscore=0 mlxlogscore=999 clxscore=1011 lowpriorityscore=0 bulkscore=0 mlxscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303240077 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Suzuki, 在 3/24/2023 4:25 PM, Tao Zhang 写道: > Hi Suzuki, > > 在 3/23/2023 7:18 PM, Suzuki K Poulose 写道: >> On 23/03/2023 06:03, Tao Zhang wrote: >>> Add property "qcom,dsb-elem-size" to support DSB(Discrete Single >>> Bit) element for TPDM. The associated aggregator will read this >>> size before it is enabled. DSB element size currently only >>> supports 32-bit and 64-bit. >>> >>> Signed-off-by: Tao Zhang >>> --- >>>   .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 11 +++++++++++ >>>   1 file changed, 11 insertions(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml >>> b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml >>> index 5c08342..d9b6b613 100644 >>> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml >>> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml >>> @@ -44,6 +44,15 @@ properties: >>>       minItems: 1 >>>       maxItems: 2 >> >> >>>   +  qcom,dsb-element-size: >>> +    description: >>> +      Specifies the DSB(Discrete Single Bit) element size supported by >>> +      the monitor. The associated aggregator will read this size >>> before it >>> +      is enabled. DSB element size currently only supports 32-bit >>> and 64-bit. >>> +    $ref: /schemas/types.yaml#/definitions/uint32 >>> +    minimum: 32 >>> +    maximum: 64 >> >> Shouldn't this be something like oneOf ? It is not a range, but one of >> those two specific values ? > > Yes, "qcom,dsb-element-size" should be an optional option required in > TPDM > > devicetree. Other properties like "qcom,cmb-element-size", > "qcom,tc-element-size" > > and etc. will be added in a later patch series. > > I will update this doc according to your advice in the next version of > the patch. > > Tao > Correct my misunderstanding in the mail above. You are right, DSB element size should be 32-bit or 64-bit. I will update this in the next patch series. Tao >> >> Suzuki >> >> > _______________________________________________ > CoreSight mailing list -- coresight@lists.linaro.org > To unsubscribe send an email to coresight-leave@lists.linaro.org