From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750985AbdAUP5l (ORCPT ); Sat, 21 Jan 2017 10:57:41 -0500 Received: from mail-db5eur01on0096.outbound.protection.outlook.com ([104.47.2.96]:18653 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750876AbdAUP5e (ORCPT ); Sat, 21 Jan 2017 10:57:34 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; From: Peter Rosin Subject: Re: [PATCH 1/2] i2c: mux: pca954x: Export OF device ID table as module aliases To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1484574895-952-1-git-send-email-javier@osg.samsung.com> Cc: Wolfram Sang , linux-i2c@vger.kernel.org Organization: Axentia Technologies AB Message-ID: Date: Sat, 21 Jan 2017 16:56:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484574895-952-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [217.210.101.82] X-ClientProxiedBy: HE1PR0701CA0053.eurprd07.prod.outlook.com (10.168.191.21) To AM5PR0202MB2548.eurprd02.prod.outlook.com (10.173.89.9) X-MS-Office365-Filtering-Correlation-Id: 4cc13955-88d0-480d-9353-08d442161a2e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AM5PR0202MB2548; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;3:LWIZYns7i0PsvaHGlThGwE5swJKYdp/kxaiIRC3NW6pXQO7Jmq/Ojq2Tdsc4QbErQrfL282LEnuGRTqViHMiKVzEE9mc5YQqKaIvXGtZ6us2mLvxuM5evca4wZyRblhLSvui83WBtxLhE9uSJoxGRQ4Up16Ijjh0cqOyAqsgtRsbjTlT96Bh4PN79t1DJ07DcLDqOEbISYyiyTmEjaG+hc00FNe0hSKz+2H5t0Mw5Xgt8zqoX7nj32vSnU9/HerRWAA8Z4fH/c0H4oNltq8ALA==;25:eouD9+WTPA/1BSWGP97AGf1J31bpCAVAZ29/1pZtNE2ryk4ydx8AU9R9hxSPYeHe8hL+9oPcIl7lJaN+1zFd9P6xmEtZfdXt06YnlgI2pydqG+ov+D/7Xrq+kOcp4Ami3R7aHmwFoesOPwWropeqyZemVCiUZEE9J/zA8NfsPI4YFx3Kl2fwB3xXTQ4ktkhyAzGrmLgIESOklxGb1xzA7p6zPDUZq2pIwQ0UOhBVvHlJDB7UcObuHCT6+kppZqx3bxarGgCdhYLt1G5YCO/XkULgKOHHUtOHMczl0saWrz0T7sMRLyMNEK9BebYoU62r6T7bMg0Xffd9OU7uLl28F1UczdC6yMXsKn7+l6RmMoZyjbLmFQ5VudRaXceFpv4R9FJvQgS+rec+y36NwrHtHwHwJaXRNiZXGogl+NhYAfU59SFaXpg40qmS10WPLfrnZwnxE7elFxMd1p3FGgs6Cw== X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;31:czB78AmGOKw3MDqRQnoeEuvG4FrHshBpmQ4LXigDCkuwTHu1q0UbXFJVmn1/LC2TFT9O+RHPAWGJz+2TVDtTgx814YoSV4rLhvZ71s3NJ+6NeOfdBVfbdx0H/6YahjcbhgbDtJDlbbnAgy5n9tmq6iPwOArPoIJHxmmUxNwQwFN4yupKKntwdBewWPT6et7sPpicxT4pkUqUWhk9+Lwvfw1ap3kCE8pC9eIC1OJouHVIlM3uziFG164lPswK+B704EJthctQrP0bhM/b1Ex8/Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(7411616537696); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123558021)(2016111802025)(20161123555025)(6072148)(6043046);SRVR:AM5PR0202MB2548;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0202MB2548; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;4:k7moX4upALK2yoekJWxarMnYhdUM27JPhkOJSouJTlEOwCnCbncD8gmVsNbmAuYC5qhV4B+2C1gku11Q7TZFaZFsfSh55A5SMT2KUmQBHXx6C8Zuern3OUzIGlGjl0Ck7k3aE6Y98xMzJoF6Qj9WY4GWqadzZ6m2KadVOv6M8xBK3KM13+fbWg/LLN+eoy+8BoLDoNzmlX7xurfHtbGtSObByKdOEgZCohGenc1EIVVnzVx7StFxBbU2u626X2+AKJIGwg40uHKDZYwSl/Nk0d1DeHigScNzmoFVNORsZUkYNeIi5a4tMdLj/KBksdOy2mwC4JkXM/MNPGdoPkdGS8IaflY5A7as6xru65AxI+pTsBkEOWDnkOo0vYM/IX0Sj+m2fRu3A2i6ePLYS5+lxwYQVDIdZPSbcW1+xi/sYcGL5JZnAppfqnUPVf1/70xl5fWrQcF5dqWj3KFoIY9j5zqoADMIqyJwDUcmqYlnhmfWOnFCrcWQWuHEEWGEtojZ062r8H0VgbVmpImi5z/9+hoCWYVFRK+yxsHjAKggM0J4FE+Xwp41cBSs/4Lj+rz5VZQC/kw0dOLBlxCioZ7Cj/21s3XqtWCRg5TwRdeWiin/jzyBLgIyg+jVpjg2H2luIqI+/5CVdmdlfcYKsqXcX5g47ODeQRm1HtCVxKS5IRWYEQC1aru2N/m5hsf32oJWiKmbuhqh3Odsri4o09QZdlQK2CH+1Ap3Pkr8eABSkt4= X-Forefront-PRVS: 01949FE337 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(39410400002)(39830400002)(39450400003)(377424004)(199003)(189002)(24454002)(92566002)(105586002)(8676002)(25786008)(65826007)(50986999)(4001350100001)(101416001)(76176999)(54356999)(31696002)(97736004)(64126003)(106356001)(68736007)(6666003)(42186005)(189998001)(86362001)(2950100002)(31686004)(77096006)(81166006)(47776003)(81156014)(36756003)(90366009)(5660300001)(6486002)(50466002)(38730400001)(110136003)(66066001)(229853002)(65806001)(53936002)(2906002)(3846002)(7736002)(65956001)(6116002)(74482002)(23746002)(83506001)(230700001)(117156001)(305945005)(33646002)(4326007)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:AM5PR0202MB2548;H:[192.168.0.125];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM5PR0202MB2548;23:QoRHncVmZtxbAo8A5EdEmu9h2ItZth5Kgvi?= =?Windows-1252?Q?bI1DW+/2qBMGhbSqZVTtd3M7u0BrC2JZ9jlpSIZvBn4I7zOPMqKF0ZZl?= =?Windows-1252?Q?X43X+mIcXxgOg+7QrF4AArm1EukX1wzWhyL6X/5e44cN1W5m8xIsRBkC?= =?Windows-1252?Q?ZQTKb+qo4OUPUlBoniPg3orYOV3e0LW7WVIxZ+Y7l4X0eGw9c3ihEgSL?= =?Windows-1252?Q?xurPS6EUt42p4eRx8KMVbObtgO+zGlLc4HHz+Rl6dkBien6sKHaaPxyc?= =?Windows-1252?Q?WWzzl9lNo1a9LirOSiEeOFiE8/faR7AgP4uyBKVXh3LRfwBgzaAMqvHm?= =?Windows-1252?Q?gKRUPekrgcuhz+Jwjvr4Go6JZYlwbq7gVHuf2rNjJEObsKN5OwG2u0Uy?= =?Windows-1252?Q?NdaJueQRfzvQRVxDg2qhN1/vQ2VKJU0cFmNboyubmNOneT2Lviz4W2+T?= =?Windows-1252?Q?wyi0LG00L8s5ZT8qX+SzoFjbIXW4EX8aDl/y4UeH8owc2WdP24eKRsr9?= =?Windows-1252?Q?KWP2L7v2YJRp5XhNJDc7I4jN3Gl9EVyJvFA5sSv5hffpLo3zLPz/RQ1J?= =?Windows-1252?Q?TPbyN4Jqh+7OwoXQ4bhtuwZIvFjj/5R+Q1EifEFfqRf2r6U96V4A+ZA9?= =?Windows-1252?Q?9dfARwE6yFrppBhzU7Jb5j2Xlsm7o4JYL/hsCCVw6F6HGQ/yANlr9711?= =?Windows-1252?Q?Q2mcIzhlFnYE918EKrDykfM985LM5mm8G1/EMdqQHHMBBIUWX3U4mthc?= =?Windows-1252?Q?E1V8dc7ZvSwfbf2OmdcrZaY39ThcbODpZg2HIIeQvrTJHxk/1InOqepk?= =?Windows-1252?Q?CYVyEycDgymruLnaQsnBrvyE4jTWzxppdZLA16i4uLEDA+hr7IlexO7/?= =?Windows-1252?Q?C5DNyFZ8nXTislnYEAOBv1QIXrz5u4jSxZJCW6d+zNCOWu5f8X17xcGR?= =?Windows-1252?Q?GaIlcL2Epi2ktN6HJjw5uCjE8PjfsytcBFkIenZUL8BM8NSJOdlGqaWd?= =?Windows-1252?Q?XKVDHAlJ41oXT16NeOm6yqTWvQeV1FDXuYXs94YRbHqB8Sys9YroI9Vd?= =?Windows-1252?Q?GiUSt7FmpFlxxdd/decPK9C/MJi39MtpjrRMJdZ98Ru6M1PE983nNEmo?= =?Windows-1252?Q?71JXS4zaiGzGvyMUOMkzuUsjSElr/hXkEVS8VuWksAD55jSEJ3ldUR3h?= =?Windows-1252?Q?ct5SlVx4GAXmVtgTaK4tq4GxOwXyK0RQpGjDoQuBLZqYcReZnxpljhLf?= =?Windows-1252?Q?oPo4NMNy+s2vLQD4atwcz/zTorKrE0ZQu+Y+mq9QT1Wp2e0CaFCrqMYu?= =?Windows-1252?Q?izDeVFBZfyD75ry5QxBqC7marhiHw76+UiFnRu1CBDY69E2ebs2/63xk?= =?Windows-1252?Q?NxRFUT0fcupIh8qFg289Qn3LiJK2fXUa4b1XaPpGJ3Rd5a/BApAoj0Cx?= =?Windows-1252?Q?rcgAdSicxAYd5Sc5WuPLG/T7Y/1P87WCvKPnAwXYhCATMPBJl4AUts+M?= =?Windows-1252?Q?G0Eu1krujLw++fkvUFtRhrImF+9A64NGw8UNuT7b+4S4C4/emBYxTVEn?= =?Windows-1252?Q?9W7mVG1RLYTeJHscKur7TI/wbNC936iM9NAvy?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;6:9J0879y09+BofvaNok0Z3B5Q5jw+0r/gL+Den1J6Qd0l18UTBH3lIN0xonEWHc9LvuSFTv8RDP2kYjyznV9R5lXa8t07B5+NiFJSQvEL+1TsOEy+WyyrIPgcs1nQos1bpzyZn0R08a5eFt76E9Ldb0brDtMkItTQ2DcDcZv8MC95vGNmPXaHdPKV1lugG3sGp9UN9l132UwXrFKbze/5Cwb/7pB/QhXuMGt1pHUrmbJq78Xbx4U+9Fjn/HzAn2Oh1g4W8OCGS/nIL2Sl2cUuiAruzB7XXdKtIj7zFt3sUsR58qUxXXFjuLxO6a9663qW4p89QXHH49XzHi8hvr6nslqxXxM+zmFzcw5FGBkMu/dDXMZ1URdwqPk/9VF3FRit5CDJiC3qsatkDfFhswnReO2TZzFYNOsRSctgbGat7oS5pbcY+pbbCgNQrOBqNrET;5:YBcy3izbPQ3opA6emRRUMDPAQgeuk/DqhSh9qCpZ3A/JoxuKjPEaWARkxHnS25frb6aCl8oicCYTD098RSyXv5BsdhaaRBvJL6Y9MrxH7Qdc2lZaSLEsLmuceQo6JKtN0ZO3BYwEVFEUkFLiln5DYw==;24:h0+2DyG2ZGrJ8q0g9G8x+5eCBvZTxwLTIwZVUXwSmfzFaerzSeHxCjCN4tZgtREwszbR2mRNG0n2bhrD4FhH+RbxP8RKXyfJdM1I7JO5XAY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM5PR0202MB2548;7:CkSkYUF0vNEoKhOwks6+xjUF9Wc3oDSEo+k6raK/UspX+cUQhzBQpUyqeOcfv4diOtR9KrNCCTh106zkrnl/cy4OeJ1ZTtLy+2RoFazBmc8QPsTHs9RYr+joiEbd8PrYIjNcH9Ppha+RhHD5zG6Owj4WkgENQ4kL7OZHJL+3aOfUalzODvz9ST97/2guhq2U3L8WtdlAYeT0VKihv2G1FNpg5tYLRi+iEdj/DTSOYCXlzudI4CxrHwP62d0DzJVu3xWc130GXXO4idOw0J3y/46p5RZbvGI7sBm5cULRXPUsEC1WE1CU+OSJkp0gMLt5YpIENH0/3GR1ObagFy2Mrx0e1tVOdaS22n8PXGSVuWwHHU4jaVg5fPH1g1JVsAMMqL+drkKJ9awYUBhrEs7u5Ji3N4z+piZU465oxcq65XpIhw+avBflhP3m3r2N1P3Bj89OcGEpeNM4XPZwDp68fQ== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2017 15:56:45.6487 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0202MB2548 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-01-16 14:54, Javier Martinez Canillas wrote: > The I2C core always reports a MODALIAS of the form i2c: even if the > device was registered via OF, this means that exporting the OF device ID > table device aliases in the module is not needed. But in order to change > how the core reports modaliases to user-space, it's better to export it. > > Signed-off-by: Javier Martinez Canillas Acked-by: Peter Rosin > --- > > drivers/i2c/muxes/i2c-mux-pca954x.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c > index dd18b9ccb1f4..a0232e079545 100644 > --- a/drivers/i2c/muxes/i2c-mux-pca954x.c > +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c > @@ -148,6 +148,7 @@ static const struct of_device_id pca954x_of_match[] = { > { .compatible = "nxp,pca9548", .data = &chips[pca_9548] }, > {} > }; > +MODULE_DEVICE_TABLE(of, pca954x_of_match); > #endif > > /* Write to mux register. Don't use i2c_transfer()/i2c_smbus_xfer() >