mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] compiler.h: Support 64-bit bitwise types in is_signed_type()
Date: Tue, 17 Nov 2026 08:32:11 -0800	[thread overview]
Message-ID: <fb66a344-b688-4660-90e2-018d31c2a482@acm.org> (raw)
In-Reply-To: <20261117080621.7ca022dd@pumpkin>

On 11/17/26 12:06 AM, David Laight wrote:
> Don't the trace definitions need fixing?
> The trace code prints the numeric value so you really want a host
> ordered value in the trace record.
> 
> An alternative view is that even asking the question 'is_signed_type'
> of a bitwise variable makes no sense.
Are you perhaps suggesting that we should tell ftrace users that it is
no longer allowed to declare __le64 fields, something they probably
would not consider reasonable? Please let me know if I misunderstood
your question. Below is an incomplete overview of the examples of __le64
tracing fields (__le64 typedefs have been ignored):

$ git grep -nHF '__field(__le64'
net/ieee802154/trace.h:74:		__field(__le64, extended_addr)
net/ieee802154/trace.h:367:		__field(__le64, addr)
net/ieee802154/trace.h:386:		__field(__le64, addr)
net/mac80211/trace.h:2507:		__field(__le64, twt)
net/mac802154/trace.h:191:		__field(__le64, extended_addr)
net/mac802154/trace.h:272:		__field(__le64, addr)

Thanks,

Bart.

      reply	other threads:[~2026-11-17 16:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 22:26 Bart Van Assche
2026-11-17  8:06 ` David Laight
2026-11-17 16:32   ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb66a344-b688-4660-90e2-018d31c2a482@acm.org \
    --to=bvanassche@acm.org \
    --cc=david.laight.linux@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®