From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755635AbdK2RZX (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Nov 2017 12:25:23 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:45381 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753571AbdK2RZT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Nov 2017 12:25:19 -0500
Subject: Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset
 with 'do_flr' SysFS attribute
To: Jan Beulich <JBeulich@suse.com>, Konrad Wilk <konrad.wilk@oracle.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        linux-kernel@vger.kernel.org
References: <20171106174842.20276-1-Govinda.Tatti@Oracle.COM>
 <5A01D3F3020000780018CE86@prv-mh.provo.novell.com>
 <8940b38d-715c-9fcb-cc74-46574d416703@oracle.com>
 <5A041FB9020000780018D6E8@prv-mh.provo.novell.com>
 <af25e0d8-ca55-7eb4-649e-5297b0e09299@oracle.com>
 <5A1EE1D50200007800193318@prv-mh.provo.novell.com>
From: Govinda Tatti <govinda.tatti@oracle.com>
Organization: Oracle Corporation
Message-ID: <fb6d3c3b-2fba-1903-d3b1-bf7aeefd7ee8@oracle.com>
Date: Wed, 29 Nov 2017 11:25:09 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <5A1EE1D50200007800193318@prv-mh.provo.novell.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>>> Furthermore, contrary to what you claim in
>>> your reply to Pasi, I can't see where you try an actual FLR first -
>>> you go straight to pci_probe_reset_{slot,bus}(). If you actually
>>> tried FLR first, only falling back to the other methods as "emulation",
>>> I could certainly agree with the file name chosen.
>> Currently, multiple resets are being invoked (independently) in the context
>> of "xl attach/detach/shutdown/reboot".
>>
>> - pci_reset_function_locked (invoked by pcistub_put_pci_dev())
>>     This function tries various PCI reset methods including FLR.
>> - pcistub_reset_dev (called by toolsstack based on "do_flr" attribute)
> While related in a certain way, I can't really see how this addresses
> the comment.
pcistub_reset_dev() just tries slot or bus reset but not FLR since it is 
being
checked and executed by pci_reset_function_locked() if supported. May be 
we can
add FLR reset code to pcistub_reset_dev() and try FLR first before 
fall-back to
slot/bus reset.

Cheers
GOVINDA