From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751336AbdAQOfG (ORCPT ); Tue, 17 Jan 2017 09:35:06 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:35394 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750920AbdAQOeJ (ORCPT ); Tue, 17 Jan 2017 09:34:09 -0500 Subject: Re: [PATCH 1/3] Input: add STMicroelectronics FingerTip touchscreen driver To: Andi Shyti , Dmitry Torokhov , Krzysztof Kozlowski , Rob Herring , Chanwoo Choi References: <20170117135441.31450-1-andi.shyti@samsung.com> <20170117135441.31450-2-andi.shyti@samsung.com> From: Javier Martinez Canillas Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Andi Shyti Message-ID: Date: Tue, 17 Jan 2017 11:32:49 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20170117135441.31450-2-andi.shyti@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andi, On 01/17/2017 10:54 AM, Andi Shyti wrote: > Add binding for the STMicroelectronics FingerTip (stmfts) > touchscreen driver. > > Signed-off-by: Andi Shyti > --- The binding looks good to me, I've just a minor nit below. [snip] > + > +i2c@00000000 { > + > + /* ... */ > + > + stmfts@49 { The ePAPR document says: The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model. So I think this should be touchscreen@49 instead. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America