From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79253222594 for ; Sun, 24 Aug 2025 19:04:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756062292; cv=none; b=pFTdLGHFQmkRzfkWJJWxaXwKVPiWNMNAR3YF4DkF8dY34lLyM0dzFub6zOGaRzZuDTrUKKXpWin/bABfr5iQaw1oydLx84PBhRGXdWwZ05JaK165WK9HB95KuCz67h2qcsODxv4lq2TfHLkw1c9IXAuYcE47oeZE4CPEXG/SGSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756062292; c=relaxed/simple; bh=UP+AYol+DY8UTEmT5RaSgfZsggShtTb7514fxVj9jCY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FSglRV22jFWKJXt670jPtCBSDd8hQdUAWA0Ayq+Z5TV402PmFhObcTPtlfH0hgFsO9P85zo2LwSDJVOJnDEu8MpEoxYCuObCa3SUmOmeRlGN5Ni/jJIZpDLEWhS17XrWu6HgQHWs6zT8sGgbixnZ4kpQe7AX669RY9hfTHapZE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qHcxGRsy; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qHcxGRsy" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-55ce52718abso291761e87.3 for ; Sun, 24 Aug 2025 12:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756062289; x=1756667089; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=6yqEEUlIDSc/+3KFB8fDmfBaOKciQCNwulQzIyyj/3k=; b=qHcxGRsy5tIK0v++VkHxEfyQ88KzzyhfSF99VN23K3ywDghRR94oaktyORxz9rEU8V qHqEp4nmlwU+GgyEa4ykYXnNvSxqlXqadaJlIDcF+AoWvFq8IG1OkvBjcuF8m6SfmOVc XnWltwOXGrLkVRJ2UfSWYx7Zizk053TEb+Ow9o/AXuqeFi0boYVZ6S33ed+viMdqBZXr vk/DAjaVd2HQY7WUg0NZzW1niyqm8hTGckzSBhLzXdhBgIwlOokac7cQbivII3SCGMwM 4eVum7YUeosAZsjdXJ6o2QdkgLPn4N/n3xf1MfABTuJb4IAiXUxZdWGScduS9zK/myG3 7CRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756062289; x=1756667089; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6yqEEUlIDSc/+3KFB8fDmfBaOKciQCNwulQzIyyj/3k=; b=mbbQrAP7nqkoG+KCR00xgIe0wX0sYAO19fnjze2wh5RJF+CNgEC5NA260pGZ0MXVao x2wm34WueKI32vJAPH+Hi5MjJcQRyPeXKEuRUfQY0ZAYY18gldwnXNBb5QopHvcSowCh mANpyF0Za71ROwVmT4RCBh/buKs92UY40t9psPNQiDuXMRYP7nz2ciEAa6BzDRHSlpU1 mkU/SgQ5RBUQEwLPnBKpwwczy8Tbb1YZYBalCL/cT+HgHr7YDcueus5MBykfqAIcm52w 9GQYB3ujtAaVBr2TY4BNTf+3XtkLQ+siMBIR9vECwRMHOee9DrT9FJ2PFl4qkkcGk77a 2uyg== X-Forwarded-Encrypted: i=1; AJvYcCWkb6tIOnwU/qVxYVAXjOMNWO/yrAoVPVwGqqMlBT2JwgUZ7qZbfoEYVCk4kpxgUOUrFmThUr7H/qBQnPs=@vger.kernel.org X-Gm-Message-State: AOJu0YyehAYfmTKTUwetGdDJ042X2sZMW9BobWQcs1vXperw0fgcmHYV 2RduE6subfakAwkV9CJPNLm1BEoaIkd6OsLSxB3ufcYJcJCFC3Arm65GX/C6bBFc1Ks= X-Gm-Gg: ASbGncvMdJGnu+te+UEi3F6CMEDvjuhuMrSHMguLpb3uTKCcBrdBucwkuUg7FJj6y0C Xn9LnZG8oXHUryOsAUIp82vEv7rq0Vi9j8ED/GHvfyNo2ek3f1na+CrzjAfdBwUpUo3RJu8AUHR JS5eXPos9XI0KqkMbe36+DwWXReeMjOnFSyWfu5xj1nxVrA8z71HA3D7n0MD6s1lYLHIw4H17Kt 9UL1oUQ+C6tzyhIEggru9wqKwpcTV/zBGO4odxSaUcp686UV8VKyxn6ig3UXUsBz6dhEzDarwsI pyXu0SPXhRgHrb82O/aVs0fkaFB5/QuyHx19eYX/P6jU/T8WiI4qzyysxcygIuNlooG/ivVFCNS yzuF7wD+W52GEZWWb1WhI5Beyr0jcpIEcpvYTLDr9V4VJoFt9AwcOPX/ffypNJj1UM25aDtohDH Wd X-Google-Smtp-Source: AGHT+IFyrm2w79r4qu/FnmHu4qBJdoxQ8tpCUb7HA7mtPlKxjeyzi9xJQ9J7AuBmZ4uek0zzq2ON9Q== X-Received: by 2002:a05:6512:a85:b0:553:24b4:6492 with SMTP id 2adb3069b0e04-55f0cd6ef0bmr1246189e87.5.1756062288277; Sun, 24 Aug 2025 12:04:48 -0700 (PDT) Received: from [192.168.1.100] (88-112-128-43.elisa-laajakaista.fi. [88.112.128.43]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55f35c8bb4esm1204996e87.75.2025.08.24.12.04.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Aug 2025 12:04:47 -0700 (PDT) Message-ID: Date: Sun, 24 Aug 2025 22:04:45 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 19/65] media: camss: Replace .open() file operation with v4l2_fh_open() To: Jacopo Mondi , Mauro Carvalho Chehab , Devarsh Thakkar , Benoit Parrot , Hans Verkuil , Laurent Pinchart , Hans de Goede , Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman , Alex Shi , Yanteng Si , Jonathan Corbet , Tomasz Figa , Marek Szyprowski , Andy Walls , Michael Tretter , Pengutronix Kernel Team , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Mirela Rabulea , Shawn Guo , Sascha Hauer , Fabio Estevam , Kieran Bingham , Michal Simek , Ming Qian , Zhou Peng , Xavier Roumegue , Philipp Zabel , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Sylwester Nawrocki , Jernej Skrabec , Chen-Yu Tsai , Samuel Holland , Daniel Almeida , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Tiffany Lin , Yunfei Dong , Geert Uytterhoeven , Magnus Damm , Mikhail Ulyanov , Jacob Chen , Heiko Stuebner , Detlev Casanova , Krzysztof Kozlowski , Sylwester Nawrocki , =?UTF-8?Q?=C5=81ukasz_Stelmach?= , Andrzej Pietrasiewicz , Jacek Anaszewski , Andrzej Hajda , Fabien Dessenne , Jean-Christophe Trotin , Maxime Coquelin , Alexandre Torgue , Nicolas Dufresne , Benjamin Gaignard , Steve Longerbeam , Maxime Ripard , Paul Kocialkowski , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Robert Foss , Todor Tomov , Corentin Labbe , Sakari Ailus , Stanislaw Gruszka Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, mjpeg-users@lists.sourceforge.net References: <20250802-media-private-data-v1-0-eb140ddd6a9d@ideasonboard.com> <20250802-media-private-data-v1-19-eb140ddd6a9d@ideasonboard.com> From: Vladimir Zapolskiy In-Reply-To: <20250802-media-private-data-v1-19-eb140ddd6a9d@ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jacopo, Laurent, thank you for the nice clean-up. On 8/2/25 12:22, Jacopo Mondi wrote: > From: Laurent Pinchart > > The custom video_open() function in the camss driver open-codes the > v4l2_fh_open() helper, with an additional mutex that protects the whole > function. Given that the function does not modify any data guarded by > the lock, there's no need for using the mutex and the function can be > replaced by v4l2_fh_open(). > > Signed-off-by: Laurent Pinchart > Signed-off-by: Jacopo Mondi Tested-by: Vladimir Zapolskiy Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir