From: Yureka <yureka@cyberchaos.dev>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Yureka Lilian <yureka@cyberchaos.dev>
Cc: Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,
Neal Gompa <neal@gompa.dev>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Hector Martin <marcan@marcan.st>,
"Joerg Roedel (AMD)" <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
iommu@lists.linux.dev
Subject: Re: [PATCH 03/15] dt-bindings: nvme: apple: Add apple,t8142-nvme-ans2 compatible
Date: Wed, 11 Nov 2026 15:32:51 +0100 [thread overview]
Message-ID: <fb7b4ede-a325-4c5e-a37d-fe3cc7a92f87@cyberchaos.dev> (raw)
In-Reply-To: <20261111-comical-quaint-turaco-e8c1c2@quoll>
On 11/11/26 13:46, Krzysztof Kozlowski wrote:
> On Fri, Nov 06, 2026 at 10:04:12PM +0100, Yureka Lilian wrote:
>> "apple,t8142-nvme-ans2" on the Apple M5 SoC is compatible with
>> "apple,t8132-nvme-ans2" so add its per-SoC compatible.
>>
>> Signed-off-by: Yureka Lilian <yureka@cyberchaos.dev>
>> ---
>> Documentation/devicetree/bindings/nvme/apple,nvme-ans.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
> Squash all nvmem patches. Don't add compatibles one by one.
>
> Best regards,
> Krzysztof
Hello Krzysztof,
(replying to all three of your emails here)
thanks for your feedback! I did run `b4 prep --check` and `make
dtbs_check` before sending and it passed without warnings on all 15
patches of this series. I will now also run `checkpatch.pl --strict` as
you suggested.
For v2, I will make one commit per type of dt-binding, so "dt-bindings:
nvme: apple: Add t6040,t8140,t8142", and then "mailbox: apple,mailbox:
Add t8132,t6040,t8140,t8142", etc., ok or do you have another suggested
grouping?
> Please stop inflating this. You are only making it difficult to
review your work.
It would be appreciated if you can tell me clearly what is expected, as
this statement is not actually telling me what is inflated / wrong.
Thank you!
next prev parent reply other threads:[~2026-11-11 14:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 21:04 [PATCH 00/15] NVMe support for Apple M4, M4 Pro/Max and M5 devices Yureka Lilian
2026-11-06 21:04 ` [PATCH 01/15] dt-bindings: nvme: apple: Add apple,t8140-nvme-ans2 compatible Yureka Lilian
2026-11-11 12:45 ` Krzysztof Kozlowski
2026-11-06 21:04 ` [PATCH 02/15] dt-bindings: nvme: apple: Add apple,t6041-nvme-ans2 compatible Yureka Lilian
2026-11-06 21:04 ` [PATCH 03/15] dt-bindings: nvme: apple: Add apple,t8142-nvme-ans2 compatible Yureka Lilian
2026-11-11 12:46 ` Krzysztof Kozlowski
2026-11-11 14:32 ` Yureka [this message]
2026-11-06 21:04 ` [PATCH 04/15] dt-bindings: mailbox: apple,mailbox: Add t8132 compatible Yureka Lilian
2026-11-06 21:04 ` [PATCH 05/15] dt-bindings: mailbox: apple,mailbox: Add t8140 compatible Yureka Lilian
2026-11-06 21:04 ` [PATCH 06/15] dt-bindings: mailbox: apple,mailbox: Add t6041 compatible Yureka Lilian
2026-11-06 21:04 ` [PATCH 07/15] dt-bindings: mailbox: apple,mailbox: Add t8142 compatible Yureka Lilian
2026-11-11 12:46 ` Krzysztof Kozlowski
2026-11-06 21:04 ` [PATCH 08/15] dt-bindings: iommu: apple,sart: Add t8132 compatibles Yureka Lilian
2026-11-06 21:04 ` [PATCH 09/15] dt-bindings: iommu: apple,sart: Add t8140 compatibles Yureka Lilian
2026-11-06 21:04 ` [PATCH 10/15] dt-bindings: iommu: apple,sart: Add t6041 compatibles Yureka Lilian
2026-11-06 21:04 ` [PATCH 11/15] dt-bindings: iommu: apple,sart: Add t8142 compatibles Yureka Lilian
2026-11-06 21:04 ` [PATCH 12/15] arm64: dts: apple: t8132: Add NVMe nodes Yureka Lilian
2026-11-06 21:04 ` [PATCH 13/15] arm64: dts: apple: t8140: " Yureka Lilian
2026-11-06 21:04 ` [PATCH 14/15] arm64: dts: apple: t604x: " Yureka Lilian
2026-11-06 21:04 ` [PATCH 15/15] arm64: dts: apple: t8142: " Yureka Lilian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb7b4ede-a325-4c5e-a37d-fe3cc7a92f87@cyberchaos.dev \
--to=yureka@cyberchaos.dev \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=j@jannau.net \
--cc=jassisinghbrar@gmail.com \
--cc=joro@8bytes.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=neal@gompa.dev \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sven@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®