From: Dan Carpenter <dan.carpenter@linaro.org>
To: Zhang Shurong <zhang_shurong@foxmail.com>
Cc: gregkh@linuxfoundation.org, error27@gmail.com,
xu.panda@zte.com.cn, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
Date: Mon, 10 Jul 2023 09:08:27 +0300 [thread overview]
Message-ID: <fb7fac70-1d81-4dee-97ed-66c6a58720ca@kadam.mountain> (raw)
In-Reply-To: <tencent_5153B668C0283CAA15AA518325346E026A09@qq.com>
On Sun, Jul 09, 2023 at 01:50:07PM +0800, Zhang Shurong wrote:
> The "exc->key_len" is a u16 that comes from the user. If it's over
> IW_ENCODING_TOKEN_MAX (64) that could lead to memory corruption.
>
> Fixes: b121d84882b9 ("staging: ks7010: simplify calls to memcpy()")
>
> Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
prev parent reply other threads:[~2023-07-10 6:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 5:50 Zhang Shurong
[not found] ` <2a41ca22-a0eb-df38-be43-7175e1230bd0@web.de>
2023-07-09 19:42 ` Greg Kroah-Hartman
[not found] ` <e24f9c2c-1163-631a-f8c0-b6dcb445a858@web.de>
2023-07-10 5:41 ` Zhang Shurong
2023-07-10 5:47 ` Greg Kroah-Hartman
2023-07-10 6:08 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb7fac70-1d81-4dee-97ed-66c6a58720ca@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=xu.panda@zte.com.cn \
--cc=zhang_shurong@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®