From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4249E33D6D6 for ; Fri, 19 Dec 2025 12:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766147504; cv=none; b=aOtvfmvJgHHYm2xYCRT1Az108bliyS0JhAkoox/KkBrceN03Mij/2mN0ycnXqEfslRuvAwg1y9/ut2vduszsnB0OMWvsY40uw5HTYF0pRuTNL3y+F2Pimx4BYTNmGSzumk+XqlHw2ajlfxMBctRxRhE1GnMGgJRnyXBrr2AS+Wk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766147504; c=relaxed/simple; bh=1Tp2/sfP/qbPgdMYmFEsrj96YPoNyVSxCnPqqF92bY0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gGKsXkwvPWDrSHdP0dwoIwYfkbAE0VlfL1rEn1RhwOVDMVAOzemErtUHBeLlI6qQLFLaO/D4s0xI3fV+T9X7wfCrTHjguIskwth/WuCeKWavYh/ublPBkdBJ/k6Dsq8i0sI+D6h0MKEkVm4fRMBwSJs137+p9fReVTxamCsiriU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Y53PdL6a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N7NN8AJY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Y53PdL6a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N7NN8AJY" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBlT6W3318713 for ; Fri, 19 Dec 2025 12:31:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ioW0G0zJ4Gdvp4lZXdiH2R11D9QynBBhy4Ub0b1zw94=; b=Y53PdL6aQDbnwihC +ASUVruZXtffu8ooMZ9BM4QpJp0Q5GszS1OBaPdhLMT2MM5+I2bChf+jO0bbNjsA bL3Y6ntl3eqBt5dWAR9IRCixNmJGteIET35NMZugjlNB/D2mXLUOynNHv4S389T+ rB89u9uufj2Vwr2QexI5pgwZlc4c9DE/LRvkb26q9XnkbhbGPJlx7pHK8On8rJGp 5tASx+V1aHb4+/g+9afPmAUm3ZRDICYI4Er2oHvLWrpaX42y6cSe4A3/tzeE2Nzg ovzhYwYX5sd0I2NICvmNbaeUanmALvdODC9pxz1t+nijJeSgZytFF0KSZhkmjlYA iQQflA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2etjx3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 12:31:31 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a07fa318fdso29345955ad.0 for ; Fri, 19 Dec 2025 04:31:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766147491; x=1766752291; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ioW0G0zJ4Gdvp4lZXdiH2R11D9QynBBhy4Ub0b1zw94=; b=N7NN8AJYHU4OEpAqBJCrfCy2iPT8UHwuCtz62zApQxQtfSFkBHQ5OJsEGwiXCizuMS 3WmCW24OD0sNRVtutRkFM11Z59C/VgrgV/xX19YarOBivRiPAHlpAqudepZTTyQZ3ngt IMwBiLkV7FPo8htU85BufONm73QPOu8NV2hixnbpfC6+/pbaqmIQBe+tW4KDvmZjgDOr 4W/anGaimnVBGezlVJmN5eCw7eziOkEdz1nBqY75BnQB8xHHAMpNBSjUPsvD0omUIoiP IiNFI0xvBBs4gaMqxor1DlcKOJqWLVaxm2Hi/wGC/RNwriKi3csrNSshGq21eWwOH7Ay CGhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766147491; x=1766752291; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ioW0G0zJ4Gdvp4lZXdiH2R11D9QynBBhy4Ub0b1zw94=; b=l37Zu0wiMuBz/l1FNr+Q5T3gqd3oPToEWKryrD171Ijmy7Qu8OcY0OVnJy+uwnFhxe b/XCW4PtZh+lzc8WYfpDFhJDq28GoBwOhpUp2SPraGeD1XnTYWCnj/+szLb23u+NMX1J YfZ8hRna69KN6+pzA6iOiM8je8RoCClDXSu4W7QmW3W83bPUUHahWygSLGRNXlGzf4gq qwYf6aU3zcq1sLSW3T41wRAjnKc9hADLDIx8SnGdo0lggMm5XAIk9+kuSVSXwItu8ij/ J1kNpgb9SQw/WJ1s7Ct1VbFU8GD33RbQwaPC3vGC8pfW4TUWQcONFO1pNhgzfIxPpsm9 wL1A== X-Forwarded-Encrypted: i=1; AJvYcCWV9Kdj1QSQyZ1RLdNdK98IGowTe9K1/4oT9Dj7BHZ0mnS9ulxej/M7GKfzA/+5M79iIJsuZYmchl9XoXo=@vger.kernel.org X-Gm-Message-State: AOJu0YxGtCboCyxkvhKqOUJLH7If03hZhBFSw7Gse4JJOfOUSqUYFaVr lQRC0LdQ0L1nY3pvCzFVyRGAhcqNc+0f1y/gsjIivoi8VBUFMAnr4kSpjXOQW80AVbj67peOmnD 1kFlRRy9K467R2vJHz9AyvWae4U3v7pda2TT9ThIM//7ksiYRO78bwjykfzMm9CJ0q4k= X-Gm-Gg: AY/fxX5NcnBQbQjbDxSpdRwjX9gwthQTfRgdb7mOOCiz8haU9EN0t2CEoLxUWiJWiFH CaXXLNShC20npbv9pWGETDhGnZqKcg1TNUB/NYwudymn7kB14m329nOukwMV8XOTraH27nD+F8C rmnShTN84IrH+QN/gRzshs1uAMaTmhsw6tz848ibFqI0DQ2oRhd2dVziw3UJsIlNHvh9nttmEk+ eM+bfhT2C8X827kOlukySrfy15Eix85O28o08f2VimVAoX4vFDnWxaftg6NAY8VnyKdgbKLh3zv aGRD5Vu/MXV+vaKNNBmUdf9kdGNUZK42oMWA8pUDKB1Ak+giKf5mnPEv4B/HqGNM8DPgygSc/rg 1jPfIPrQubr6AyWi9G4EmOLB+ODPdbH5AitcjgLmhPfB/uavhD7/sV1Rw5KmAurmOWWrSU9x1ZS o= X-Received: by 2002:a17:903:40cb:b0:29e:facd:7c02 with SMTP id d9443c01a7336-2a2f2830ff4mr25392845ad.28.1766147490860; Fri, 19 Dec 2025 04:31:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHM8Jv5Jkofia0A3RPi3up+pQSDHmJf6El7fJWTt+Lsi65z07vLOF5Nh2CNUeO5SHV4wGRs3Q== X-Received: by 2002:a17:903:40cb:b0:29e:facd:7c02 with SMTP id d9443c01a7336-2a2f2830ff4mr25392555ad.28.1766147490338; Fri, 19 Dec 2025 04:31:30 -0800 (PST) Received: from [10.133.33.111] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d4cbe5sm22232245ad.60.2025.12.19.04.31.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 04:31:28 -0800 (PST) Message-ID: Date: Fri, 19 Dec 2025 20:31:21 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] coresight: tpda: add logic to configure TPDA_SYNCR register To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tao Zhang References: <20251219-add_sysfs_nodes_to_configure_tpda-v5-0-ca93ddfe9d30@oss.qualcomm.com> <20251219-add_sysfs_nodes_to_configure_tpda-v5-2-ca93ddfe9d30@oss.qualcomm.com> <38dc6948-6233-4b0a-a769-538939abe345@arm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <38dc6948-6233-4b0a-a769-538939abe345@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: g_92MUul1hOHbvEfOYGCgFTmlVtV5Jyk X-Proofpoint-ORIG-GUID: g_92MUul1hOHbvEfOYGCgFTmlVtV5Jyk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDEwNCBTYWx0ZWRfX2rg/X1XzGQkn FDhGUnnOpQ3zAllA+8LtHnFUQ4XRpuYsMzAERcDq+TIu2FX+kip9LR/+xvStmmssX+eFJ2k09Hq JNvuIuQ7h3O9Pv3TmfQcu51hSwLSFEvB9jTqrWqWUyzM1qFVwNG+XDE+3Xbd3CVbDb/SnvLLJIf WEaLTR99HEUAmI67GkE1c84ZYqOYalyLOJPaZhpEER024tGNt7PtqjZcwBu02pIzi/yeaY+PYmo GTSGQbTUuS8sbdskvvri4DS4ZKi5Ug9FQkNF7pqQBLTsGLPLD5PjrQL1tFMUtARkM2VFlRbO0Wk wfAdMmNDtzM5i3CVRHmwiQTf9xrjAz4ZR4KE5521Bz+/tD4AHoniqbbvVZFO3D8JKu++6sK64w4 7YSJlZq3pmjujy0QAyDSxytyQpExTLwygxiWPzJmRn7wbv72FgoFOWMNy9acwmOfY7BGlBPr+XY mqCxgKHi3iqi72WG2Xg== X-Authority-Analysis: v=2.4 cv=Tp7rRTXh c=1 sm=1 tr=0 ts=694545a3 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=8OLJw_hJ6b_DfWCpv44A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_03,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190104 On 12/19/2025 6:24 PM, Suzuki K Poulose wrote: > On 19/12/2025 10:04, Jie Gan wrote: >> From: Tao Zhang >> >> The TPDA_SYNC counter tracks the number of bytes transferred from the >> aggregator. When this count reaches the value programmed in the >> TPDA_SYNCR register, an ASYNC request is triggered, allowing userspace >> tools to accurately parse each valid packet. >> >> Signed-off-by: Tao Zhang >> Reviewed-by: James Clark >> Co-developed-by: Jie Gan >> Signed-off-by: Jie Gan >> --- >>   drivers/hwtracing/coresight/coresight-tpda.c | 7 +++++++ >>   drivers/hwtracing/coresight/coresight-tpda.h | 5 +++++ >>   2 files changed, 12 insertions(+) >> >> diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/ >> hwtracing/coresight/coresight-tpda.c >> index d25a8bcfb3d4..d378ff8ad77d 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpda.c >> +++ b/drivers/hwtracing/coresight/coresight-tpda.c >> @@ -163,6 +163,13 @@ static void tpda_enable_pre_port(struct >> tpda_drvdata *drvdata) >>        */ >>       if (drvdata->trig_flag_ts) >>           writel_relaxed(0x0, drvdata->base + TPDA_FPID_CR); >> + >> +    val = readl_relaxed(drvdata->base + TPDA_SYNCR); >> +    /* Reset the mode ctrl */ >> +    val &= ~TPDA_SYNCR_MODE_CTRL; >> +    /* Program the counter value for TPDA_SYNCR */ >> +    val |= TPDA_SYNCR_COUNTER_MASK; > > Do we plan to change this value via sysfs ? If not whats the point of > clearing the field. Why not simply set it (as it is all 1s anyways). We configure the value only once during enablement and do not intend to modify it through sysfs. The mode_ctrl is reset to reinitialize the counter. For example, if the TPDA device has been enabled and then disabled, the counter may have already counted some packets. This could result in an async packet being triggered with an unexpected data size. > >> +    writel_relaxed(val, drvdata->base + TPDA_SYNCR); >>   } >>   static int tpda_enable_port(struct tpda_drvdata *drvdata, int port) >> diff --git a/drivers/hwtracing/coresight/coresight-tpda.h b/drivers/ >> hwtracing/coresight/coresight-tpda.h >> index 8a075cfbc3cc..97e2729c15c9 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpda.h >> +++ b/drivers/hwtracing/coresight/coresight-tpda.h >> @@ -9,6 +9,7 @@ >>   #define TPDA_CR            (0x000) >>   #define TPDA_Pn_CR(n)        (0x004 + (n * 4)) >>   #define TPDA_FPID_CR        (0x084) >> +#define TPDA_SYNCR        (0x08C) >>   /* Cross trigger Global (all ports) flush request bit */ >>   #define TPDA_CR_FLREQ        BIT(0) >> @@ -38,6 +39,10 @@ >>   #define TPDA_Pn_CR_CMBSIZE        GENMASK(7, 6) >>   /* Aggregator port DSB data set element size bit */ >>   #define TPDA_Pn_CR_DSBSIZE        BIT(8) > > Newline to separate the defintions of different registers, please. will fix it. Thanks, Jie > >> +/* TPDA_SYNCR mode control bit */ >> +#define TPDA_SYNCR_MODE_CTRL        BIT(12) >> +/* TPDA_SYNCR counter mask */ >> +#define TPDA_SYNCR_COUNTER_MASK        GENMASK(11, 0) >>   #define TPDA_MAX_INPORTS    32 > > Suzuki > > >> >