From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752213AbcFNWJh (ORCPT ); Tue, 14 Jun 2016 18:09:37 -0400 Received: from mail-bn1bon0083.outbound.protection.outlook.com ([157.56.111.83]:63619 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751259AbcFNWJe (ORCPT ); Tue, 14 Jun 2016 18:09:34 -0400 X-Greylist: delayed 12832 seconds by postgrey-1.27 at vger.kernel.org; Tue, 14 Jun 2016 18:09:34 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH] KVM: SVM: compile out AVIC if !CONFIG_X86_LOCAL_APIC To: Paolo Bonzini References: <1465922420-53802-1-git-send-email-pbonzini@redhat.com> <573935ff-2310-b64f-d3c9-260a89de6752@amd.com> <29661011.22418691.1465939344668.JavaMail.zimbra@redhat.com> CC: , , From: Suravee Suthikulanit Message-ID: Date: Tue, 14 Jun 2016 17:09:26 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BLUPR0301CA0001.namprd03.prod.outlook.com (10.162.113.139) To BLUPR12MB0436.namprd12.prod.outlook.com (10.162.92.141) X-MS-Office365-Filtering-Correlation-Id: 3cdbcd68-cbcd-4b5d-7bbc-08d394a08f58 X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;2:kXcQmI9M2Tt2FW4rNKCEvTS+tnJ9vSyvJ5eeMJZ8ZUv6VbxYRIDX3Z0AbdSMou/RBP7JIO1+6CHYO0+orofddinfg525U8edcJTNArV37GxqkCvWUL+7165UVuWHZ/XaG8ukAT6cJ//CTir54Uu73RNTn1ISCePnpP8HJMIrbcovsJTdcb2JNaaajRA3/BwU;3:Fh9tu5XwrKiZ32EbG0qfk6Q6P7Spz4M/3c5ZGds95LFOrwBOf0hae2BqgnQwfOTPG0oKDVzVsfOXmsvC3lwDf8NkKR+NyJCHgHAKCop6gjQiUtBzjd1VhG7c7JSPdVz3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0436; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;25:/YlntZcLRC1hA+JdUzgwOXVuMGy68X74ejVb5bMEMa5RVYwXoZxEy+QT3ja6h5MKDtDjiT4/DQmx690eO5aNlMqjRBrupG/1CGxkL4irMEy0wakrxsqUZsRdfcRO/M7M3z7YEFSiDeFWNyry6AYLnrbm8lgiX4nhy9nlFvr2+h/oD14/c/JJIGxBVRoXawSbe0Yy/OBV0/93Se8Aioh+SPZUX2Ze17rHePI8IEOWCvDUaE3LZ7GHfEfRr1/d3M0v99KPpVYGUUqsASDGBTnPTBazZKo9yJD2GnZQxVFMdCcn5l66N5i17wcp7Wfz8GvZhJ/jwTE6KZNOpcLyELF0gw+BUuX7SVRZGA123cI0U3zEJqnEx1lVR+5rDc6DqVEzUHdube8U0TVJFOOo0s47AMUXizNGE0+nXMgetmXUtFSL9tryywKRa3i7KnrwFx27rLm6CfD3+PtRcKOKOiW8T8n34gc1tVGmeiTIKIn7gc9+plch1mPYO41Z/KzXz13EKumUpBKo4NNHpacpf6mwfvfGxp2I510jFNFPRp2FnVaEtirPZckKG9CtRaXuFmXTMvrCtzBKLRaY8IXUyXChwOwuz9lYbnI/mXJNOIPQVdYHhvW5zVun21f+qHh+4rceagjm/ZLRohuzSbsyBDK4QRm1DmTs5D2MfrCoEH8adQtfSUpk4y/H2mqDZnSWRgncfysInqyekboKV9Z4TZK2pEjARR1WInDLqYE0OX2Y87sUDiMDvEL3O0DY+V1MGJxR9By3IQxC1kqMc9bgKMA6vpn26rPFKZiiYidfPcpRkg5c+22yAEJ5QwBHv6Luvmzq X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;20:5cYWFRw4qE5vEWUjiyWWgiffBkgw9ClyaH4fBFfnI2u7T0YKhJjYuevTJJ9Y8Rm7ano3nr6fFz/wXosF0+7vAixpEcZ/TAmOUd40TP11Tj7uu9CGUM7Z7Pypz/XxMwFZESjgz6jhaKIymbvzg0vdC7NUXopqrAAKU14MfA45xcDSOZlmgdtw9IJhIbQezmRWnry+e6AjCQ6rW3uJ0d2vd9z0xXDLm3M0fGyOtD884Kf2/5DztLnajEOE+03FLuz6k4Dq3HMk5EEbQOLpCgb01xMH+Ee2Zk0fT6K5MmtTtbOveuSTZTofA9XvEV+BPooh8NmD5Ixh/yQWg+EN0vpreOjzFtOc2EHvmEdgqOb2uW2LTvPoiwSoF9JLQWDhqYsTpIwYIqhDwJnAKvgySYUz7QKRC8r8mRCxAv3J8u81DggUKNPucy1KDFsSOCNo9oBhxEhG6RFcWtpMtUKL0n/Hv6rqtqhGVf+aSaeplAVCxuc24y38JDSmuR/3u4cfdZNS X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:BLUPR12MB0436;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0436; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;4:Dsh7c10D1IR0hIdgNWrlW0eNtAazIyiTmasULPenoo7EdGvRMN58sWXaDbRxK4xajRMCwO+ASqsxmL10yU1DkV9iV+Wjbs813KoaJaEszLeGwCJcvifjE+yu0WdpRAYDqvsxhjLKxMzDscNsJIEWQ3wC/YyW8QfAbnhS8b/Xl8cW45sbUg4L7c0UhxR17uNZNJZPPWyfKTjQlU+IdY6RujDnFjNAS5wHOOpGVtKTbtCwH6nucZnwmiHdLXcFMoZlqnBf3Go3UQGq8IQcF5QnV5X+WWfOUJSUDG/pTUopCcrimnUZ4KfVFup3IgJ8LIe9+t1Poc1zlFQTi8Lb+eWfn0i2T/UcQ5Az/g/hPuC0yHN0zWPjHP2N28rZfwMEXDqKVZvpVY7+ukUZOBj+t2aEiE/IzHxlMkFWgB2HnXtD9N38b/qthAqObqHUjEBu4elPBToM0CW/V2tPDKYiPPhpKg== X-Forefront-PRVS: 09730BD177 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(189002)(199003)(13464003)(50084003)(24454002)(377454003)(2950100001)(189998001)(15975445007)(36756003)(77096005)(64126003)(5004730100002)(19580405001)(19580395003)(54356999)(76176999)(230700001)(23676002)(50986999)(97736004)(68736007)(4001350100001)(110136002)(92566002)(93886004)(101416001)(5008740100001)(81166006)(65806001)(31696002)(81156014)(8676002)(65956001)(66066001)(4326007)(50466002)(2906002)(105586002)(106356001)(47776003)(31686004)(33646002)(42186005)(86362001)(83506001)(586003)(3846002)(6116002)(65826006)(15760500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0436;H:[10.236.18.83];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;CAT:NONE;LANG:en;CAT:NONE; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjEyTUIwNDM2OzIzOkh0blNOUmNKMDQ2aWhjWHlNRnBPZTN3Tk5r?= =?utf-8?B?ekVvb1RhaHlXeHdJb2ZzdzAvODdoanpwMElHQUh0YXFLbFVuVjNuNzZ4ZHha?= =?utf-8?B?ZHJ1UXdEMzllakRFUTFZNVhmcW91RUJteWs3Q2hndVZFSmNheTdmaTBpSG1o?= =?utf-8?B?Z0h6TFArL0xTZy9BYjArMkpOcWgxOVJ5VklDU1VoVEE2NW9rUjZtQ1dDNC9k?= =?utf-8?B?L0RwSW1xZTlxYmtLamo0MDBlbG5tZHF4Und6RHluM0hXeGhzV3BHWUtFTFdz?= =?utf-8?B?SjNCekZUSFplUlJwRVE0dG9jbHV1RlhqdzIxU3U2anBFK0FXNVRhOVljT3FV?= =?utf-8?B?TDlKaXc1WGFNNlcxUkViakwvSG1ONVE2aWZpRHBlcG5xWDA0T1pLT1JReHJQ?= =?utf-8?B?Vkd2VDhNTHpZOFNhdFJtRG04cC9LOEpuOXdWQ0tRRDZFbFRqaE1DTVFzdFVU?= =?utf-8?B?WHFOZmM5TkwxVy9DZjdUWnNpb3NCMVFZZGlDZFRPdEZsREcxYlZSUUxHSVpM?= =?utf-8?B?QSsrNG1HNmw1Sk1oLzdIUzNkcFg4ZkJtT3Y3aTNXNWRBajBUVHIwT0Y3Wi81?= =?utf-8?B?bW5pN2dFbG5hR29QLzF3NW1leXVxYkxjd044K3ZlMzlud3Y1QmlMSTNpdHNI?= =?utf-8?B?eCtHVFk3VlhKL1dMSS9lZjVoUlhmVEY4YlBuMlZtcElmQmxxS1ByQTJCdE02?= =?utf-8?B?SHhsYTJaWmJWaHdZZmE0SjlUSzRRT1NlZ1NSR0s0WlZSYzJ2TkdGYUpvSUtY?= =?utf-8?B?c1l3NlpsUVR0dHpnSTFZZ01QRDF2V0VKWXAwSFZpd0VKSVJlb0N3Z21LWjhu?= =?utf-8?B?dmlaOTNyT1VRejdpQXB4b0I3Y1QzN0RXU0VVNlNKbHBWV2lONWZtREE4TytZ?= =?utf-8?B?d0c2aS9iMzZjSW1VOW5xeGExWFBCR2Q2VXhRVGM3SHV5cjhieVZwQ1l1V0xR?= =?utf-8?B?QUFSWVlZVlZzSmorTHV4TEhaQ2JSODJkTHlYNkVyUTZhbUUxeExDSlFCTkJy?= =?utf-8?B?N2tQSllLdW5MeDZ3cEEwVlByYm4vaVQrZzBiV3hVd3l3eGM2c21LbjhmNGxW?= =?utf-8?B?KytyenJKWjhFQjIydVd2UENrUHI5c0VnMVJxNW90UGp1TDA1MGR4MFRTVDdU?= =?utf-8?B?NWFmOWI0aFA1Z0VTVUovbW91L1NjTCtWQjA4REtUZzcwNWhhbXczeDNWWURz?= =?utf-8?B?MXhJZm9oL01SbmpFZVRWaC9JWFVNR3E3dytHalFSMG1IK05xVUY2SjQ4K3NK?= =?utf-8?B?bFkrbDlxMDN4UXZTVTJJYUIzSXV1MGIvZGZJeEsxeW14anEvWDRqc3Y2Q0Fn?= =?utf-8?B?WXg1ZnFEaXVIRUt5bGhHWjlpMnNxckJhbkI2dGZDcUVVVFZack5TcDZzMTVP?= =?utf-8?B?bmpGNm81cFhoY1BjNmpwSGhHaTNUOUlWemMvVjhoTThneE5QR0dqZUIxL3Jq?= =?utf-8?B?UG5weVQ5eExXbDdxZ1poWkFVRVpZeGVnUFRLcWoyZmIxMTgxV0FjOCsvZGZk?= =?utf-8?B?V1QyZWE2aHRZKzg4OE1kR20rd2srWjdza1pJcVlpUVZWOEpyNFdOMGd4N1di?= =?utf-8?B?Z3RnYlk2aCtBSmF3aHcybU54YkxQSXFhNkJPazhvd3hOaFRxTkFsdTlMNUpj?= =?utf-8?B?NGhYR0tUY1QvN25DYVZJb28zdFpkUG1nVk5tRXF0RklhMG4yL0x3OStNSGxN?= =?utf-8?B?OUFVQUM2Z0V1aG9BSkkzdFh6ZWFiYWJZWHdiMEVNS0VmNUdTakNyWlVzMFdK?= =?utf-8?B?NTVXVEo0TDFMQ0tWY0xndEVHaElDa2d4MlVZb1RIRDkzR2RVTUZmckxLQ2Zv?= =?utf-8?B?NzNqUEp0VG9qMWd3bWhNV01Edm8yT2tXOGZaUmRFSjArS1F6TnNJUk5qZTBq?= =?utf-8?Q?6A8c0N/WGuA=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;6:1zRZeSArmSLi8wiXmhE1YJnEwoBP3h1QBOhBFiziQNjO5mIkVd2y6lTHuAHgCZJXNblym/xr883XyB++X3VUaTJfj5yGwy7LOehLfIYpx3mfZ/dO/8q/O9a/hqtbRa/ZvKlzj6d2XSKMU3otZnbDbW9jvQCUFzbAIeM58jmFUSHt0ydvd0+2+/4+Qkka0M6WCSbrgsJL2WoRcrlQxuK9kuPoGDC+7LQITZuZsX/jvGOHKT1HDt8RKP2Ft7APLIys0vjIdsm6wOpkQgCzjz2uBChJOlm7iZGBtnvJtKF3lEyZM/zd0mt5IeqNczAxbLcb;5:xT3yiqmKDlYE84IYl0V2BRL4A5mE3IkfsDrBRPmOERdq9WsadM8sQw5k28vvUqTnuP3MoW3BKwNnpIft32nsaUboc4WvAZymSZwynWG55Xwd2chvNbKrkla+E5oUS/h2iaQBQfUi/b2HZPLXNPsZiA==;24:qdPUp2C9xE8fRVgjVkS2vRlgO4tgCXqew+itS6PnVU1sz5LVmzc9FYYWx2idhx1Jvxa6cETZ80ppjSI+NIZVPn0Y976hjqnzyJmXB5CRtnA=;7:sE0P0eyl7CzEY8O+hLXJJNPUY7vvZ562MCABl1YQaRjrRGjVUHTQc890UbNksD403l+inC54pq6uCen+cGqlR6QIzaazeItqDzqyFtNjiXpY+Om6amWj6istgwhrwaoNaYlEvZQW+hnth4UDgEj/h+BmJX0srU3LTNzEkBEotIB8eAKXY0nW2ZIeJz0p6O7cHMEgR8y5L2PZCcO3jKiBgg== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;20:62e5buhslKlD7o5NW3jGHGnOc+gxYLUmwR+ivanzNfjxZvbxL/weQ56F9ZgEXUpWmEWi4yGemXparauh1TEKPujLo5sIh8AcOMrh7vzV3j8kTvoQ6OvHXZzRt8hZdOm4okAT8SojgbCjnxagGx5j4h0xXxmtqCb4gzhi0NDhybeha46EQKLmrMvv+QPWdRaQHLRly6VZniRZfhcaxf62mbG0+t1uxJPMGxSdfoTlkwH/ZP7PclPViQp93RN0UnNB X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2016 22:09:30.6396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0436 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/14/2016 5:01 PM, Paolo Bonzini wrote: > > On 14/06/2016 23:44, Suravee Suthikulanit wrote: >> > On 6/14/2016 4:22 PM, Paolo Bonzini wrote: >>> >> ----- Original Message ----- >>>> >>> From: "Suravee Suthikulanit" >>>> >>> To: "Paolo Bonzini" , >>>> >>> linux-kernel@vger.kernel.org, kvm@vger.kernel.org >>>> >>> Cc: rkrcmar@redhat.com >>>> >>> Sent: Tuesday, June 14, 2016 8:20:30 PM >>>> >>> Subject: Re: [PATCH] KVM: SVM: compile out AVIC if >>>> >>> !CONFIG_X86_LOCAL_APIC >>>> >>> >>>> >>> Hi Paolo, >>>> >>> >>>> >>> On 6/14/2016 11:40 AM, Paolo Bonzini wrote: >>>>> >>>> AVIC needs __default_cpu_present_to_apicid. Stub out all functions >>>>> >>>> that use it, and disable the module parameter, if Linux is >>>>> >>>> compiled without local APIC support. >>>> >>> >>>> >>> I think you are right that we should disable AVIC #ifndef >>>> >>> CONFIG_X86_LOCAL_APIC. However, do you think we should just use >>>> >>> default_cpu_present_to_apicid() instead of the >>>> >>> __default_cpu_present_to_apicid()? >>> >> >>> >> I'm not sure why that would help? default_cpu_present_to_apicid >>> >> is also declared only if CONFIG_X86_LOCAL_APIC is defined. >> > >> > Actually, I also meant to include the change that I sent out >> > (https://lkml.org/lkml/2016/6/13/898), which declares a dummy for the >> > case #ifndef CONFIG_X86_LOCAL_APIC. That should help with the issue here. > I think it is by design that default_cpu_present_to_apicid() is absent. > > Perhaps you could create a kvm_cpu_get_apicid() function that is either > __default_cpu_present_to_apicid() or WARN_ON_ONCE(1)+return 0? > > Paolo Ok, I'll do that and send out V2. Thanks, Suravee