From: Claudiu Beznea <claudiu.beznea@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: geert+renesas@glider.be, linusw@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, magnus.damm@gmail.com,
claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH 9/9] arm64: dts: renesas: rzg3s-smarc-som: Enable I3C
Date: Tue, 26 May 2026 10:37:05 +0300 [thread overview]
Message-ID: <fb892151-33e5-4bb2-9a01-9abebe0f3b39@kernel.org> (raw)
In-Reply-To: <ahBMKWrKQDko3cG8@shikoro>
Hi, Wolfram,
On 5/22/26 15:29, Wolfram Sang wrote:
> The driver should
> know what to do, or? Am I missing something?
Could you please let me know what do you consider we should do here? Do you
think we could drop these pin controller setting and do some particular I3C
controller settings instead?
The documentation on the I3C_SET.STBN is limited. There are 2 places in the
manual (Rev 1.20) that references it, both in the pin controller chapter.
The 1st is the "Figure 45.13 I3C (I3C_SDA, I3C_SCL)".
The 2nd is I3C_SET register documentation where it states:
Control the standby mode of I3C Interface.
0b: Standby mode*1
1b: Normal mode (Initial value)
With the note 1 being:
The output is fixed at Hi-Z and no data is transmitted to the inside even if
data is input from outside. “Standby mode” is available when using I2C mode
only. (Not available when using I3C mode).
The current driver proposal don't take into account the IP mode when setting
STBN though pinctrl_pm_select_sleep_state()/pinctrl_pm_select_default_state() to
keep the code simpler, relying on the "Not available when using I3C mode" part
of the note, and considering setting it when the IP is in I3C mode is harmless.
--
Thank you,
Claudiu
next prev parent reply other threads:[~2026-05-26 7:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 10:22 [PATCH 0/9] pinctrl: renesas: rzg2l: Add support for RZ/G3S I3C Claudiu Beznea
2026-05-22 10:22 ` [PATCH 1/9] pinctrl: renesas: rzg2l: Generalize the power source code Claudiu Beznea
2026-05-22 10:22 ` [PATCH 2/9] pinctrl: renesas: rzg2l: Drop defines present in struct rzg2l_hwcfg Claudiu Beznea
2026-05-22 10:22 ` [PATCH 3/9] pinctrl: renesas: rzg2l: Keep member documentation aligned Claudiu Beznea
2026-05-27 9:35 ` Geert Uytterhoeven
2026-05-22 10:22 ` [PATCH 4/9] pinctrl: renesas: rzg2l: Use tab instead of spaces Claudiu Beznea
2026-05-27 9:36 ` Geert Uytterhoeven
2026-05-22 10:22 ` [PATCH 5/9] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Document the missing I3C power source option Claudiu Beznea
2026-05-22 16:11 ` Conor Dooley
2026-05-22 10:22 ` [PATCH 6/9] pinctrl: renesas: rzg2l: Add RZ/G3S support for selecting the I3C power source Claudiu Beznea
2026-05-22 10:22 ` [PATCH 7/9] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Document the I3C standby property Claudiu Beznea
2026-05-22 12:30 ` Wolfram Sang
2026-05-22 10:22 ` [PATCH 8/9] pinctrl: renesas: rzg2l: Add RZ/G3S support for selecting the I3C standby state Claudiu Beznea
2026-05-22 10:22 ` [PATCH 9/9] arm64: dts: renesas: rzg3s-smarc-som: Enable I3C Claudiu Beznea
2026-05-22 12:29 ` Wolfram Sang
2026-05-22 13:01 ` Claudiu Beznea
2026-05-26 7:37 ` Claudiu Beznea [this message]
2026-05-26 10:00 ` Wolfram Sang
2026-05-26 16:55 ` Wolfram Sang
2026-05-27 9:06 ` Claudiu Beznea
2026-06-04 11:12 ` Claudiu Beznea
2026-06-04 20:17 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb892151-33e5-4bb2-9a01-9abebe0f3b39@kernel.org \
--to=claudiu.beznea@kernel.org \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome