From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E32C43441 for ; Wed, 21 Nov 2018 11:44:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F22BC20831 for ; Wed, 21 Nov 2018 11:44:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="WxXd8DVz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F22BC20831 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729619AbeKUWSo (ORCPT ); Wed, 21 Nov 2018 17:18:44 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:37614 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727343AbeKUWSo (ORCPT ); Wed, 21 Nov 2018 17:18:44 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id wALBiXxW085690; Wed, 21 Nov 2018 05:44:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1542800673; bh=x8AU36GTfmn+vDleLYsI4KzAlV1Sm4nGY6ajUuvijuo=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=WxXd8DVzOpTfNWfxzUsJQbCUHDfSXSgnWrzwNsfOIRWRblwCmi+VEK8qDqA2iKeDK ZtcJURU5gG2va/1hxC0vAj1ShlOHXgQOkveMEnB/XxmJCahKBSX1655PlCpr2iBknS gh3mcYj1FuCWCKgDlmGvh94oRAskp1hYrGHNzhIs= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wALBiXNu056393 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 21 Nov 2018 05:44:33 -0600 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Wed, 21 Nov 2018 05:44:32 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Wed, 21 Nov 2018 05:44:33 -0600 Received: from [172.24.190.215] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id wALBiTQu008910; Wed, 21 Nov 2018 05:44:30 -0600 Subject: Re: [PATCH v2 0/3] Add support for using external dma in SDHCI To: Chunyan Zhang , Ulf Hansson , Adrian Hunter CC: , , Arnd Bergmann , Mark Brown , Kishon Vijay Abraham I , Sekhar Nori , Chunyan Zhang References: <1542007566-9449-1-git-send-email-zhang.chunyan@linaro.org> From: Faiz Abbas Message-ID: Date: Wed, 21 Nov 2018 17:17:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1542007566-9449-1-git-send-email-zhang.chunyan@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chunyan, On 12/11/18 12:56 PM, Chunyan Zhang wrote: > Currently the generic SDHCI code in the Linux kernel supports the SD > standard DMA integrated into the host controller but does not have any > support for external DMA controllers implemented using dmaengine meaning > that custom code is needed for any systems that use a generic DMA > controller with SDHCI which in practice means any SDHCI controller that > doesn't have an integrated DMA controller so we should have this as a > generic feature. > > There are already a number of controller specific drivers that have dmaengine > code, and some could use sdhci.c actually, but needed to implement mmc_ops->request() > in their specific driver for sending command with external dma using dmaengine > framework, with this patchset, them will take advantage of the generic support. > TI's omap controller is the case as an example. > > Any comments are very appreciated. > This is great. It helps us move am335x and am43xx platforms to sdhci-omap. What platforms have you tested this on? Thanks, Faiz