From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 867D34DBD6D for ; Thu, 23 Jul 2026 13:37:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784813841; cv=none; b=QaYHdly54AJYzLIvc6gj97G57mwPOJu5xNkA+JU6jG0lB5KiHrztj2R/pRTepTYYXT+v78wJrp7B7+bIC3WjpAfBbXrlgwzu7590u4JWNlo+0jK+TBCTs5XMXvkw3RyU6OxZyjzDjd008eQ7wKqpMlfXR5IwV2Z5H/lqNnp8P3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784813841; c=relaxed/simple; bh=cX5RyP25LLZ1Jg13iKUkAoxbJ9vy0x/xpbeWmaWKPPY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VD1l2tu8C/NYtPD8doMFTxGljLQVlN9MNOlW1j6DDAFX1VYfitJPZ0+XS5M5/s5wQ0AIHgU+Q6et6MUr+Ni4kHeJ8QZH3H/pGCJpQI1Fx03YTjeimh4qV15xql+D4Dqbb2lhlYgi9jubuSbS+2hRHh4/hmgtfxZ5sdut7n/9rUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SRGYiamr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cdybesjm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SRGYiamr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cdybesjm" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66NCvYj03954489 for ; Thu, 23 Jul 2026 13:37:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gHslaQdrIxXhoR6CTG+3KawG4L5eFPme/pRlS9V9GnI=; b=SRGYiamrXt0hgCk+ WNnhRI8ZmDZgtZWVqW1gXz7GYyfDCE+Bwv0tbm94DH9CenByUSzUOayLRpZPEByi ObtqjIBg+Fu3WMkfH9hGp/12ej9FnHHk6rLTwHpn/Qbk2afuBbsKCsb46Ufqs9GV nNZgYZxcGHmZdOWD29oxeLnjVl2GV17+ivdpU1RqCKUdP6t1H9ZOZ2ZPl6QsvdOx 3j8kW/6hckJUjTegwZ90PGymHVM207khRlCOcFcNgQ3CBR6ePJpeeNtscXxIjT8r bfPedFnEKprcj0f+eb/Z/HWS3P/7KK2RVvy+IPCsxDr4sHZoNWB6LjFWL7pFir/s MTqFIw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fke0ksky8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 13:37:10 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-930a312222dso13193785a.2 for ; Thu, 23 Jul 2026 06:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784813830; x=1785418630; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gHslaQdrIxXhoR6CTG+3KawG4L5eFPme/pRlS9V9GnI=; b=cdybesjmOignIavR+if/HB41IMZVrYiCnY8YeIkNUcNk3Z9TkNAJtlRVYSxU8HkhPy 3j0v0z6fEgVGifrpPQzTu+ZCSNgARgiS7whZvkDN2AftVkssoSWELnvPLvEVI7x82c8i /EoBA0ia2S376UkHeZKtIy34vzZ4/oM9avYVXQarIFgScFg/H/v9dNuEvVaibZBBF7gy asMNt6cPOXM//80mSFZULzfjOQgfYybvcjT5WSvzsQIs/hyjIzC+zAxnEMc0HHi0I8Qb kEFiuuJrsPhEa/r4FBAomMDOu9dTQvFdTRbMIBsRUkpG80v0aVIg16E1HGcQEmDvjY5r k3qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784813830; x=1785418630; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gHslaQdrIxXhoR6CTG+3KawG4L5eFPme/pRlS9V9GnI=; b=XxnxBwDxztHB3/uPjLStOUAb05vFn4g/Vhx0BBbfGmdMqCa1rweUWu0ZNeUBs2p91w PzIqwHzXzEI0CvfttT1MP3yz+cuOfeev8hRwYx2zpcvqenv88DSV3mmUkPW2ZwPrMgDW qwYsF5sTWCFs+slFIvtFDtnYJNl7CVcPxaZzYmD7p4tbYUG+kJxi+euYsO115Np5lHp7 48tHsQmstPDVEiLdIJOdJOkvA9oX8RZwYQfU5y6aV8PPfr1QtkIhfdLaZjKy7JHpVCIT veqZnuJfw7/DJvsxw8/h0PTFzOHQSWZyRYUqisHYqt/bZIGd79KQFVNM3m9lDkB9QNr+ j3rA== X-Forwarded-Encrypted: i=1; AHgh+RroayZKTQtyZYv6NKLEJ7buhZSz6KW48ul2QcxCDZUrTeg3TBNUxavo+JxfA6uodE8iMA67BvmBfQ90IUs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5pkJYoXkUyl9VD0qAvDmeXTjZgWVWdxywMWptRa15CagTKDJJ 6x/k89z607nf0oPh32PPRsDylhFjxnbP86zLphAmmpfssRllqZfXZO9wq6Qf9xTCiW8srx6r5Vi BB+ZzY3zzxYFq6oYVZIF4oq0fesKhkp1Muz+PIINg5uuYX/IOJ/bOJV6DiXADXsAaqDuPytjxVM E= X-Gm-Gg: AR+sD12FtiF9wZoj7DwS0bYV3RoQ7Y8I7xfjC3IdjZwGyOxsApFsy39hbSiKQCsheCe lVbl2NrggW1FYl9yP9h2t1RN/QzVSNYYjFB5GxEIkCJCRquBEZMtTB4anh/u/WL3Ii2tuGuRjJr tXae1xKma8eLS9uNfXlqaIrpEsg25B4cXJg62+SnCbcTIP8wNkHQDWy9DHrVrUuH1KSiPXoo8Fs BlWieqaW8Om/N0drzRtCozcn0++gKJSWUGX8qIdbCvryLrRPqJmW9+es2oKThKdL1XCDBfhu88Q eS3E5tLyGroAiG+orQkKG5DVdHPmJM034AtMuM34lUEPh8YLJDwKt0JJuybG4kpEqNmAGvAsKri cHXi4GYyDH6OzrcWwL+h0SIrn X-Received: by 2002:ac8:5a4b:0:b0:51a:d45e:638d with SMTP id d75a77b69052e-5284750cb61mr5096741cf.8.1784813829666; Thu, 23 Jul 2026 06:37:09 -0700 (PDT) X-Received: by 2002:ac8:5a4b:0:b0:51a:d45e:638d with SMTP id d75a77b69052e-5284750cb61mr5096461cf.8.1784813829187; Thu, 23 Jul 2026 06:37:09 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1c32f19c4csm231706066b.63.2026.07.23.06.37.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 06:37:08 -0700 (PDT) Message-ID: Date: Thu, 23 Jul 2026 15:37:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] dmaengine: qcom: bam_dma: SCM-assign descriptor FIFOs to a remote VMID To: Vishnu Santhosh , Vinod Koul , Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, chris.lew@oss.qualcomm.com, Deepak Kumar Singh References: <20260714-qcom-bam-dma-vmid-ext-v1-0-cef87c57b7dc@oss.qualcomm.com> <20260714-qcom-bam-dma-vmid-ext-v1-2-cef87c57b7dc@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260714-qcom-bam-dma-vmid-ext-v1-2-cef87c57b7dc@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: VKiPLchoOBb7tvj6weMODLgnpvRGyz2s X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDEzNCBTYWx0ZWRfX1qrlQnWYZd0M 4BPSfuHRcnZsuu4wD22MTvOsHsSHkHQuVAjnhSO8E1z4aTyILz4dOi5mQ8+sCY8ZqCP93TI88LZ 6gCMiUJS1BTo1Ep/9NVW+D5VEOyEvxE= X-Authority-Analysis: v=2.4 cv=S7DpBosP c=1 sm=1 tr=0 ts=6a621906 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=jWf9ImQ_av2cyXA2soUA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: VKiPLchoOBb7tvj6weMODLgnpvRGyz2s X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDEzNCBTYWx0ZWRfX2+uEodwDqrWD AdeQ+TDMvPkmCPrASgc08mTKbMPQ/2Ck1VDCKFnvEUilJYCd9h9JdYr7iC9oFuGFsfEplqbgtcJ yBnsDVG+nBmWqX5Lxt1GLVLzXwNd5oDL+c/nnUNCyspPJ0FKnn+NhF+dMPoJnL0KCMzzN+0LsrK Zhf64qkWwM0XBXbv1LZ33hSF4C4T7HWNAtwPdk7FC0JJWBa+c4pvBHx+d8k33fQO+HJS9AaP0HW uPUFMk/1/CBUqTM6xanv1k+w4q0y369NCp3GnRRCpl8QfOy1yRF8MHMTC5YyTF8bNdO8OXU63CG Y10lkKl0Qlfo/fc4YBl+c+TwUM+2Fch3fqektQVEWKj4e47mqaJlMyj3uxzuBUsRPizf/Pkhqzh p/51FatuBJO5tMnjeNbRkyqxFMKxKzhXka9yvSQI9Iwwhw36kPrV/GVp4LTDX1ioemZ6pwfJ+4p 66MbHBinsKh7kbACwPg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_04,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 bulkscore=0 priorityscore=1501 adultscore=0 impostorscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230134 On 7/14/26 7:00 AM, Vishnu Santhosh wrote: > On Qualcomm SoCs where the BAM is powered by a remote processor that > enforces XPU access control (e.g. the mDSP on Shikra, VMID 43 / NAV), > the BAM reads the descriptor FIFO as an AXI master under the remote > execution environment. Without an SCM grant for the remote VMID, the > first descriptor enqueue faults with an XPU violation. [...] > + ret = of_property_read_u32_array(dev->of_node, "qcom,vmid", > + bdev->vmids, n); > + if (ret) > + return ret; > + > + for (i = 0; i < n; i++) { > + if (bdev->vmids[i] == QCOM_SCM_VMID_HLOS) { > + dev_err(dev, "qcom,vmid must not include HLOS (%u)\n", > + QCOM_SCM_VMID_HLOS); > + return -EINVAL; > + } > + } Please switch to device_property_ instead [...] > +static int bam_assign_fifo(struct bam_device *bdev, struct bam_chan *bchan) > +{ > + struct qcom_scm_vmperm *dst __free(kfree) = NULL; > + u64 src = BIT_ULL(QCOM_SCM_VMID_HLOS); > + int i, ret; > + > + if (!bdev->num_vmids) > + return 0; > + > + dst = kcalloc(bdev->num_vmids + 1, sizeof(*dst), GFP_KERNEL); > + if (!dst) > + return -ENOMEM; Please reshuffle this to follow 7c4c14ad3d8c ("tee: qcomtee: mem: Fix confusing cleanup.h syntax") Konrad