From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91627C433F5 for ; Fri, 11 Feb 2022 08:55:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348329AbiBKIzF (ORCPT ); Fri, 11 Feb 2022 03:55:05 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:44420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234120AbiBKIzC (ORCPT ); Fri, 11 Feb 2022 03:55:02 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 313F7E6C for ; Fri, 11 Feb 2022 00:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644569700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WAVrdasKBTmSKo6xAnwq3AFAS48lB2tsIo4HhkkN4rE=; b=d5Rl/rvYu174IcQ/yFA8kORot3DGkMvom9aqjLeEdKnKOLWztlCbDq7sRii6DzqDJhob12 wmNb6B3Zaxs3tsaCd5wbOAS2rG6DyYSyque1by+0aVRS8vvwN3h9Nx3e3quMxMhGvo57zZ 3ro0ORX2mmQHb9d4FsJQx8cngVAMfgU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-647-UmWA5vx5M3yaV81L3jrP5A-1; Fri, 11 Feb 2022 03:54:59 -0500 X-MC-Unique: UmWA5vx5M3yaV81L3jrP5A-1 Received: by mail-wm1-f70.google.com with SMTP id p24-20020a05600c1d9800b0037be98d03a1so5018480wms.0 for ; Fri, 11 Feb 2022 00:54:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=WAVrdasKBTmSKo6xAnwq3AFAS48lB2tsIo4HhkkN4rE=; b=qE+QLWuhWdC4qG/fPNcwwTLVMqEiSTD6c3XpHxJe/MUOlz805IVfLKh5LxCV+CFUNj evCxKaPP3zPjwdsLno/6sPDD8Tktp12Qtbh4PPaU7kHk+2dWk1x9ohnhSSmbcHKsYeRY SIcfPiD2PtYtoIvi/dbNjHoTlizjwEqE6NFP7PYjyvXypbI44N4W0VtN+AZkKPXkNoAy uI5R0b8kc12/W6Ec9Qy3kCh4V/57IoZRwmlok0JkjRk5peayqffVnoqfx6X/vqElBtNk McC4HPdAqdu6Cj5KTGJApJI9nFC7hMqHgRXfQCmI7r387SIPrytmozKZTVsfM5PMZrQr G+Aw== X-Gm-Message-State: AOAM532JVKmXPZHv2p6EW2MaxlNGWTVOG9o+RTVviRgHO3SbZ8bPK2gg UX/IiE2i3S5nISEwyRMbRBzJhs0UeNs8oiUCBLL5By2oimLSpkFsFgMKXLDIRiAWw41/S7t9cH2 rSYX/ciGnqq8kzo+PVt+vd1Is X-Received: by 2002:a5d:6382:: with SMTP id p2mr510789wru.548.1644569697670; Fri, 11 Feb 2022 00:54:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJz7iG18nW2Fpgx5sq0P74kkf/bt73zc9m6iHNReHupDFVdcYSZKzYxuRDWV0Zwtdy4ny1OKIg== X-Received: by 2002:a5d:6382:: with SMTP id p2mr510770wru.548.1644569697477; Fri, 11 Feb 2022 00:54:57 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id p2sm3454359wmc.33.2022.02.11.00.54.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Feb 2022 00:54:56 -0800 (PST) Message-ID: Date: Fri, 11 Feb 2022 09:54:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 3/7] drm: Add driver for Solomon SSD130X OLED displays Content-Language: en-US From: Javier Martinez Canillas To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Thomas Zimmermann , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Maxime Ripard , Geert Uytterhoeven , linux-fbdev@vger.kernel.org, Daniel Vetter , Sam Ravnborg , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Lee Jones , Liam Girdwood , Maarten Lankhorst , Mark Brown , Maxime Ripard , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-pwm@vger.kernel.org References: <20220209090314.2511959-1-javierm@redhat.com> <20220209090314.2511959-4-javierm@redhat.com> <406152d8-13e4-de8a-9542-bf1d96dbab0a@redhat.com> In-Reply-To: <406152d8-13e4-de8a-9542-bf1d96dbab0a@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/9/22 17:26, Javier Martinez Canillas wrote: > On 2/9/22 17:08, Andy Shevchenko wrote: > > [snip] > >>> Agreed, as mentioned I'll give it a try to sending all the data as a >>> bulk write with regmap. >> >> Ah, it might be that it should be noinc bulk op. Need to be checked anyway. >> > > Yeah, I'll give it a try for v4. Let's see how it goes. > I tried to do bulk writes for the command, but the problem is that the command stream has to be as follow (i.e: SSD130X_SET_COL_RANGE command): SSD130X_COMMAND SSD130X_SET_COL_RANGE SSD130X_COMMAND col_start SSD130X_COMMAND col_end That is, a SSD130X_COMMAND has to be writtn for each command and command option. This means that you need to either construct a command stream in the ssd130x_write_cmd() function or pass multiple SSD130X_COMMAND as variadic arguments. Both cases lead to a less elegant implementation than just having a count parameter in ssd130x_write_cmd() and doing multiple writes as it is done in the current implementation. After all, these are only for commands that are done once to setup the device. The SSD130X_DATA writes that are to update the display pixels are already done in bulk, which are more important to do it efficiently. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat