From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
lukasz.luba@arm.com, rafael@kernel.org
Subject: Re: [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system
Date: Thu, 1 Apr 2021 09:01:09 +0200 [thread overview]
Message-ID: <fb8d7551-b8b8-22fc-63ad-768adb14b3e1@linaro.org> (raw)
In-Reply-To: <YGVh9onNL7hVu2mr@kroah.com>
On 01/04/2021 08:02, Greg KH wrote:
> On Wed, Mar 31, 2021 at 10:46:48PM +0200, Daniel Lezcano wrote:
>>
>> Hi Greg,
>>
>> On 31/03/2021 20:06, Greg KH wrote:
>>> On Wed, Mar 31, 2021 at 01:00:45PM +0200, Daniel Lezcano wrote:
>>>> +struct dtpm *dtpm_lookup(const char *name);
>>>> +
>>>> +int dtpm_add(const char *name, struct dtpm *dtpm);
>>>> +
>>>> +void dtpm_del(const char *name);
>>>
>>> You can not add new kernel apis that have no user. How do you know if
>>> they actually work or not? We have no idea as we do not see anyone
>>> using them :(
>>>
>>> So no need to add things with no user, feel free to just drop this patch
>>> until you have one.
>>
>> I've sent a couple of patches [1] on top of the previous series. I'm
>> finishing to respin it against this new one.
>>
>> -- Daniel
>>
>> [1] https://lkml.org/lkml/2021/3/12/1514
>
> Please use lore.kernel.org, we do not control lkml and it has been down
> in the past and it's impossible to reply from.
>
> Please always provide a user of a function in the patch series,
> otherwise you will end up with comments like mine above.
Ok, will do.
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2021-04-01 7:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 11:00 [PATCH v5 1/5] powercap/drivers/dtpm: Encapsulate even more the code Daniel Lezcano
2021-03-31 11:00 ` [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system Daniel Lezcano
2021-03-31 18:04 ` Greg KH
2021-03-31 18:06 ` Greg KH
2021-03-31 20:46 ` Daniel Lezcano
2021-04-01 6:02 ` Greg KH
2021-04-01 7:01 ` Daniel Lezcano [this message]
2021-03-31 11:00 ` [PATCH v5 3/5] powercap/drivers/dtpm: Simplify the dtpm table Daniel Lezcano
2021-03-31 11:00 ` [PATCH v5 4/5] powercap/drivers/dtpm: Use container_of instead of a private data field Daniel Lezcano
2021-03-31 11:00 ` [PATCH v5 5/5] powercap/drivers/dtpm: Scale the power with the load Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb8d7551-b8b8-22fc-63ad-768adb14b3e1@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®