From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE895CCA47A for ; Thu, 16 Jun 2022 15:03:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377753AbiFPPDO (ORCPT ); Thu, 16 Jun 2022 11:03:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236304AbiFPPDL (ORCPT ); Thu, 16 Jun 2022 11:03:11 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82686B4A1; Thu, 16 Jun 2022 08:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=eXP8JImYusYVmz1XFgz6F/idOIpZUqokxeO9uXWtnWI=; b=KRUEUBUyuLXtfTp3+c4njGOSw9 vEDot6VYfqIJ01TjLkccAS9FePTHekgVapd/ZzYWPmXEXA+RSFIUCXgcE4i50W6m4fCnG86csGQyX 2fPfw/RqUdF4HEmx4JlxDoLwTB0EWagiVnntZpQaqWknDkJxM4E1QP0tjaadRQit0B1awN3dL+OZu ZsZePFuAxZdy2RY5zt1kIpOlK2HQCMVQRqiaBTPCUQZRHL01dW8Ib9Xq+0BcfW1mwxgzWyFa88QqN FSAPYfcU9mx5op4/SWDy3jKI0BU4lwAqlSxpSWdiQOCvm8mzCemKd14GlH1PVzlSGikdp93WSV3Ok ZbnXZCJA==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1r0x-008RS8-4P; Thu, 16 Jun 2022 15:02:32 +0000 Message-ID: Date: Thu, 16 Jun 2022 08:02:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v8 1/3] ipmi: ssif_bmc: Add SSIF BMC driver Content-Language: en-US To: Quan Nguyen , Corey Minyard , Rob Herring , Krzysztof Kozlowski , Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Andrew Jeffery , Wolfram Sang , openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Cc: Open Source Submission , Phong Vo , "Thang Q . Nguyen" References: <20220615090259.1121405-1-quan@os.amperecomputing.com> <20220615090259.1121405-2-quan@os.amperecomputing.com> <8b7841a9-9313-b1d5-8a80-a65cfa8e7b4d@infradead.org> <74f94464-a095-f539-746a-853b8f1d52ca@os.amperecomputing.com> From: Randy Dunlap In-Reply-To: <74f94464-a095-f539-746a-853b8f1d52ca@os.amperecomputing.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/16/22 00:25, Quan Nguyen wrote: > On 15/06/2022 23:06, Randy Dunlap wrote: >> >> >> On 6/15/22 02:02, Quan Nguyen wrote: >>> diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig >>> index b061e6b513ed..18a89093d64e 100644 >>> --- a/drivers/char/ipmi/Kconfig >>> +++ b/drivers/char/ipmi/Kconfig >>> @@ -169,6 +169,17 @@ config ASPEED_BT_IPMI_BMC >>>         found on Aspeed SOCs (AST2400 and AST2500). The driver >>>         implements the BMC side of the BT interface. >>>   +config SSIF_IPMI_BMC >>> +    tristate "SSIF IPMI BMC driver" >>> +    select I2C >> >> No. That should be: >>     depends on I2C >> >> We don't select an entire subsystem just to satisfy one driver. >> >>> +    select I2C_SLAVE >>> +    help >>> +      This enables the IPMI SMBus system interface (SSIF) at the >>> +      management (BMC) side. >>> + >>> +      The driver implements the BMC side of the SMBus system >>> +      interface (SSIF). >>> + >> >> Thanks. > > Thanks Randy, > it should be change to "depends on I2C && I2C_SLAVE" Either way is OK for I2C_SLAVE AFAIK. thanks. -- ~Randy