From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com [209.85.221.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A6781D5AD4 for ; Thu, 4 Dec 2025 00:43:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764809030; cv=none; b=OvaFgiZpOpzU48PL5daaMYjvIxqsRjfyatg0MXpg+86qQH6yUhkU0aiDDlMKpZIVrHXVJDKDnzZnRbOYpYj3ewvF0TP0eUN7dP/s2yUr1/+TYwu5hV+zMKG9kmpTMhprpwONNL3C/FvObkHAH/ARzkWtbfsINgrSWfRyLY83A7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764809030; c=relaxed/simple; bh=7C4m9y22CDhJly1Sa/M8ZgDQxAAaoOub7TsjprrN6mo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Znaiuo8IToqYLLbR8VYzSJcM4jCV1RZovrBDdrGR9xiHLp5oCtLioD0aQCdSeQWcJO0lWCMdKOmim+vbflMQQlIg/CFJJPdJM6nZrfhqdKmKs4gxljLb04nDPv3SB9+l+GdhBbDi+dFYE/M5pBNTvJYJbVewHAr8dB0wR0GuWY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Be9HZ9My; arc=none smtp.client-ip=209.85.221.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Be9HZ9My" Received: by mail-vk1-f176.google.com with SMTP id 71dfb90a1353d-559934e34bcso111787e0c.1 for ; Wed, 03 Dec 2025 16:43:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764809028; x=1765413828; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=61Fg0qope6bIFTvBwF2PK7eB2MmgYw/t+V2Q9FitbBc=; b=Be9HZ9MySgglRr1HWmtn8CGu2d4yljbZQSPUKCsu1OuQw6pADH7M2WljWvuEsedf0D tgB7owH6xe7PokSA2280G5mGw3qRFS9ZL2boQSXHIBb9L3bsLRoJjDWYqF6y2dlHaDbA 6epo5xUSdSNNjxcTffT+V2eThTJAyUYze7AeMyRzZSYkvZ9oXafqggq/mmNdRAuleF5B x9f1sucaSYLHvti4SN6/OYRd/dvA3dwjp+ltUkzfgiSbJM3773ro5CQDg/6Z01EvCzad CNjVrW0ppgRXCkTOlTcjQyqdJZXQce4sOU2JokH0x4yDURJS39b7FQZnrOrf6FRffYKH y82g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764809028; x=1765413828; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=61Fg0qope6bIFTvBwF2PK7eB2MmgYw/t+V2Q9FitbBc=; b=lpuGHcxHTqZ3lAnht+J5cg4QL6+UpLv0LLpthqSwVUZ5b0AMls2GfHgWLqxXnxd2mq wqT/AappmUnxdTurewV7qXFlk6Qmd0XOhc3vd7kKzhEvyvVbYW+y3z4wivnN+RpKVw8p o2OsWIBNET5zIE4TASyaBgI4v1797qTZxczdhb16mB+aXiypY/sPW33zjeO0jgSMX3tw diyVWsPcEWIJ3OIfjciez5jvHpJStDb3WT9A/5J0j91iDu++ll1B+SphTwRvfgaZVjw6 Qnm1MrtqsZ56C7SSXtRY2uDdOW8SIh2ERi1U4aDNCXYxL5UQGt/6n0/pPiiuf7OvhoHr oKzA== X-Forwarded-Encrypted: i=1; AJvYcCXk0EaAt2k9S40+77KdpGJPXH9OiseJM2KRRQei4v/Rk+nW7Eh8bSnO0gPUrBJ/a9xt7SXxwBi/bgR80Rw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6Wql11QPYfEB17WD6slcL7LAwOJw7wUmvd939CLug4+yJzaAT N30VPnU3sUMx4hAiAzh9wVID/2KKvBILYf8g64l7GVTrUocK8dmAVLP8 X-Gm-Gg: ASbGncsHduCY14JSmuv/h4Y1fuspprAWgsZ5Yve/TZETUcU0m4XBVK1lDR9VSijh4F7 gDj/q78Qvci5zGmKHAcLewbE+kdrCy3yAa5EL175TQVB2HF57gh2SgC2xTP55z4o3bnAAMajEac cw6fckLNaRtUNeb/A75Z79F//VS1Qjy79/2ON1hQwSiCianJ+tynyw44T+I0+gqw5BIYVo3038b Idg+XkmP6aWrhLOhmty8M4l64TXYC7+1Ub3ZDsP7JQ5KQYekUH/O1uQFWBfvC+3kxi14tQ+b4bF UkiV8O0D3fYPIJroGWHTFbMhg12Gbn4qFHZwXQyBQ7UzqouEXHOeOVB6BHBTPjWachZ5Ac8UQaK uKt5c/GUtspspjF3fQMjs23Ny0YOaXFTWEcDDqW//VanSLGQeVuydcrTBrkW3nmmwE6ldPem/N6 WL6T+Znr/kZBNBJJK5sgxIIPW15EDY X-Google-Smtp-Source: AGHT+IGsuatuhKh4iVq8o2lXvbj9+Qg260ROC3Yx+Y7OG23faK6RtOzwe4m6qVvfmSN3u8YYtNXYFg== X-Received: by 2002:a05:6122:8c7:b0:55b:aab:95e8 with SMTP id 71dfb90a1353d-55e69d8b1e4mr240706e0c.9.1764809028159; Wed, 03 Dec 2025 16:43:48 -0800 (PST) Received: from [172.16.226.146] ([98.254.184.207]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-55e6c56853esm77504e0c.1.2025.12.03.16.43.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 16:43:47 -0800 (PST) Message-ID: Date: Wed, 3 Dec 2025 19:43:44 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/6] usb: gadget: dummy_hcd: coding style improvements To: Clint George , stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, khalid@kernel.org References: <20251119130840.14309-1-clintbgeorge@gmail.com> <20251201203715.17768-1-clintbgeorge@gmail.com> Content-Language: en-US From: David Hunter In-Reply-To: <20251201203715.17768-1-clintbgeorge@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/1/25 15:37, Clint George wrote: > This patch series focuses on addressing various coding style issues in > the dummy_hcd USB gadget driver. The changes includes adding relevant > comments, improving readability, and ensuring consistency with kernel > coding conventions. > > Clint George (6): > usb: gadget: dummy_hcd: replace symbolic permissions (S_IRUGO) with octal (0444) > usb: gadget: dummy_hcd: use 'unsigned int' instead of bare 'unsigned' > usb: gadget: dummy_hcd: document ISO endpoint allocation pattern > usb: gadget: dummy_hcd: use sizeof(*ptr) instead of sizeof *ptr > usb: gadget: dummy_hcd: remove unnecessary parentheses > usb: gadget: dummy_hcd: move function braces > > drivers/usb/gadget/udc/dummy_hcd.c | 52 ++++++++++++------------------ > 1 file changed, 21 insertions(+), 31 deletions(-) > > --- > > Testing: > - Ran compiler testing with no new warnings detected. > - Ensured the module builds and inserts cleanly without issues. > - Used Static Analysis tools to confirm no new issues were introduced. > > Please review the changes and let me know if any modifications > or further testing of the module is required. > > As part of my LKMP mentorship i have to complete 5 patches as a criteria > for graduation and thus have focused on working on such > beginner-friendly patches so that not only do i get the required number > of patches but also get familiar with the process of kernel > developement. Thus, while this patch series doesn't address the max_stream value > exceeding problem that triggers the BUG() API, i will take some time to > dig deeper and truly understand the problem and fix it and not just > paper-over the problem. > > Again, i am very grateful for your feedback greg and alan to guide a > beginner like me. > > Thanks, > Clint > Hey Clint, In general, when submitting version 2 of a patch series, most maintainers will prefer that you send it as a new patch series and not as a reply. I usually recommend putting the links to the respective previous versions in the change log. Thanks, David Hunter