mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: enh <enh@google.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_status_is_good() uses __KERNEL__ constants.
Date: Mon, 16 Oct 2023 13:48:46 -0700	[thread overview]
Message-ID: <fb983fa3-bf4d-42aa-b5c3-4927504c32d9@acm.org> (raw)
In-Reply-To: <CAJgzZorfiG26TCfwNBVYJkkkVBAQowJhRUtX4EzWSxwZbfNoyw@mail.gmail.com>

On 10/16/23 13:42, enh wrote:
> Without this missing #ifdef, userspace code trying to use this header
> directly won't compile. glibc manually removes it, bionic removes it
> using a script. If we add this, the preprocessor can remove it instead.

Is that the right solution? Shouldn't these software projects be
modified such that <scsi/scsi.h> is *not* included?

Thanks,

Bart.


  reply	other threads:[~2023-10-16 20:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16 20:42 enh
2023-10-16 20:48 ` Bart Van Assche [this message]
2023-10-16 22:06   ` enh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb983fa3-bf4d-42aa-b5c3-4927504c32d9@acm.org \
    --to=bvanassche@acm.org \
    --cc=enh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®