From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966701AbdKPSe4 (ORCPT ); Thu, 16 Nov 2017 13:34:56 -0500 Received: from mail-yw0-f193.google.com ([209.85.161.193]:51822 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965330AbdKPSeW (ORCPT ); Thu, 16 Nov 2017 13:34:22 -0500 X-Google-Smtp-Source: AGs4zMbM9OqQUISKF8p8Suv6aYJidoiQDJZUbMlZhZ7aU5p0qYmXkSE7eK9el5+/JTbsd9JVSKJXtw== Subject: Re: [PATCH 1/2] of: unittest: let dtc generate __local_fixups__ To: Rob Herring , devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <20171116180545.12322-1-robh@kernel.org> From: Frank Rowand Message-ID: Date: Thu, 16 Nov 2017 13:34:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171116180545.12322-1-robh@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/17 13:05, Rob Herring wrote: > Remove the manually added __local_fixups__ because dtc can now generate > them. This also fixes a new warning in the process: > > drivers/of/unittest-data/testcases.dtb: Warning (interrupts_extended_property): Could not get phandle node for /__local_fixups__/testcase-data/interrupts/interrupts-extended0:interrupts-extended(cell 3) > > Signed-off-by: Rob Herring > --- > drivers/of/unittest-data/testcases.dts | 56 ++-------------------------------- > 1 file changed, 2 insertions(+), 54 deletions(-) > > diff --git a/drivers/of/unittest-data/testcases.dts b/drivers/of/unittest-data/testcases.dts > index 12f7c3d649c8..ac616ad18ea6 100644 > --- a/drivers/of/unittest-data/testcases.dts > +++ b/drivers/of/unittest-data/testcases.dts > @@ -1,4 +1,6 @@ > /dts-v1/; > +/plugin/; > + > / { > testcase-data { > changeset { > @@ -23,57 +25,3 @@ > * The format of this data may be subject to change. For the time being consider > * this a kernel-internal data format. > */ > -/ { __local_fixups__ { > - testcase-data { > - phandle-tests { > - consumer-a { < snip > You should also delete the comment immediately above that describes the removed lines.