From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9779A243387 for ; Fri, 24 Jul 2026 13:19:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784899147; cv=none; b=XWJ9YXRItLrstYsYc2l9UU6xT0yLs9Zx/x9UUU93K0FecSWhpKp4H99KJU0yBjl1NqJw4b4cMXqZghlTgA2OIF/LqAIIcrChf9+5r0ipvjqHZz4ZdGKPVf+qs4i7wWppACdG4yglIbgCLv4gnjLuMUYqUa4f7p4LE676icOBEEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784899147; c=relaxed/simple; bh=y96u64ErtA/bg8tEggAjTrhFnPK5Yt0gF2V7ZgCPuaE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AYVAZtWS1gI5XabKSRfMpS3UxeGA7UtcNlFMHETSk2kd/rrGoHFGZNYLRTBiSHSeJ+sZKOXQZUzAlSQrY8mu/D0Q9XJJhCNCHYIlOG/Im+IvX/zGPKsGHbifkK0mYoj1BaZcFj0F0uLakUq3kF6NnEoVHoSsyXWI0vQZKmM2fro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lQaOCqLv; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lQaOCqLv" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5b0190a62beso65440e87.0 for ; Fri, 24 Jul 2026 06:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784899144; x=1785503944; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=5UuJhAikCadaYJiJSU/kID0E8iIJqj6Edvilo/p0kO4=; b=lQaOCqLvl4LK5twe99KXJRjTc1diUhGf9y+BV6LMYcV3VcUnMoIrlL/pO1QW8Ft99O wJEYKGmb1lh48K5mxSvjN+55xsKR+W5S85h0vume2fdKwuVHVc6TleF8eKbK1bVjGlIt t1YeaRVQle8p9mN77l+f9e3Ro1WLSUusNjZaGV7daWQbLzlsHu3ijF9HdyLAQlNHSEGW CDll710tvjE+mxzc8KXpSvLMu63ngkf4r9efciggCBTBlY2DrqOUNytvhWt9DsYInDk+ r0go8intWeRWmwTuLwL5eiIGk697+HSr5UpbDNWssgKY6j0HtsTQ0DcnZ7kqq8BRapp9 pUAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784899144; x=1785503944; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5UuJhAikCadaYJiJSU/kID0E8iIJqj6Edvilo/p0kO4=; b=OULKXuk96K7JRGSbvQBFcnRKYNg22tlMT7HGoMRO9Ht71q1yEKOKVUDpmjXyz2/JS1 NJWvaP0X/sNM1mj5YQSckbpQl8FRT2rm1B40rif9HGxRdkN3rHPqDUPw1OCJIBP2drNP A+18uOHxHQu8UcY/BpQMyt0UVA1VjESLDghmNApbP4HMqcZWCqo2bYAetyfHHzdMsQDT N66y2WjNEXzzNFfdxgl0h+xtLY/3N6WcY0qnlhTwl3H4rOWgu3wGpd0BhOHv11vKjHme 0iWdbB2QFxiH972E/uUp4fqWoi9SR3g2In3xxnkVDPIxVp0h0Mh1JYolG4JIl+TjdpYo RJqQ== X-Forwarded-Encrypted: i=1; AHgh+Rq1PP/dyu0tCLO4SB1OoXZJPNn+cv7pJBNW4t/CvJwSlbAGJeus4jQ4ZHF6DPNLfWVDhmAoq/320YPUa+4=@vger.kernel.org X-Gm-Message-State: AOJu0YzvGGkUU+uwRZuBvUCZnIgR7HY293WVnA7vrmtZNLMHKEGceL6o l28iyWPm6IXzah4qLTiJwcNwGF1MP7Pq80UVR0SzWIzieMdkcegH+UgncqSmuQyUEWo= X-Gm-Gg: AR+sD12bE0vahrmifunoapOhLyC6a69NOiypJ83rLdTiPmujbASiZZPNnWYpW/14HeL AhBpDt4yUTM6Q1/qhoUbBT4xqmAxk8dAPjaG49jb9yjtgjNlrT9aSNejBN79sVHfpo8GinytuP+ cke3Ljwg5CvzB6PXnCBJ6yDEAiMPGfbzQeauxrbgtGKJ7PDyjxxcCPoTVePZeaQ6FgB7gUbmZ+k ZNJpESnDG+tVWkO97gdVfmn3/BY65lXW7GxT0Ph+yjXawUma/dXU2W6jLJFVbCAUv3bczYnOBX4 7h4MGII2urpana6Uwt2f2c2X1hr28CXpJyPWZlnXH91WeX/I8lTKvsvz5wEB+UPDWgXeR6KJliN Z0JxDmR7xRS8siJpkqRg4y8dGfwuhEn5kskOrbOwPQcCnFOf7N4v0/v2BYdei2JBUhAERnQVk9Q xK4NLa8Ig1XLzV479HdwqDIMh9+Pe/yaMqV3oqEC/9TUoZwvdf10cjU1Ux X-Received: by 2002:a05:6512:3404:b0:5b1:5b44:c4cb with SMTP id 2adb3069b0e04-5b2b2f7c2acmr894270e87.7.1784899143652; Fri, 24 Jul 2026 06:19:03 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2a9bafdf5sm1500376e87.35.2026.07.24.06.19.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 06:19:03 -0700 (PDT) Message-ID: Date: Fri, 24 Jul 2026 16:19:02 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/17] media: i2c: os05b10: add V4L2 digital gain control To: Tarang Raval , sakari.ailus@linux.intel.com, mehdi.djait@linux.intel.com Cc: Himanshu Bhavani , Elgin Perumbilly , Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260718200912.16001-1-tarang.raval@siliconsignals.io> <20260718200912.16001-6-tarang.raval@siliconsignals.io> From: Vladimir Zapolskiy In-Reply-To: <20260718200912.16001-6-tarang.raval@siliconsignals.io> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/18/26 23:08, Tarang Raval wrote: > Stop programming digital gain in the common register sequence and expose it as > a V4L2_CID_DIGITAL_GAIN control. Initialize the new control and handle writes > in the ctrl callback. > > Signed-off-by: Tarang Raval > Reviewed-by: Mehdi Djait > --- > drivers/media/i2c/os05b10.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c > index 12c4e2610d6f..abf3d2970900 100644 > --- a/drivers/media/i2c/os05b10.c > +++ b/drivers/media/i2c/os05b10.c > @@ -138,7 +138,6 @@ static const struct cci_reg_sequence os05b10_common_regs[] = { > { CCI_REG8(0x3503), 0x88 }, > { OS05B10_REG_DIGITAL_GAIN, 0x0400 }, > { OS05B10_REG_ANALOG_GAIN_SHORT, 0x0080 }, > - { OS05B10_REG_DIGITAL_GAIN_SHORT, OS05B10_DIGITAL_GAIN_DEFAULT }, > { OS05B10_REG_EXPOSURE_SHORT, 0x000020 }, > { CCI_REG8(0x3600), 0x4d }, > { CCI_REG8(0x3601), 0x08 }, > @@ -549,6 +548,10 @@ static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl) > ret = cci_write(os05b10->cci, OS05B10_REG_ANALOG_GAIN, > ctrl->val, NULL); > break; > + case V4L2_CID_DIGITAL_GAIN: > + ret = cci_write(os05b10->cci, OS05B10_REG_DIGITAL_GAIN, > + ctrl->val, NULL); OS05B10_REG_DIGITAL_GAIN_SHORT control is removed, but OS05B10_REG_DIGITAL_GAIN is left in the long sequence and rewritten here. If OS05B10_REG_DIGITAL_GAIN_SHORT control is just not needed, please remove it from the long sequence in advance, and then this change will touch the remaining OS05B10_REG_DIGITAL_GAIN control only. > + break; > case V4L2_CID_EXPOSURE: > ret = cci_write(os05b10->cci, OS05B10_REG_EXPOSURE, > ctrl->val, NULL); > @@ -925,7 +928,7 @@ static int os05b10_init_controls(struct os05b10 *os05b10) > int ret; > > ctrl_hdlr = &os05b10->handler; > - v4l2_ctrl_handler_init(ctrl_hdlr, 8); > + v4l2_ctrl_handler_init(ctrl_hdlr, 9); > > pixel_rate = os05b10_pixel_rate(os05b10, mode); > v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, V4L2_CID_PIXEL_RATE, > @@ -967,6 +970,10 @@ static int os05b10_init_controls(struct os05b10 *os05b10) > OS05B10_ANALOG_GAIN_STEP, > OS05B10_ANALOG_GAIN_DEFAULT); > > + v4l2_ctrl_new_std(ctrl_hdlr, &os05b10_ctrl_ops, V4L2_CID_DIGITAL_GAIN, > + OS05B10_DIGITAL_GAIN_MIN, OS05B10_DIGITAL_GAIN_MAX, > + OS05B10_DIGITAL_GAIN_STEP, OS05B10_DIGITAL_GAIN_DEFAULT); > + > if (ctrl_hdlr->error) { > ret = ctrl_hdlr->error; > dev_err(os05b10->dev, "control init failed (%d)\n", ret); -- Best wishes, Vladimir