From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792675477; b=Qu9bxmlGFHQazhJgNqbJdHQozhTS7BYkXtQD75CeQreeOsOad7/tNYPVBxqOsF7pp61U RSOhZWxjzgtTsJzkQyxdBytqX7Hy9OwJOpB/GP4l7rHxr5h2RSLBE+fxIwNBPQ7Jlgtqb bbVu2yQxtGBdnifbmzsyLNABXP4dnDqO5q1N1apagoObjytdVanQeW8ei/CIQfPVazjvZ FX0UDh6EbEtlmR36Vy2pYON7fqoHQ5QR09Zi57ZLxulfVA6qey+xIj1eYSJhSbFqgg5yL M2G3aMP4G+7ZtTialCXJPD67++WKARgNx21pYFSlTcgiObuQ3HFEWEgW/YNPolg2NvQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792675477; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:Date:From:To:cc:Subject: In-Reply-To:Message-ID:References:MIME-Version:Content-Type: X-Scanned-By; bh=h8PVwHmVxgj3EDuc7a9+2bgJCaWhNY770RjA2x6wCHc=; b=arxUBXv5uwQZzinSgao3xq8VMMTWrCcqYMiXb6SItOK8sLGrg0uwNQhPxY1Kn0EtkwIh ZujFztWP6TMsy0EKmXu8BZznAJQ+Egmb5JnD5CInVa9ECLXOwCDbwgaDBgeFjBCtGlK+6 aslO4MUJ/I9CDWU7ETao/YebIVnvgZ4UM3k4/CutIJk1GBO2nV22g1ossiITY8GcnCFIt V+nS4Gnm+fnB+pquSOskXqWSSKMy8zVIp6hJW+iSoIJhTjkEBBKPY19qslBgnyaMW6LPo 0LcaZvo30Ipa4+Ju3oorxbb+wSHoMKWFVDNHwb8r/t3od6PELRplslYQcCLr3N5bmew== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gY23jKcY; arc=none smtp.remote-ip=170.10.129.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 195A2606A31F for ; Thu, 22 Oct 2026 13:24:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 195A2606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gY23jKcY DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792675475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h8PVwHmVxgj3EDuc7a9+2bgJCaWhNY770RjA2x6wCHc=; b=gY23jKcYBnLhVP5+LcoUEkISpZOqdN1S+Vj4yLz+LDvGmYbqM7LlezRkok9vM+JzV9Ny5/ 1Vv+Jv4QzCM2nOOPMp93la2rQjQAsnDuOMWZjJkQDEYnsxz6Mx5pje40kJdd3diPXouCSB GfDkjR4Q7cqbcrWrDFUZoLqUoevjFns= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-83-8zvWsLXrPvm5QkJJIiVDCg-1; Thu, 22 Oct 2026 09:24:31 -0400 X-MC-Unique: 8zvWsLXrPvm5QkJJIiVDCg-1 X-Mimecast-MFC-AGG-ID: 8zvWsLXrPvm5QkJJIiVDCg_1792675468 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A7AF918004A9; Thu, 22 Oct 2026 13:24:27 +0000 (UTC) Received: from mpatocka-thinkpadx1carbongen12.rmtcz.csb (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0F90D195608C; Thu, 22 Oct 2026 13:24:20 +0000 (UTC) Date: Thu, 22 Oct 2026 15:24:18 +0200 (CEST) From: Mikulas Patocka To: Frank.Li@oss.nxp.com cc: Alasdair Kergon , Mike Snitzer , Benjamin Marzinski , Song Liu , Yu Kuai , Li Nan , Xiao Ni , Dan Williams , Herbert Xu , "David S. Miller" , Jonathan Corbet , Shuah Khan , Randy Dunlap , dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, Anatolij Gustschin , Saeed Bishara , Rameshwar Prasad Sahu , Thomas Petazzoni , Anup Patel , Frank Li Subject: Re: [PATCH RFC 1/4] md/dm-integrity: replace async_tx with synchronous xor for journal In-Reply-To: <20261015-asycn_tx_remove-v1-1-056a7085e0a1@nxp.com> Message-ID: References: <20261015-asycn_tx_remove-v1-0-056a7085e0a1@nxp.com> <20261015-asycn_tx_remove-v1-1-056a7085e0a1@nxp.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On Thu, 15 Oct 2026, Frank.Li@oss.nxp.com wrote: > From: Frank Li > > Remove the dependency on the async_tx framework from dm-integrity's > xor_journal() function. The async_xor() + async_tx_issue_pending_all() > pattern is replaced with direct kmap_local_page() + memcpy() + > crypto_xor() + kunmap_local() per page, which is simpler and removes > the need for #include . > > async_tx adds significant complexity and maintenance overhead while > providing little practical benefit on modern systems, where RAID parity > computation is typically performed more efficiently by CPU-based XOR/PQ > implementations than by DMA engine offload. > > Signed-off-by: Frank Li Reviewed-by: Mikulas Patocka > --- > drivers/md/dm-integrity.c | 26 ++++++++++++++------------ > 1 file changed, 14 insertions(+), 12 deletions(-) > > diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c > index 802b377613b06..6bd0623b6402a 100644 > --- a/drivers/md/dm-integrity.c > +++ b/drivers/md/dm-integrity.c > @@ -23,7 +23,6 @@ > #include > #include > #include > -#include > #include > > #include "dm-audit.h" > @@ -896,7 +895,6 @@ static void complete_journal_op(void *context) > static void xor_journal(struct dm_integrity_c *ic, bool encrypt, unsigned int section, > unsigned int n_sections, struct journal_completion *comp) > { > - struct async_submit_ctl submit; > size_t n_bytes = (size_t)(n_sections * ic->journal_section_sectors) << SECTOR_SHIFT; > unsigned int pl_index, pl_offset, section_index; > struct page_list *source_pl, *target_pl; > @@ -913,14 +911,11 @@ static void xor_journal(struct dm_integrity_c *ic, bool encrypt, unsigned int se > > atomic_add(roundup(pl_offset + n_bytes, PAGE_SIZE) >> PAGE_SHIFT, &comp->in_flight); > > - init_async_submit(&submit, ASYNC_TX_XOR_ZERO_DST, NULL, complete_journal_op, comp, NULL); > - > section_index = pl_index; > > do { > size_t this_step; > - struct page *src_pages[2]; > - struct page *dst_page; > + void *src0, *src1, *dst; > > while (unlikely(pl_index == section_index)) { > unsigned int dummy; > @@ -935,11 +930,20 @@ static void xor_journal(struct dm_integrity_c *ic, bool encrypt, unsigned int se > } > > this_step = min(n_bytes, (size_t)PAGE_SIZE - pl_offset); > - dst_page = target_pl[pl_index].page; > - src_pages[0] = source_pl[pl_index].page; > - src_pages[1] = ic->journal_xor[pl_index].page; > > - async_xor(dst_page, src_pages, pl_offset, 2, this_step, &submit); > + src0 = kmap_local_page(source_pl[pl_index].page); > + src1 = kmap_local_page(ic->journal_xor[pl_index].page); > + dst = kmap_local_page(target_pl[pl_index].page); > + > + memcpy(dst + pl_offset, src0 + pl_offset, this_step); > + crypto_xor(dst + pl_offset, src1 + pl_offset, this_step); > + > + kunmap_local(dst); > + kunmap_local(src1); > + kunmap_local(src0); > + > + /* mirror async_tx per-page completion accounting */ > + complete_journal_op(comp); > > pl_index++; > pl_offset = 0; > @@ -947,8 +951,6 @@ static void xor_journal(struct dm_integrity_c *ic, bool encrypt, unsigned int se > } while (n_bytes); > > BUG_ON(n_sections); > - > - async_tx_issue_pending_all(); > } > > static void complete_journal_encrypt(void *data, int err) > > -- > 2.43.0 >