From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D9B0C43334 for ; Thu, 21 Jul 2022 17:28:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230449AbiGUR2Q (ORCPT ); Thu, 21 Jul 2022 13:28:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbiGUR2O (ORCPT ); Thu, 21 Jul 2022 13:28:14 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DBA489EAF for ; Thu, 21 Jul 2022 10:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658424494; x=1689960494; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=C7OM+7gmEvFiG7txHrhKLL6FE+AyPkqqZ7WvQWwgEQE=; b=K/PiTF2dtDxE/2ORKp063ZAcnBFck+2oi9tPvICxTcLlhW8kwineTDSC vtTiYFJH5qyFqpEni3L2xFZPp4Glhg73PK226pmvJl5rpt6y/Yg9jnJdf KZywwUVAbpBROBKgB2E62eVStndBHArbosHkOlp/Wit5HMv1Him62Y//m s+u111LPen4LYDGujtsqTJ7+hTpy47XDA+za7nj5RAYflmtpJqhU171sK VLJmuELtjZdgvux50MIcHpptUHgDgHEZq1YDD+m8/3tRRK7Q5X+3JTJAP JfKPg5hSvb8nkbYw4dR1knSZRM9DBw2vbkYWVPGbuDq2dO+4pDGbtcwWr w==; X-IronPort-AV: E=McAfee;i="6400,9594,10415"; a="270156891" X-IronPort-AV: E=Sophos;i="5.93,183,1654585200"; d="scan'208";a="270156891" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2022 10:19:31 -0700 X-IronPort-AV: E=Sophos;i="5.93,183,1654585200"; d="scan'208";a="573830939" Received: from vasantgx-mobl.amr.corp.intel.com (HELO [10.212.244.191]) ([10.212.244.191]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2022 10:19:30 -0700 Message-ID: Date: Thu, 21 Jul 2022 10:19:30 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v8 5/5] x86/tdx: Add Quote generation support Content-Language: en-US To: Sathyanarayanan Kuppuswamy , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org Cc: "H . Peter Anvin" , "Kirill A . Shutemov" , Tony Luck , Andi Kleen , Kai Huang , Wander Lairson Costa , Isaku Yamahata , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, linux-kernel@vger.kernel.org References: <20220609025220.2615197-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220609025220.2615197-6-sathyanarayanan.kuppuswamy@linux.intel.com> <214e24f0-5236-be8d-024a-da48737d854a@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/21/22 10:16, Sathyanarayanan Kuppuswamy wrote: >> What is this "additional data"? Is that "REPORTDATA" from the TDX >> module spec? >> >> "Additional REPORTDATA, a 64-byte value, is provided by the >> guest TD to be included in the TDG.MR.REPORT." > > It is not the REPORTDATA. REPORTDATA is already included in the TDREPORT during > REPORT generation process (using TDG.MR.REPORT). > > Spec does not clearly define the details about the additional data. I think it is > related to certificates. > > Isaku, do you have more details about it? > > Current ABI allows attestation service and agent to decide the quote size. So > we can't make assumptions on what that size will be. > > Following is copied from TDX Module specification, sec titled "Measurement > and Attestation" > > An Intel SGX Quoting Enclave, written specifically to support quoting Intel TDX TDs, > uses a new ENCLU instruction leaf, EVERIFYREPORT2, to help check the integrity of the > TDG.MR.REPORT. If it passes, the Quoting Enclave can use a certified quote signing key > to sign a quote containing the guest TD’s measurements and the additional data being > quoted. We're off in the weeds again. How many bytes does the TDX module read from and write to the guest physical address space? What are the absolute limits? What is the minimum and the maximum that the kernel needs to handle?