From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A774D1509BD for ; Thu, 19 Dec 2024 21:28:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734643704; cv=none; b=iWIbQVzc3Jq5wC7E7+Cx3VsS2WwJLDKn4iXjg7cERJDvx2U+p9ilkJ2kksSvJKGvLss+xrburQLvFEIOAO518a2/kGKuaQkH8ViKsqFPk6g70ZawhhIOIWxoV1zJBeex32vbgJBc/m2P5D6IaXsDTsnkYA99JyCDvNUJS42gVZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734643704; c=relaxed/simple; bh=cgkCGW7F8juBfQc78upAw76Zpu/tXczi1pONS96pY0U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aTPmlsDFClw23JQFsD07LtsR5EwYShhHvMENe6pWC2CAP4kx3LVqypRcYr1MOy/PMMIdMSsJayTyqrmZN/yDMllQ1CwaNZkO2xf12qhxUOguQXRC/BSn/2LZuWbu2gCb1VQ4xKArCI09bBQQDkdeTZAVPRTmKxkPuUd0i+xQGW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KGU3Prd7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KGU3Prd7" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BJL0l1V017639 for ; Thu, 19 Dec 2024 21:28:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /VAUnAOqDKD/w7nsfXSvt4pC3AXzpCBYpE3jsdeI1ag=; b=KGU3Prd77RQ/ARn1 UbzGSNkfE7ojalLZbAX2gFWUCHWV3WmJqjZ7ifLrsfNKziWEG5UHF2VTjN3QW9zi D0aqMvbtyK7768hr9iaQFzK7BzXBCAM+B2dKDHcspKdWSIJYVPMNDSS+Bl+evt4+ z8sEmKCFYcbvAcpOB55tK6/iFC/y3lX7h81Cw95Tw/RynVHiF1URyFJy6ajUN3Gn q9S46kZiOpPk0ppJk0lIL06beV5DjLKDGTMXWaNQpOh1aBVGA6DmqbgNeN3YEHde Cl59q9AVJou+LilCK7sXpKanrINu4Kxi/XTPYL+50k48UXiyAVZbZxxHvf5IHOra Ahd8TQ== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43mu1dg2ud-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 19 Dec 2024 21:28:21 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6d8824c96cdso3689366d6.2 for ; Thu, 19 Dec 2024 13:28:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734643700; x=1735248500; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/VAUnAOqDKD/w7nsfXSvt4pC3AXzpCBYpE3jsdeI1ag=; b=MAwvqyO9DhOQC/GiNqwxdjo8PN8gBzZ4gD+u9BGAoAzQcGt/cc/IQifaQ/pK9D31x+ G4JjB258g9Zqc3pJnqOXNTKnDsSCiNo0BH9GNnyaAUw3uVg7cGpvG1tgsKFsinQc4dOF ro36PWUZtP5F2nr4QMg1XiHlWz7aPmDX62J1fWrsc/YxsfpX77At6g3lqIh/xenKRXC7 dU8eSs/krPtAIyAXA1u1Fb3IqwtpCX40z5sahLZNYq7o1DyUHlOK7IqxE9DKS65AB86j p4jkbAyTwRSPNp493RP0jzFT9EtmBMrBcZSyYASpIVra7WPwKYZ49Y+LqDUUre0XAEvl IJpA== X-Forwarded-Encrypted: i=1; AJvYcCU4YNnml7d1aby/FwCPySqXpH4eEiyAiy2/OleSgjWM/2x5A/KalPGvWTHgpamhc4RUmfUlKqZetS4PDmQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwV2fR4wSzvb5vtilRfLQr4qh1PFGXxN+jRbmhSIlfLqbozuE/i J8KITVw2G/bZliswS8OvpxDPqh9PHCqikpaWMz3F/YrzIiKsJwgqaKBBfHCgrs2nru3I298bX0h xxINRiBMY8WYtG4XTgL4pYGD+v2MqTeUBnpBoDg/ode1RSoiE9ormeuT+XjMcg0E= X-Gm-Gg: ASbGncv+aB6ugyztfKkZJVI+UUE023pZfrcRS1wRKIuzPz3Teq2qEVhFU34ywyMBguG ylGUJS089YS2/Obt+jX/K0Zrxqtz4l9FRppPFCo0NewZWYB4KoWZjs+/a5RsG8hUSVX9ocuAC++ qTpzSezxeN7EOh93yBh/cwFov/QQqa+W3kD46MTQcDSi3uLbmQ0x1fzo5AV6B2Fro5i8zuv1xBh lGe212ckxxi78phASi0/C4/iQY0S3pthnAS4oDl03aNbVuviNRAxnL8r3r99bdn6w07gdTFUiLq f5JpKOmA68P1NM4ASlj2z7Jusng5R5Mbg2o= X-Received: by 2002:a05:6214:2a89:b0:6d8:8cb0:b403 with SMTP id 6a1803df08f44-6dd233acd65mr2590496d6.11.1734643700675; Thu, 19 Dec 2024 13:28:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IHJnIn0G4+Wnlxs6LmziXnXITZL4O7KHJ/pJ3YBrBe8olWnjoRqJWPN5SOL8KlIfXyMXzRSAA== X-Received: by 2002:a05:6214:2a89:b0:6d8:8cb0:b403 with SMTP id 6a1803df08f44-6dd233acd65mr2590216d6.11.1734643700234; Thu, 19 Dec 2024 13:28:20 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d806fed718sm1056008a12.62.2024.12.19.13.28.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 13:28:19 -0800 (PST) Message-ID: Date: Thu, 19 Dec 2024 22:28:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/5] arm64: dts: qcom: Update IPQ9574 xo_board_clk to use fixed factor clock To: Jie Luo , Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_kkumarcs@quicinc.com, quic_suruchia@quicinc.com, quic_pavir@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, bartosz.golaszewski@linaro.org, srinivas.kandagatla@linaro.org References: <20241107-qcom_ipq_cmnpll-v6-0-a5cfe09de485@quicinc.com> <20241107-qcom_ipq_cmnpll-v6-5-a5cfe09de485@quicinc.com> <0776a26e-56cd-4838-9b52-210ae9a1f281@oss.qualcomm.com> <8063460d-18ad-4e54-8232-716bad9d37c3@quicinc.com> <2456ab36-f48e-4aa3-88e1-aeb7895c9816@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <2456ab36-f48e-4aa3-88e1-aeb7895c9816@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: gXyDiYvKiapUMqyt_qFM5uiaik1En0pq X-Proofpoint-GUID: gXyDiYvKiapUMqyt_qFM5uiaik1En0pq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 malwarescore=0 suspectscore=0 spamscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412190170 On 18.12.2024 12:17 PM, Jie Luo wrote: > > > On 12/13/2024 6:30 PM, Jie Luo wrote: >> >> >> On 12/13/2024 2:33 AM, Konrad Dybcio wrote: >>> On 7.11.2024 10:50 AM, Luo Jie wrote: >>>> xo_board_clk is fixed to 24 MHZ, which is routed from WiFi output clock >>>> 48 MHZ (also being the reference clock of CMN PLL) divided 2 by analog >>>> block routing channel. >>>> >>>> Signed-off-by: Luo Jie >>>> --- >>>>   arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 7 ++++++- >>>>   arch/arm64/boot/dts/qcom/ipq9574.dtsi            | 3 ++- >>>>   2 files changed, 8 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/ arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi >>>> index 78f6a2e053d5..9a8692377176 100644 >>>> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi >>>> @@ -174,8 +174,13 @@ &ref_48mhz_clk { >>>>       clock-mult = <1>; >>>>   }; >>>> +/* >>>> + * The frequency of xo_board_clk is fixed to 24 MHZ, which is routed >>>> + * from WiFi output clock 48 MHZ divided by 2. >>>> + */ >>>>   &xo_board_clk { >>>> -    clock-frequency = <24000000>; >>>> +    clock-div = <2>; >>>> +    clock-mult = <1>; >>>>   }; >>>>   &xo_clk { >>>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/ dts/qcom/ipq9574.dtsi >>>> index 8246a00a3e3e..25aed33e9358 100644 >>>> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi >>>> @@ -32,7 +32,8 @@ sleep_clk: sleep-clk { >>>>           }; >>>>           xo_board_clk: xo-board-clk { >>>> -            compatible = "fixed-clock"; >>>> +            compatible = "fixed-factor-clock"; >>>> +            clocks = <&ref_48mhz_clk>; >>> >>> This must be squashed with the previous patch, you can't introduce >>> code and replace it immediately afterwards. >>> >>> Konrad > > Hi Konrad, > > Looking at this comment again, there may have been some > misunderstanding. We are not introducing xo_board_clk in patch 4 of this > series. xo_board_clk is a pre-existing node. > > As part of this additional patch 5, we wanted to address Dmitry's > comment earlier in v5 (reference to comment below), by converting the > xo_board_clk as well to a fixed-factor clock. So it is better to keep > this change as a separate patch in my view. Hope this is OK. Oh okay.. What's the difference between xo_board_clk and xo_clk then, if the divider is accounted for in xo_board_clk? Konrad