From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751272AbdEPLPO (ORCPT <rfc822;w@1wt.eu>);
        Tue, 16 May 2017 07:15:14 -0400
Received: from mail-qt0-f174.google.com ([209.85.216.174]:35081 "EHLO
        mail-qt0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751017AbdEPLPM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 16 May 2017 07:15:12 -0400
Subject: Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register
 support
To: Dong Aisheng <aisheng.dong@nxp.com>, linux-serial@vger.kernel.org
References: <1494834539-17523-3-git-send-email-aisheng.dong@nxp.com>
Cc: fugang.duan@nxp.com, dongas86@gmail.com, gregkh@linuxfoundation.org,
        yangbo.lu@nxp.com, linux-kernel@vger.kernel.org, stefan@agner.ch,
        Mingkai.Hu@nxp.com, jslaby@suse.com,
        linux-arm-kernel@lists.infradead.org
From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Message-ID: <fb9fe0cd-5ca7-74e6-33dc-7638e205b2e3@cogentembedded.com>
Date: Tue, 16 May 2017 14:15:08 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1494834539-17523-3-git-send-email-aisheng.dong@nxp.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>  static u32 lpuart32_read(void __iomem *addr)
>  {
> -	return ioread32be(addr);
> +	return lpuart_is_be ? ioread32be(addr) : readl(addr);
>  }
>  
>  static void lpuart32_write(u32 val, void __iomem *addr)
>  {
> -	iowrite32be(val, addr);
> +	if (lpuart_is_be)
> +		iowrite32be(val, addr);
> +	else
> +		writel(val, addr);
>  }

What if this is ever executed on big endian system?