From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] USB: serial: add missing MODULE_DESCRIPTION() macros
Date: Fri, 5 Jul 2024 07:36:14 -0700 [thread overview]
Message-ID: <fba80871-645f-4d8d-8992-424812e51cef@quicinc.com> (raw)
In-Reply-To: <ZofajSjhaaZsFRro@hovoldconsulting.com>
On 7/5/2024 4:35 AM, Johan Hovold wrote:
> On Tue, Jun 11, 2024 at 10:52:54AM -0700, Jeff Johnson wrote:
>> With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/ch341.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb_debug.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/mxuport.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/navman.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/qcaux.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb-serial-simple.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/symbolserial.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>
> I amended the commit message with the (recent) commit that added this
> W=1 warning (and dropped C=1). I also tweaked three descriptions
> slightly. End result is here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=9f4dc05107a6db3743e6b9ea4014cbdc3795682d
>
> Thanks.
>
> Johan
LGTM, thanks for the cleanup!
/jeff
next prev parent reply other threads:[~2024-07-05 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 17:52 Jeff Johnson
2024-06-26 16:44 ` Jeff Johnson
2024-07-05 11:35 ` Johan Hovold
2024-07-05 14:36 ` Jeff Johnson [this message]
2024-07-23 18:44 ` Jeff Johnson
2024-08-20 8:30 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fba80871-645f-4d8d-8992-424812e51cef@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®