From: "Arnd Bergmann" <arnd@arndb.de>
To: "Kunwu Chan" <chentao@kylinos.cn>, "Jeremy Kerr" <jk@ozlabs.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
aneesh.kumar@kernel.org,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] powerpc/cell: Code cleanup for spufs_mfc_flush
Date: Fri, 26 Jan 2024 07:27:23 +0100 [thread overview]
Message-ID: <fbae8c8e-6788-4749-b7e0-b64c9fffe85a@app.fastmail.com> (raw)
In-Reply-To: <20240126021258.574916-1-chentao@kylinos.cn>
On Fri, Jan 26, 2024, at 03:12, Kunwu Chan wrote:
> This part was commented from commit a33a7d7309d7
> ("[PATCH] spufs: implement mfc access for PPE-side DMA")
> in about 18 years before.
>
> If there are no plans to enable this part code in the future,
> we can remove this dead code.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Nobody is actively working on this code, so it clearly won't
be needed in the future.
Acked-by: Arnd Bergmann <arnd@arndb.de>
On the other hand there is probably little use in removing
the dead code either. It looks you sent a lot of these
patches with identical changelog texts to remove blocks
of dead code, which does not seem productive to me as
these were clearly all left in the code to document
something.
Arnd
next prev parent reply other threads:[~2024-01-26 6:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 2:12 Kunwu Chan
2024-01-26 6:27 ` Arnd Bergmann [this message]
2024-01-26 9:11 ` Kunwu Chan
2024-05-08 13:39 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbae8c8e-6788-4749-b7e0-b64c9fffe85a@app.fastmail.com \
--to=arnd@arndb.de \
--cc=aneesh.kumar@kernel.org \
--cc=chentao@kylinos.cn \
--cc=christophe.leroy@csgroup.eu \
--cc=jk@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®